Commit 1635304d authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: operation: drop redundant oom message

Drop redundant OOM message, which would already have been logged by the
memory subsystem.

Also remove a FIXME about possibly sending a pre-allocated response,
which is neither possible or desirable. If we ever run out of memory we
have bigger problems then getting a response back to firmware.
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 2593261d
......@@ -673,12 +673,8 @@ static int gb_operation_response_send(struct gb_operation *operation,
return 0;
if (!operation->response) {
if (!gb_operation_response_alloc(operation, 0)) {
dev_err(&connection->dev,
"error allocating response\n");
/* XXX Respond with pre-allocated -ENOMEM? */
if (!gb_operation_response_alloc(operation, 0))
return -ENOMEM;
}
}
/* Reference will be dropped when message has been sent. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment