Commit 1d240875 authored by Vivien Didelot's avatar Vivien Didelot Committed by Ingo Molnar

x86/platform/ts5500: Use the DEVICE_ATTR_RO() macro

Use the DEVICE_ATTR_RO() helper macro to simplify the declaration
of read-only sysfs attributes in the TS5500 code..
Signed-off-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>
Link: http://lkml.kernel.org/r/1404860269-11837-2-git-send-email-vivien.didelot@savoirfairelinux.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 1795cd9b
...@@ -147,45 +147,39 @@ static int __init ts5500_detect_config(struct ts5500_sbc *sbc) ...@@ -147,45 +147,39 @@ static int __init ts5500_detect_config(struct ts5500_sbc *sbc)
return ret; return ret;
} }
static ssize_t ts5500_show_id(struct device *dev, static ssize_t id_show(struct device *dev, struct device_attribute *attr,
struct device_attribute *attr, char *buf) char *buf)
{ {
struct ts5500_sbc *sbc = dev_get_drvdata(dev); struct ts5500_sbc *sbc = dev_get_drvdata(dev);
return sprintf(buf, "0x%.2x\n", sbc->id); return sprintf(buf, "0x%.2x\n", sbc->id);
} }
static DEVICE_ATTR_RO(id);
static ssize_t ts5500_show_jumpers(struct device *dev, static ssize_t jumpers_show(struct device *dev, struct device_attribute *attr,
struct device_attribute *attr, char *buf)
char *buf)
{ {
struct ts5500_sbc *sbc = dev_get_drvdata(dev); struct ts5500_sbc *sbc = dev_get_drvdata(dev);
return sprintf(buf, "0x%.2x\n", sbc->jumpers >> 1); return sprintf(buf, "0x%.2x\n", sbc->jumpers >> 1);
} }
static DEVICE_ATTR_RO(jumpers);
#define TS5500_SHOW(field) \
static ssize_t ts5500_show_##field(struct device *dev, \ #define TS5500_ATTR_BOOL(_field) \
struct device_attribute *attr, \ static ssize_t _field##_show(struct device *dev, \
char *buf) \ struct device_attribute *attr, char *buf) \
{ \ { \
struct ts5500_sbc *sbc = dev_get_drvdata(dev); \ struct ts5500_sbc *sbc = dev_get_drvdata(dev); \
return sprintf(buf, "%d\n", sbc->field); \ \
} return sprintf(buf, "%d\n", sbc->_field); \
} \
TS5500_SHOW(sram) static DEVICE_ATTR_RO(_field)
TS5500_SHOW(rs485)
TS5500_SHOW(adc) TS5500_ATTR_BOOL(sram);
TS5500_SHOW(ereset) TS5500_ATTR_BOOL(rs485);
TS5500_SHOW(itr) TS5500_ATTR_BOOL(adc);
TS5500_ATTR_BOOL(ereset);
static DEVICE_ATTR(id, S_IRUGO, ts5500_show_id, NULL); TS5500_ATTR_BOOL(itr);
static DEVICE_ATTR(jumpers, S_IRUGO, ts5500_show_jumpers, NULL);
static DEVICE_ATTR(sram, S_IRUGO, ts5500_show_sram, NULL);
static DEVICE_ATTR(rs485, S_IRUGO, ts5500_show_rs485, NULL);
static DEVICE_ATTR(adc, S_IRUGO, ts5500_show_adc, NULL);
static DEVICE_ATTR(ereset, S_IRUGO, ts5500_show_ereset, NULL);
static DEVICE_ATTR(itr, S_IRUGO, ts5500_show_itr, NULL);
static struct attribute *ts5500_attributes[] = { static struct attribute *ts5500_attributes[] = {
&dev_attr_id.attr, &dev_attr_id.attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment