Commit 25bac122 authored by Fengguang Wu's avatar Fengguang Wu Committed by Jens Axboe

drivers/block/mtip32xx/mtip32xx.c:4029:1: sparse: symbol 'mtip_workq_sdbf0'...

drivers/block/mtip32xx/mtip32xx.c:4029:1: sparse: symbol 'mtip_workq_sdbf0' was not declared. Should it be static?

Hi Asai,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.dk/linux-block.git for-3.9/drivers
head:   3d6a8743
commit: 16c906e5 [1/3] mtip32xx: Add workqueue and NUMA support

drivers/block/mtip32xx/mtip32xx.c:3267:17: sparse: cast to restricted __le32
>> drivers/block/mtip32xx/mtip32xx.c:4029:1: sparse: symbol 'mtip_workq_sdbf0' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4030:1: sparse: symbol 'mtip_workq_sdbf1' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4031:1: sparse: symbol 'mtip_workq_sdbf2' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4032:1: sparse: symbol 'mtip_workq_sdbf3' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4033:1: sparse: symbol 'mtip_workq_sdbf4' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4034:1: sparse: symbol 'mtip_workq_sdbf5' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4035:1: sparse: symbol 'mtip_workq_sdbf6' was not declared. Should it be static?
>> drivers/block/mtip32xx/mtip32xx.c:4036:1: sparse: symbol 'mtip_workq_sdbf7' was not declared. Should it be static?
   drivers/block/mtip32xx/mtip32xx.c: In function 'mtip_hw_read_flags':
   drivers/block/mtip32xx/mtip32xx.c:2723:1: warning: the frame size of 1036 bytes is larger than 1024 bytes [-Wframe-larger-than=]
   drivers/block/mtip32xx/mtip32xx.c: In function 'mtip_hw_read_registers':
   drivers/block/mtip32xx/mtip32xx.c:2700:1: warning: the frame size of 1044 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Please consider folding the below diff :-)
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3d6a8743
...@@ -4122,14 +4122,14 @@ static inline int mtip_get_next_rr_node(void) ...@@ -4122,14 +4122,14 @@ static inline int mtip_get_next_rr_node(void)
return next_node; return next_node;
} }
DEFINE_HANDLER(0); static DEFINE_HANDLER(0);
DEFINE_HANDLER(1); static DEFINE_HANDLER(1);
DEFINE_HANDLER(2); static DEFINE_HANDLER(2);
DEFINE_HANDLER(3); static DEFINE_HANDLER(3);
DEFINE_HANDLER(4); static DEFINE_HANDLER(4);
DEFINE_HANDLER(5); static DEFINE_HANDLER(5);
DEFINE_HANDLER(6); static DEFINE_HANDLER(6);
DEFINE_HANDLER(7); static DEFINE_HANDLER(7);
/* /*
* Called for each supported PCI device detected. * Called for each supported PCI device detected.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment