Commit 294dad05 authored by Paul Fulghum's avatar Paul Fulghum Committed by Linus Torvalds

[PATCH] fix synclink_gt diagnostics error reporting

Fix diagnostics error reporting that was being overwritten by incorrect use
of return codes from individual diagnostic functions.
Signed-off-by: default avatarPaul Fulghum <paulkf@microgate.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 04b374d0
...@@ -4702,13 +4702,13 @@ static int loopback_test(struct slgt_info *info) ...@@ -4702,13 +4702,13 @@ static int loopback_test(struct slgt_info *info)
static int adapter_test(struct slgt_info *info) static int adapter_test(struct slgt_info *info)
{ {
DBGINFO(("testing %s\n", info->device_name)); DBGINFO(("testing %s\n", info->device_name));
if ((info->init_error = register_test(info)) < 0) { if (register_test(info) < 0) {
printk("register test failure %s addr=%08X\n", printk("register test failure %s addr=%08X\n",
info->device_name, info->phys_reg_addr); info->device_name, info->phys_reg_addr);
} else if ((info->init_error = irq_test(info)) < 0) { } else if (irq_test(info) < 0) {
printk("IRQ test failure %s IRQ=%d\n", printk("IRQ test failure %s IRQ=%d\n",
info->device_name, info->irq_level); info->device_name, info->irq_level);
} else if ((info->init_error = loopback_test(info)) < 0) { } else if (loopback_test(info) < 0) {
printk("loopback test failure %s\n", info->device_name); printk("loopback test failure %s\n", info->device_name);
} }
return info->init_error; return info->init_error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment