Commit 2d3db26d authored by Guangbin Huang's avatar Guangbin Huang Committed by David S. Miller

net: hns3: modify an unsuitable print when setting unknown duplex to fibre

Currently, if device is in link down status and user uses
'ethtool -s' command to set speed but not specify duplex
mode, the duplex mode passed from ethtool to driver is
unknown value(255), and the fibre port will identify this
value as half duplex mode and print "only copper port
supports half duplex!". This message is confusing.

So for fibre port, only the setting duplex is half, prints
error and returns.
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e99f8e7f
...@@ -736,7 +736,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev, ...@@ -736,7 +736,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev,
if (ops->get_media_type) if (ops->get_media_type)
ops->get_media_type(handle, &media_type, &module_type); ops->get_media_type(handle, &media_type, &module_type);
if (cmd->base.duplex != DUPLEX_FULL && if (cmd->base.duplex == DUPLEX_HALF &&
media_type != HNAE3_MEDIA_TYPE_COPPER) { media_type != HNAE3_MEDIA_TYPE_COPPER) {
netdev_err(netdev, netdev_err(netdev,
"only copper port supports half duplex!"); "only copper port supports half duplex!");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment