Commit 3408e9ae authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

staging: lustre: osc: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent efeb257d
...@@ -218,7 +218,7 @@ static struct lu_device *osc_device_alloc(const struct lu_env *env, ...@@ -218,7 +218,7 @@ static struct lu_device *osc_device_alloc(const struct lu_env *env,
int rc; int rc;
od = kzalloc(sizeof(*od), GFP_NOFS); od = kzalloc(sizeof(*od), GFP_NOFS);
if (od == NULL) if (!od)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
cl_device_init(&od->od_cl, t); cl_device_init(&od->od_cl, t);
......
...@@ -119,7 +119,7 @@ static int osc_packmd(struct obd_export *exp, struct lov_mds_md **lmmp, ...@@ -119,7 +119,7 @@ static int osc_packmd(struct obd_export *exp, struct lov_mds_md **lmmp,
if (*lmmp == NULL) { if (*lmmp == NULL) {
*lmmp = kzalloc(lmm_size, GFP_NOFS); *lmmp = kzalloc(lmm_size, GFP_NOFS);
if (*lmmp == NULL) if (!*lmmp)
return -ENOMEM; return -ENOMEM;
} }
...@@ -1909,7 +1909,7 @@ int osc_build_rpc(const struct lu_env *env, struct client_obd *cli, ...@@ -1909,7 +1909,7 @@ int osc_build_rpc(const struct lu_env *env, struct client_obd *cli,
mpflag = cfs_memory_pressure_get_and_set(); mpflag = cfs_memory_pressure_get_and_set();
crattr = kzalloc(sizeof(*crattr), GFP_NOFS); crattr = kzalloc(sizeof(*crattr), GFP_NOFS);
if (crattr == NULL) { if (!crattr) {
rc = -ENOMEM; rc = -ENOMEM;
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment