Commit 3606a1dc authored by Mathieu Poirier's avatar Mathieu Poirier Committed by Greg Kroah-Hartman

coresight tmc etr: Make memory check consistent in the same function

While operating from sysFS the TMC-ETR driver needs to make sure it has
memory to work with but doesn't allocate memory uselessly either.  Since
the main memory handle for this driver is drvdata::vaddr, use it throughout
function tmc_enable_etr_sink_sysfs() so that things are consistent.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad0dfdfd
...@@ -153,11 +153,11 @@ static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev) ...@@ -153,11 +153,11 @@ static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev)
goto out; goto out;
/* /*
* If drvdata::buf == NULL, use the memory allocated above. * If drvdata::vaddr == NULL, use the memory allocated above.
* Otherwise a buffer still exists from a previous session, so * Otherwise a buffer still exists from a previous session, so
* simply use that. * simply use that.
*/ */
if (drvdata->buf == NULL) { if (drvdata->vaddr == NULL) {
used = true; used = true;
drvdata->vaddr = vaddr; drvdata->vaddr = vaddr;
drvdata->paddr = paddr; drvdata->paddr = paddr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment