Commit 36502d02 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Fix NULL dereference in snd_hda_gen_build_controls()

When no controls are assigned in the parser (e.g. no analog path),
spec->kctls.list is still NULL.  We need to check it before passing to
snd_hda_add_new_ctls().
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9eb413e5
......@@ -2906,9 +2906,11 @@ int snd_hda_gen_build_controls(struct hda_codec *codec)
struct hda_gen_spec *spec = codec->spec;
int err;
err = snd_hda_add_new_ctls(codec, spec->kctls.list);
if (err < 0)
return err;
if (spec->kctls.used) {
err = snd_hda_add_new_ctls(codec, spec->kctls.list);
if (err < 0)
return err;
}
if (spec->multiout.dig_out_nid) {
err = snd_hda_create_dig_out_ctls(codec,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment