Commit 36c53cf0 authored by Quentin Schulz's avatar Quentin Schulz Committed by David S. Miller

net: phy: mscc: read 'vsc8531, edge-slowdown' as an u32

In the DT binding, it is specified nowhere that 'vsc8531,edge-slowdown'
is an u8, even though it's read as an u8 in the driver.

Let's update the driver to take into consideration that the
'vsc8531,edge-slowdown' property is of the default type u32.
Signed-off-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a993e0f5
...@@ -129,7 +129,7 @@ struct vsc8531_private { ...@@ -129,7 +129,7 @@ struct vsc8531_private {
#ifdef CONFIG_OF_MDIO #ifdef CONFIG_OF_MDIO
struct vsc8531_edge_rate_table { struct vsc8531_edge_rate_table {
u32 vddmac; u32 vddmac;
u8 slowdown[8]; u32 slowdown[8];
}; };
static const struct vsc8531_edge_rate_table edge_table[] = { static const struct vsc8531_edge_rate_table edge_table[] = {
...@@ -386,8 +386,7 @@ static void vsc85xx_wol_get(struct phy_device *phydev, ...@@ -386,8 +386,7 @@ static void vsc85xx_wol_get(struct phy_device *phydev,
#ifdef CONFIG_OF_MDIO #ifdef CONFIG_OF_MDIO
static int vsc85xx_edge_rate_magic_get(struct phy_device *phydev) static int vsc85xx_edge_rate_magic_get(struct phy_device *phydev)
{ {
u8 sd; u32 vdd, sd;
u32 vdd;
int rc, i, j; int rc, i, j;
struct device *dev = &phydev->mdio.dev; struct device *dev = &phydev->mdio.dev;
struct device_node *of_node = dev->of_node; struct device_node *of_node = dev->of_node;
...@@ -400,7 +399,7 @@ static int vsc85xx_edge_rate_magic_get(struct phy_device *phydev) ...@@ -400,7 +399,7 @@ static int vsc85xx_edge_rate_magic_get(struct phy_device *phydev)
if (rc != 0) if (rc != 0)
vdd = MSCC_VDDMAC_3300; vdd = MSCC_VDDMAC_3300;
rc = of_property_read_u8(of_node, "vsc8531,edge-slowdown", &sd); rc = of_property_read_u32(of_node, "vsc8531,edge-slowdown", &sd);
if (rc != 0) if (rc != 0)
sd = 0; sd = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment