Commit 37d4f8a6 authored by Bhupesh Sharma's avatar Bhupesh Sharma Committed by David S. Miller

net: qed: Disable SRIOV functionality inside kdump kernel

Since we have kdump kernel(s) running under severe memory constraint
it makes sense to disable the qed SRIOV functionality when running the
kdump kernel as kdump configurations on several distributions don't
support SRIOV targets for saving the vmcore (see [1] for example).

Currently the qed SRIOV functionality ends up consuming memory in
the kdump kernel, when we don't really use the same.

An example log seen in the kdump kernel with the SRIOV functionality
enabled can be seen below (obtained via memstrack tool, see [2]):
 dracut-pre-pivot[676]: ======== Report format module_summary: ========
 dracut-pre-pivot[676]: Module qed using 149.6MB (2394 pages), peak allocation 149.6MB (2394 pages)

This patch disables the SRIOV functionality inside kdump kernel and with
the same applied the memory consumption goes down:
 dracut-pre-pivot[671]: ======== Report format module_summary: ========
 dracut-pre-pivot[671]: Module qed using 124.6MB (1993 pages), peak allocation 124.7MB (1995 pages)

[1]. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/installing-and-configuring-kdump_managing-monitoring-and-updating-the-kernel#supported-kdump-targets_supported-kdump-configurations-and-targets
[2]. Memstrack tool: https://github.com/ryncsn/memstrack

Cc: kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Ariel Elior <aelior@marvell.com>
Cc: GR-everest-linux-l2@marvell.com
Cc: Manish Chopra <manishc@marvell.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarBhupesh Sharma <bhsharma@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 73e03097
...@@ -32,6 +32,7 @@ ...@@ -32,6 +32,7 @@
#ifndef _QED_SRIOV_H #ifndef _QED_SRIOV_H
#define _QED_SRIOV_H #define _QED_SRIOV_H
#include <linux/crash_dump.h>
#include <linux/types.h> #include <linux/types.h>
#include "qed_vf.h" #include "qed_vf.h"
...@@ -40,9 +41,12 @@ ...@@ -40,9 +41,12 @@
#define QED_VF_ARRAY_LENGTH (3) #define QED_VF_ARRAY_LENGTH (3)
#ifdef CONFIG_QED_SRIOV #ifdef CONFIG_QED_SRIOV
#define IS_VF(cdev) ((cdev)->b_is_vf) #define IS_VF(cdev) (is_kdump_kernel() ? \
#define IS_PF(cdev) (!((cdev)->b_is_vf)) (0) : ((cdev)->b_is_vf))
#define IS_PF_SRIOV(p_hwfn) (!!((p_hwfn)->cdev->p_iov_info)) #define IS_PF(cdev) (is_kdump_kernel() ? \
(1) : !((cdev)->b_is_vf))
#define IS_PF_SRIOV(p_hwfn) (is_kdump_kernel() ? \
(0) : !!((p_hwfn)->cdev->p_iov_info))
#else #else
#define IS_VF(cdev) (0) #define IS_VF(cdev) (0)
#define IS_PF(cdev) (1) #define IS_PF(cdev) (1)
......
...@@ -1214,7 +1214,7 @@ static int qede_probe(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -1214,7 +1214,7 @@ static int qede_probe(struct pci_dev *pdev, const struct pci_device_id *id)
case QEDE_PRIVATE_VF: case QEDE_PRIVATE_VF:
if (debug & QED_LOG_VERBOSE_MASK) if (debug & QED_LOG_VERBOSE_MASK)
dev_err(&pdev->dev, "Probing a VF\n"); dev_err(&pdev->dev, "Probing a VF\n");
is_vf = true; is_vf = is_kdump_kernel() ? false : true;
break; break;
default: default:
if (debug & QED_LOG_VERBOSE_MASK) if (debug & QED_LOG_VERBOSE_MASK)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment