Commit 3b524a68 authored by Tony Battersby's avatar Tony Battersby Committed by James Bottomley

sg: fix read() error reporting

Fix SCSI generic read() incorrectly returning success after detecting an
error.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTony Battersby <tonyb@cybernetics.com>
Acked-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 2ecf8e0a
...@@ -546,7 +546,7 @@ static ssize_t ...@@ -546,7 +546,7 @@ static ssize_t
sg_new_read(Sg_fd * sfp, char __user *buf, size_t count, Sg_request * srp) sg_new_read(Sg_fd * sfp, char __user *buf, size_t count, Sg_request * srp)
{ {
sg_io_hdr_t *hp = &srp->header; sg_io_hdr_t *hp = &srp->header;
int err = 0; int err = 0, err2;
int len; int len;
if (count < SZ_SG_IO_HDR) { if (count < SZ_SG_IO_HDR) {
...@@ -575,8 +575,8 @@ sg_new_read(Sg_fd * sfp, char __user *buf, size_t count, Sg_request * srp) ...@@ -575,8 +575,8 @@ sg_new_read(Sg_fd * sfp, char __user *buf, size_t count, Sg_request * srp)
goto err_out; goto err_out;
} }
err_out: err_out:
err = sg_finish_rem_req(srp); err2 = sg_finish_rem_req(srp);
return (0 == err) ? count : err; return err ? : err2 ? : count;
} }
static ssize_t static ssize_t
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment