Commit 479163f4 authored by Al Viro's avatar Al Viro Committed by David S. Miller

mlx5: don't duplicate kvfree()

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Acked-by: default avatarEli Cohen <eli@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c92d418f
...@@ -805,14 +805,14 @@ struct ib_cq *mlx5_ib_create_cq(struct ib_device *ibdev, int entries, ...@@ -805,14 +805,14 @@ struct ib_cq *mlx5_ib_create_cq(struct ib_device *ibdev, int entries,
} }
mlx5_vfree(cqb); kvfree(cqb);
return &cq->ibcq; return &cq->ibcq;
err_cmd: err_cmd:
mlx5_core_destroy_cq(dev->mdev, &cq->mcq); mlx5_core_destroy_cq(dev->mdev, &cq->mcq);
err_cqb: err_cqb:
mlx5_vfree(cqb); kvfree(cqb);
if (context) if (context)
destroy_cq_user(cq, context); destroy_cq_user(cq, context);
else else
...@@ -1159,11 +1159,11 @@ int mlx5_ib_resize_cq(struct ib_cq *ibcq, int entries, struct ib_udata *udata) ...@@ -1159,11 +1159,11 @@ int mlx5_ib_resize_cq(struct ib_cq *ibcq, int entries, struct ib_udata *udata)
} }
mutex_unlock(&cq->resize_mutex); mutex_unlock(&cq->resize_mutex);
mlx5_vfree(in); kvfree(in);
return 0; return 0;
ex_alloc: ex_alloc:
mlx5_vfree(in); kvfree(in);
ex_resize: ex_resize:
if (udata) if (udata)
......
...@@ -853,14 +853,14 @@ static struct mlx5_ib_mr *reg_create(struct ib_pd *pd, u64 virt_addr, ...@@ -853,14 +853,14 @@ static struct mlx5_ib_mr *reg_create(struct ib_pd *pd, u64 virt_addr,
goto err_2; goto err_2;
} }
mr->umem = umem; mr->umem = umem;
mlx5_vfree(in); kvfree(in);
mlx5_ib_dbg(dev, "mkey = 0x%x\n", mr->mmr.key); mlx5_ib_dbg(dev, "mkey = 0x%x\n", mr->mmr.key);
return mr; return mr;
err_2: err_2:
mlx5_vfree(in); kvfree(in);
err_1: err_1:
kfree(mr); kfree(mr);
......
...@@ -647,7 +647,7 @@ static int create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd, ...@@ -647,7 +647,7 @@ static int create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
mlx5_ib_db_unmap_user(context, &qp->db); mlx5_ib_db_unmap_user(context, &qp->db);
err_free: err_free:
mlx5_vfree(*in); kvfree(*in);
err_umem: err_umem:
if (qp->umem) if (qp->umem)
...@@ -761,7 +761,7 @@ static int create_kernel_qp(struct mlx5_ib_dev *dev, ...@@ -761,7 +761,7 @@ static int create_kernel_qp(struct mlx5_ib_dev *dev,
kfree(qp->rq.wrid); kfree(qp->rq.wrid);
err_free: err_free:
mlx5_vfree(*in); kvfree(*in);
err_buf: err_buf:
mlx5_buf_free(dev->mdev, &qp->buf); mlx5_buf_free(dev->mdev, &qp->buf);
...@@ -971,7 +971,7 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, ...@@ -971,7 +971,7 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
goto err_create; goto err_create;
} }
mlx5_vfree(in); kvfree(in);
/* Hardware wants QPN written in big-endian order (after /* Hardware wants QPN written in big-endian order (after
* shifting) for send doorbell. Precompute this value to save * shifting) for send doorbell. Precompute this value to save
* a little bit when posting sends. * a little bit when posting sends.
...@@ -988,7 +988,7 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, ...@@ -988,7 +988,7 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
else if (qp->create_type == MLX5_QP_KERNEL) else if (qp->create_type == MLX5_QP_KERNEL)
destroy_qp_kernel(dev, qp); destroy_qp_kernel(dev, qp);
mlx5_vfree(in); kvfree(in);
return err; return err;
} }
......
...@@ -141,7 +141,7 @@ static int create_srq_user(struct ib_pd *pd, struct mlx5_ib_srq *srq, ...@@ -141,7 +141,7 @@ static int create_srq_user(struct ib_pd *pd, struct mlx5_ib_srq *srq,
return 0; return 0;
err_in: err_in:
mlx5_vfree(*in); kvfree(*in);
err_umem: err_umem:
ib_umem_release(srq->umem); ib_umem_release(srq->umem);
...@@ -209,7 +209,7 @@ static int create_srq_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_srq *srq, ...@@ -209,7 +209,7 @@ static int create_srq_kernel(struct mlx5_ib_dev *dev, struct mlx5_ib_srq *srq,
return 0; return 0;
err_in: err_in:
mlx5_vfree(*in); kvfree(*in);
err_buf: err_buf:
mlx5_buf_free(dev->mdev, &srq->buf); mlx5_buf_free(dev->mdev, &srq->buf);
...@@ -306,7 +306,7 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd, ...@@ -306,7 +306,7 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd,
in->ctx.pd = cpu_to_be32(to_mpd(pd)->pdn); in->ctx.pd = cpu_to_be32(to_mpd(pd)->pdn);
in->ctx.db_record = cpu_to_be64(srq->db.dma); in->ctx.db_record = cpu_to_be64(srq->db.dma);
err = mlx5_core_create_srq(dev->mdev, &srq->msrq, in, inlen); err = mlx5_core_create_srq(dev->mdev, &srq->msrq, in, inlen);
mlx5_vfree(in); kvfree(in);
if (err) { if (err) {
mlx5_ib_dbg(dev, "create SRQ failed, err %d\n", err); mlx5_ib_dbg(dev, "create SRQ failed, err %d\n", err);
goto err_usr_kern_srq; goto err_usr_kern_srq;
......
...@@ -390,7 +390,7 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx, ...@@ -390,7 +390,7 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx,
*/ */
eq_update_ci(eq, 1); eq_update_ci(eq, 1);
mlx5_vfree(in); kvfree(in);
return 0; return 0;
err_irq: err_irq:
...@@ -400,7 +400,7 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx, ...@@ -400,7 +400,7 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx,
mlx5_cmd_destroy_eq(dev, eq->eqn); mlx5_cmd_destroy_eq(dev, eq->eqn);
err_in: err_in:
mlx5_vfree(in); kvfree(in);
err_buf: err_buf:
mlx5_buf_free(dev, &eq->buf); mlx5_buf_free(dev, &eq->buf);
......
...@@ -349,7 +349,7 @@ static int give_pages(struct mlx5_core_dev *dev, u16 func_id, int npages, ...@@ -349,7 +349,7 @@ static int give_pages(struct mlx5_core_dev *dev, u16 func_id, int npages,
for (i--; i >= 0; i--) for (i--; i >= 0; i--)
free_4k(dev, be64_to_cpu(in->pas[i])); free_4k(dev, be64_to_cpu(in->pas[i]));
out_free: out_free:
mlx5_vfree(in); kvfree(in);
return err; return err;
} }
...@@ -400,7 +400,7 @@ static int reclaim_pages(struct mlx5_core_dev *dev, u32 func_id, int npages, ...@@ -400,7 +400,7 @@ static int reclaim_pages(struct mlx5_core_dev *dev, u32 func_id, int npages,
} }
out_free: out_free:
mlx5_vfree(out); kvfree(out);
return err; return err;
} }
......
...@@ -68,9 +68,9 @@ int mlx5_core_access_reg(struct mlx5_core_dev *dev, void *data_in, ...@@ -68,9 +68,9 @@ int mlx5_core_access_reg(struct mlx5_core_dev *dev, void *data_in,
memcpy(data_out, out->data, size_out); memcpy(data_out, out->data, size_out);
ex2: ex2:
mlx5_vfree(out); kvfree(out);
ex1: ex1:
mlx5_vfree(in); kvfree(in);
return err; return err;
} }
EXPORT_SYMBOL_GPL(mlx5_core_access_reg); EXPORT_SYMBOL_GPL(mlx5_core_access_reg);
......
...@@ -633,14 +633,6 @@ static inline void *mlx5_vzalloc(unsigned long size) ...@@ -633,14 +633,6 @@ static inline void *mlx5_vzalloc(unsigned long size)
return rtn; return rtn;
} }
static inline void mlx5_vfree(const void *addr)
{
if (addr && is_vmalloc_addr(addr))
vfree(addr);
else
kfree(addr);
}
static inline u32 mlx5_base_mkey(const u32 key) static inline u32 mlx5_base_mkey(const u32 key)
{ {
return key & 0xffffff00u; return key & 0xffffff00u;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment