Commit 523fc5c1 authored by Tomoki Sekiyama's avatar Tomoki Sekiyama Committed by Greg Kroah-Hartman

USB: yurex: Remove allocation of coherent buffer for setup-packet buffer

Removes allocation of coherent buffer for the control-request setup-packet
buffer from the yurex driver. Using coherent buffers for setup-packet is
obsolete and does not work with some USB host implementations.
Signed-off-by: default avatarTomoki Sekiyama <tomoki.sekiyama@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f4a728d0
...@@ -99,9 +99,7 @@ static void yurex_delete(struct kref *kref) ...@@ -99,9 +99,7 @@ static void yurex_delete(struct kref *kref)
usb_put_dev(dev->udev); usb_put_dev(dev->udev);
if (dev->cntl_urb) { if (dev->cntl_urb) {
usb_kill_urb(dev->cntl_urb); usb_kill_urb(dev->cntl_urb);
if (dev->cntl_req) kfree(dev->cntl_req);
usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
dev->cntl_req, dev->cntl_urb->setup_dma);
if (dev->cntl_buffer) if (dev->cntl_buffer)
usb_free_coherent(dev->udev, YUREX_BUF_SIZE, usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
dev->cntl_buffer, dev->cntl_urb->transfer_dma); dev->cntl_buffer, dev->cntl_urb->transfer_dma);
...@@ -234,9 +232,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_ ...@@ -234,9 +232,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
} }
/* allocate buffer for control req */ /* allocate buffer for control req */
dev->cntl_req = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE, dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);
GFP_KERNEL,
&dev->cntl_urb->setup_dma);
if (!dev->cntl_req) { if (!dev->cntl_req) {
err("Could not allocate cntl_req"); err("Could not allocate cntl_req");
goto error; goto error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment