Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
linux
Commits
5a460275
Commit
5a460275
authored
Apr 17, 2015
by
Al Viro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
namei: expand nested_symlink() in its only caller
Signed-off-by:
Al Viro
<
viro@zeniv.linux.org.uk
>
parent
896475d5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
23 additions
and
38 deletions
+23
-38
fs/namei.c
fs/namei.c
+23
-38
No files found.
fs/namei.c
View file @
5a460275
...
...
@@ -1612,43 +1612,6 @@ static int walk_component(struct nameidata *nd, int follow)
return
err
;
}
/*
* This limits recursive symlink follows to 8, while
* limiting consecutive symlinks to 40.
*
* Without that kind of total limit, nasty chains of consecutive
* symlinks can cause almost arbitrarily long lookups.
*/
static
inline
int
nested_symlink
(
struct
nameidata
*
nd
)
{
int
res
;
if
(
unlikely
(
current
->
link_count
>=
MAX_NESTED_LINKS
))
{
path_put_conditional
(
&
nd
->
link
,
nd
);
path_put
(
&
nd
->
path
);
return
-
ELOOP
;
}
BUG_ON
(
nd
->
depth
>=
MAX_NESTED_LINKS
);
nd
->
depth
++
;
current
->
link_count
++
;
do
{
struct
path
link
=
nd
->
link
;
void
*
cookie
;
res
=
follow_link
(
&
link
,
nd
,
&
cookie
);
if
(
res
)
break
;
res
=
walk_component
(
nd
,
LOOKUP_FOLLOW
);
put_link
(
nd
,
&
link
,
cookie
);
}
while
(
res
>
0
);
current
->
link_count
--
;
nd
->
depth
--
;
return
res
;
}
/*
* We can do the critical dentry name comparison and hashing
* operations one word at a time, but we are limited to:
...
...
@@ -1839,7 +1802,29 @@ static int link_path_walk(const char *name, struct nameidata *nd)
return
err
;
if
(
err
)
{
err
=
nested_symlink
(
nd
);
if
(
unlikely
(
current
->
link_count
>=
MAX_NESTED_LINKS
))
{
path_put_conditional
(
&
nd
->
link
,
nd
);
path_put
(
&
nd
->
path
);
return
-
ELOOP
;
}
BUG_ON
(
nd
->
depth
>=
MAX_NESTED_LINKS
);
nd
->
depth
++
;
current
->
link_count
++
;
do
{
struct
path
link
=
nd
->
link
;
void
*
cookie
;
err
=
follow_link
(
&
link
,
nd
,
&
cookie
);
if
(
err
)
break
;
err
=
walk_component
(
nd
,
LOOKUP_FOLLOW
);
put_link
(
nd
,
&
link
,
cookie
);
}
while
(
err
>
0
);
current
->
link_count
--
;
nd
->
depth
--
;
if
(
err
)
return
err
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment