Commit 603b7bcf authored by Alex Vesker's avatar Alex Vesker Committed by Saeed Mahameed

net/mlx5: Fix incorrect raw command length parsing

The NULL character was not set correctly for the string containing
the command length, this caused failures reading the output of the
command due to a random length. The fix is to initialize the output
length string.

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: default avatarAlex Vesker <valex@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent d14fcb8d
...@@ -1276,7 +1276,7 @@ static ssize_t outlen_write(struct file *filp, const char __user *buf, ...@@ -1276,7 +1276,7 @@ static ssize_t outlen_write(struct file *filp, const char __user *buf,
{ {
struct mlx5_core_dev *dev = filp->private_data; struct mlx5_core_dev *dev = filp->private_data;
struct mlx5_cmd_debug *dbg = &dev->cmd.dbg; struct mlx5_cmd_debug *dbg = &dev->cmd.dbg;
char outlen_str[8]; char outlen_str[8] = {0};
int outlen; int outlen;
void *ptr; void *ptr;
int err; int err;
...@@ -1291,8 +1291,6 @@ static ssize_t outlen_write(struct file *filp, const char __user *buf, ...@@ -1291,8 +1291,6 @@ static ssize_t outlen_write(struct file *filp, const char __user *buf,
if (copy_from_user(outlen_str, buf, count)) if (copy_from_user(outlen_str, buf, count))
return -EFAULT; return -EFAULT;
outlen_str[7] = 0;
err = sscanf(outlen_str, "%d", &outlen); err = sscanf(outlen_str, "%d", &outlen);
if (err < 0) if (err < 0)
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment