Commit 610f01b9 authored by Stafford Horne's avatar Stafford Horne

openrisc: fix possible deadlock scenario during timer sync

OpenRISC borrows its timer sync logic from MIPS, Matt helped to review
the OpenRISC implementation and noted that we may suffer the same
deadlock case that MIPS has faced. The case being:

  "the MIPS timer synchronization code contained the possibility of
  deadlock. If you mark a CPU online before it goes into the synchronize
  loop, then the boot CPU can schedule a different thread and send IPIs to
  all "online" CPUs. It gets stuck waiting for the secondary to ack it's
  IPI, since this secondary CPU has not enabled IRQs yet, and is stuck
  waiting for the master to synchronise with it.  The system then
  deadlocks."

Fix this by moving set_cpu_online() to after timer sync.
Reported-by: default avatarMatt Redfearn <matt.redfearn@mips.com>
Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
parent afa83808
...@@ -127,10 +127,10 @@ asmlinkage __init void secondary_start_kernel(void) ...@@ -127,10 +127,10 @@ asmlinkage __init void secondary_start_kernel(void)
/* /*
* OK, now it's safe to let the boot CPU continue * OK, now it's safe to let the boot CPU continue
*/ */
set_cpu_online(cpu, true);
complete(&cpu_running); complete(&cpu_running);
synchronise_count_slave(cpu); synchronise_count_slave(cpu);
set_cpu_online(cpu, true);
local_irq_enable(); local_irq_enable();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment