Commit 6859e7df authored by Veaceslav Falico's avatar Veaceslav Falico Committed by David S. Miller

netdev: remove potentially harmful checks

Currently we're checking a variable for != NULL after actually
dereferencing it, in netdev_lower_get_next_private*().

It's counter-intuitive at best, and can lead to faulty usage (as it implies
that the variable can be NULL), so fix it by removing the useless checks.
Reported-by: default avatarDaniel Borkmann <dborkman@redhat.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Nicolas Dichtel <nicolas.dichtel@6wind.com>
CC: Jiri Pirko <jiri@resnulli.us>
CC: stephen hemminger <stephen@networkplumber.org>
CC: Jerry Chu <hkchu@google.com>
Signed-off-by: default avatarVeaceslav Falico <vfalico@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f25cd47
...@@ -4589,8 +4589,7 @@ void *netdev_lower_get_next_private(struct net_device *dev, ...@@ -4589,8 +4589,7 @@ void *netdev_lower_get_next_private(struct net_device *dev,
if (&lower->list == &dev->adj_list.lower) if (&lower->list == &dev->adj_list.lower)
return NULL; return NULL;
if (iter) *iter = lower->list.next;
*iter = lower->list.next;
return lower->private; return lower->private;
} }
...@@ -4618,8 +4617,7 @@ void *netdev_lower_get_next_private_rcu(struct net_device *dev, ...@@ -4618,8 +4617,7 @@ void *netdev_lower_get_next_private_rcu(struct net_device *dev,
if (&lower->list == &dev->adj_list.lower) if (&lower->list == &dev->adj_list.lower)
return NULL; return NULL;
if (iter) *iter = &lower->list;
*iter = &lower->list;
return lower->private; return lower->private;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment