Commit 6abe1e2e authored by Shahar S Matityahu's avatar Shahar S Matityahu Committed by Luca Coelho

iwlwifi: dbg_ini: use vzalloc to allocate dumping memory regions

During dump flow, the driver allocates spaces to store the memory
regions that will be included in the dump. These regions can be very
large so in order to avoid allocation failure, use vzalloc instead.
The kmalloc uses GFP_KERNEL and the driver does not make any use of the
fact that the memory is contiguous so the same functionality is
maintained.
Signed-off-by: default avatarShahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 3b445ed9
......@@ -1846,7 +1846,7 @@ static u32 iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt, struct list_head *list,
if (!size)
return 0;
entry = kmalloc(sizeof(*entry) + sizeof(*tlv) + size, GFP_KERNEL);
entry = vzalloc(sizeof(*entry) + sizeof(*tlv) + size);
if (!entry)
return 0;
......@@ -1892,7 +1892,7 @@ static u32 iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt, struct list_head *list,
return entry->size;
out_err:
kfree(entry);
vfree(entry);
return 0;
}
......@@ -1914,7 +1914,7 @@ static u32 iwl_dump_ini_info(struct iwl_fw_runtime *fwrt,
num_of_cfg_names++;
}
entry = kmalloc(sizeof(*entry) + size, GFP_KERNEL);
entry = vzalloc(sizeof(*entry) + size);
if (!entry)
return 0;
......@@ -2121,7 +2121,7 @@ static u32 iwl_dump_ini_file_gen(struct iwl_fw_runtime *fwrt,
!le64_to_cpu(trigger->regions_mask))
return 0;
entry = kmalloc(sizeof(*entry) + sizeof(*hdr), GFP_KERNEL);
entry = vzalloc(sizeof(*entry) + sizeof(*hdr));
if (!entry)
return 0;
......@@ -2129,7 +2129,7 @@ static u32 iwl_dump_ini_file_gen(struct iwl_fw_runtime *fwrt,
size = iwl_dump_ini_trigger(fwrt, dump_data, list);
if (!size) {
kfree(entry);
vfree(entry);
return 0;
}
......@@ -2195,7 +2195,7 @@ static void iwl_dump_ini_list_free(struct list_head *list)
list_entry(list->next, typeof(*entry), list);
list_del(&entry->list);
kfree(entry);
vfree(entry);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment