Commit 6bb04978 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva

scsi: osst: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114983 ("Missing break in switch")
Addresses-Coverity-ID: 114984 ("Missing break in switch")
Addresses-Coverity-ID: 114985 ("Missing break in switch")
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent 88216a78
...@@ -216,12 +216,14 @@ static void osst_analyze_sense(struct osst_request *SRpnt, struct st_cmdstatus * ...@@ -216,12 +216,14 @@ static void osst_analyze_sense(struct osst_request *SRpnt, struct st_cmdstatus *
switch (sense[0] & 0x7f) { switch (sense[0] & 0x7f) {
case 0x71: case 0x71:
s->deferred = 1; s->deferred = 1;
/* fall through */
case 0x70: case 0x70:
s->fixed_format = 1; s->fixed_format = 1;
s->flags = sense[2] & 0xe0; s->flags = sense[2] & 0xe0;
break; break;
case 0x73: case 0x73:
s->deferred = 1; s->deferred = 1;
/* fall through */
case 0x72: case 0x72:
s->fixed_format = 0; s->fixed_format = 0;
ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4);
...@@ -591,6 +593,7 @@ static void osst_init_aux(struct osst_tape * STp, int frame_type, int frame_seq_ ...@@ -591,6 +593,7 @@ static void osst_init_aux(struct osst_tape * STp, int frame_type, int frame_seq_
dat->dat_list[0].flags = frame_type==OS_FRAME_TYPE_MARKER? dat->dat_list[0].flags = frame_type==OS_FRAME_TYPE_MARKER?
OS_DAT_FLAGS_MARK:OS_DAT_FLAGS_DATA; OS_DAT_FLAGS_MARK:OS_DAT_FLAGS_DATA;
dat->dat_list[0].reserved = 0; dat->dat_list[0].reserved = 0;
/* fall through */
case OS_FRAME_TYPE_EOD: case OS_FRAME_TYPE_EOD:
aux->update_frame_cntr = htonl(0); aux->update_frame_cntr = htonl(0);
par->partition_num = OS_DATA_PARTITION; par->partition_num = OS_DATA_PARTITION;
...@@ -4086,6 +4089,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt, ...@@ -4086,6 +4089,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
switch (cmd_in) { switch (cmd_in) {
case MTFSFM: case MTFSFM:
chg_eof = 0; /* Changed from the FSF after this */ chg_eof = 0; /* Changed from the FSF after this */
/* fall through */
case MTFSF: case MTFSF:
if (STp->raw) if (STp->raw)
return (-EIO); return (-EIO);
...@@ -4101,6 +4105,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt, ...@@ -4101,6 +4105,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
case MTBSF: case MTBSF:
chg_eof = 0; /* Changed from the FSF after this */ chg_eof = 0; /* Changed from the FSF after this */
/* fall through */
case MTBSFM: case MTBSFM:
if (STp->raw) if (STp->raw)
return (-EIO); return (-EIO);
...@@ -4312,6 +4317,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt, ...@@ -4312,6 +4317,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
name, STp->block_size); name, STp->block_size);
return 0; return 0;
} }
/* fall through */
case MTSETDENSITY: /* Set tape density */ case MTSETDENSITY: /* Set tape density */
case MTSETDRVBUFFER: /* Set drive buffering */ case MTSETDRVBUFFER: /* Set drive buffering */
case SET_DENS_AND_BLK: /* Set density and block size */ case SET_DENS_AND_BLK: /* Set density and block size */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment