Skip to content

L
linux
Commit 6de1472f authored by Al Viro's avatar Al Viro
Browse files
Options

nfs: use %p[dD] instead of open-coded (and often racy) equivalents 

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 48bc06e7
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 119 additions and 186 deletions
fs/nfs/dir.c
View file @ 6de1472f
This diff is collapsed.
fs/nfs/direct.c
View file @ 6de1472f
...@@ -124,9 +124,8 @@ static inline int put_dreq(struct nfs_direct_req *dreq) ...@@ -124,9 +124,8 @@ static inline int put_dreq(struct nfs_direct_req *dreq)
ssize_t nfs_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, loff_t pos, unsigned long nr_segs) ssize_t nfs_direct_IO(int rw, struct kiocb *iocb, const struct iovec *iov, loff_t pos, unsigned long nr_segs)
{ {
#ifndef CONFIG_NFS_SWAP #ifndef CONFIG_NFS_SWAP
dprintk("NFS: nfs_direct_IO (%s) off/no(%Ld/%lu) EINVAL\n", dprintk("NFS: nfs_direct_IO (%pD) off/no(%Ld/%lu) EINVAL\n",
iocb->ki_filp->f_path.dentry->d_name.name, iocb->ki_filp, (long long) pos, nr_segs);
(long long) pos, nr_segs);
return -EINVAL; return -EINVAL;
#else #else
...@@ -909,10 +908,8 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, const struct iovec *iov, ...@@ -909,10 +908,8 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, const struct iovec *iov,
count = iov_length(iov, nr_segs); count = iov_length(iov, nr_segs);
nfs_add_stats(mapping->host, NFSIOS_DIRECTREADBYTES, count); nfs_add_stats(mapping->host, NFSIOS_DIRECTREADBYTES, count);
dfprintk(FILE, "NFS: direct read(%s/%s, %zd@%Ld)\n", dfprintk(FILE, "NFS: direct read(%pD2, %zd@%Ld)\n",
file->f_path.dentry->d_parent->d_name.name, file, count, (long long) pos);
file->f_path.dentry->d_name.name,
count, (long long) pos);
retval = 0; retval = 0;
if (!count) if (!count)
...@@ -965,10 +962,8 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const struct iovec *iov, ...@@ -965,10 +962,8 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const struct iovec *iov,
count = iov_length(iov, nr_segs); count = iov_length(iov, nr_segs);
nfs_add_stats(mapping->host, NFSIOS_DIRECTWRITTENBYTES, count); nfs_add_stats(mapping->host, NFSIOS_DIRECTWRITTENBYTES, count);
dfprintk(FILE, "NFS: direct write(%s/%s, %zd@%Ld)\n", dfprintk(FILE, "NFS: direct write(%pD2, %zd@%Ld)\n",
file->f_path.dentry->d_parent->d_name.name, file, count, (long long) pos);
file->f_path.dentry->d_name.name,
count, (long long) pos);
retval = generic_write_checks(file, &pos, &count, 0); retval = generic_write_checks(file, &pos, &count, 0);
if (retval) if (retval)
......
fs/nfs/file.c
View file @ 6de1472f
...@@ -65,9 +65,7 @@ nfs_file_open(struct inode *inode, struct file *filp) ...@@ -65,9 +65,7 @@ nfs_file_open(struct inode *inode, struct file *filp)
{ {
int res; int res;
dprintk("NFS: open file(%s/%s)\n", dprintk("NFS: open file(%pD2)\n", filp);
filp->f_path.dentry->d_parent->d_name.name,
filp->f_path.dentry->d_name.name);
nfs_inc_stats(inode, NFSIOS_VFSOPEN); nfs_inc_stats(inode, NFSIOS_VFSOPEN);
res = nfs_check_flags(filp->f_flags); res = nfs_check_flags(filp->f_flags);
...@@ -81,9 +79,7 @@ nfs_file_open(struct inode *inode, struct file *filp) ...@@ -81,9 +79,7 @@ nfs_file_open(struct inode *inode, struct file *filp)
int int
nfs_file_release(struct inode *inode, struct file *filp) nfs_file_release(struct inode *inode, struct file *filp)
{ {
dprintk("NFS: release(%s/%s)\n", dprintk("NFS: release(%pD2)\n", filp);
filp->f_path.dentry->d_parent->d_name.name,
filp->f_path.dentry->d_name.name);
nfs_inc_stats(inode, NFSIOS_VFSRELEASE); nfs_inc_stats(inode, NFSIOS_VFSRELEASE);
return nfs_release(inode, filp); return nfs_release(inode, filp);
...@@ -123,10 +119,8 @@ static int nfs_revalidate_file_size(struct inode *inode, struct file *filp) ...@@ -123,10 +119,8 @@ static int nfs_revalidate_file_size(struct inode *inode, struct file *filp)
loff_t nfs_file_llseek(struct file *filp, loff_t offset, int whence) loff_t nfs_file_llseek(struct file *filp, loff_t offset, int whence)
{ {
dprintk("NFS: llseek file(%s/%s, %lld, %d)\n", dprintk("NFS: llseek file(%pD2, %lld, %d)\n",
filp->f_path.dentry->d_parent->d_name.name, filp, offset, whence);
filp->f_path.dentry->d_name.name,
offset, whence);
/* /*
* whence == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate * whence == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate
...@@ -150,12 +144,9 @@ EXPORT_SYMBOL_GPL(nfs_file_llseek); ...@@ -150,12 +144,9 @@ EXPORT_SYMBOL_GPL(nfs_file_llseek);
int int
nfs_file_flush(struct file *file, fl_owner_t id) nfs_file_flush(struct file *file, fl_owner_t id)
{ {
struct dentry *dentry = file->f_path.dentry; struct inode *inode = file_inode(file);
struct inode *inode = dentry->d_inode;
dprintk("NFS: flush(%s/%s)\n", dprintk("NFS: flush(%pD2)\n", file);
dentry->d_parent->d_name.name,
dentry->d_name.name);
nfs_inc_stats(inode, NFSIOS_VFSFLUSH); nfs_inc_stats(inode, NFSIOS_VFSFLUSH);
if ((file->f_mode & FMODE_WRITE) == 0) if ((file->f_mode & FMODE_WRITE) == 0)
...@@ -177,15 +168,14 @@ ssize_t ...@@ -177,15 +168,14 @@ ssize_t
nfs_file_read(struct kiocb *iocb, const struct iovec *iov, nfs_file_read(struct kiocb *iocb, const struct iovec *iov,
unsigned long nr_segs, loff_t pos) unsigned long nr_segs, loff_t pos)
{ {
struct dentry * dentry = iocb->ki_filp->f_path.dentry; struct inode *inode = file_inode(iocb->ki_filp);
struct inode * inode = dentry->d_inode;
ssize_t result; ssize_t result;
if (iocb->ki_filp->f_flags & O_DIRECT) if (iocb->ki_filp->f_flags & O_DIRECT)
return nfs_file_direct_read(iocb, iov, nr_segs, pos, true); return nfs_file_direct_read(iocb, iov, nr_segs, pos, true);
dprintk("NFS: read(%s/%s, %lu@%lu)\n", dprintk("NFS: read(%pD2, %lu@%lu)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, iocb->ki_filp,
(unsigned long) iov_length(iov, nr_segs), (unsigned long) pos); (unsigned long) iov_length(iov, nr_segs), (unsigned long) pos);
result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping);
...@@ -203,13 +193,11 @@ nfs_file_splice_read(struct file *filp, loff_t *ppos, ...@@ -203,13 +193,11 @@ nfs_file_splice_read(struct file *filp, loff_t *ppos,
struct pipe_inode_info *pipe, size_t count, struct pipe_inode_info *pipe, size_t count,
unsigned int flags) unsigned int flags)
{ {
struct dentry *dentry = filp->f_path.dentry; struct inode *inode = file_inode(filp);
struct inode *inode = dentry->d_inode;
ssize_t res; ssize_t res;
dprintk("NFS: splice_read(%s/%s, %lu@%Lu)\n", dprintk("NFS: splice_read(%pD2, %lu@%Lu)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, filp, (unsigned long) count, (unsigned long long) *ppos);
(unsigned long) count, (unsigned long long) *ppos);
res = nfs_revalidate_mapping(inode, filp->f_mapping); res = nfs_revalidate_mapping(inode, filp->f_mapping);
if (!res) { if (!res) {
...@@ -224,12 +212,10 @@ EXPORT_SYMBOL_GPL(nfs_file_splice_read); ...@@ -224,12 +212,10 @@ EXPORT_SYMBOL_GPL(nfs_file_splice_read);
int int
nfs_file_mmap(struct file * file, struct vm_area_struct * vma) nfs_file_mmap(struct file * file, struct vm_area_struct * vma)
{ {
struct dentry *dentry = file->f_path.dentry; struct inode *inode = file_inode(file);
struct inode *inode = dentry->d_inode;
int status; int status;
dprintk("NFS: mmap(%s/%s)\n", dprintk("NFS: mmap(%pD2)\n", file);
dentry->d_parent->d_name.name, dentry->d_name.name);
/* Note: generic_file_mmap() returns ENOSYS on nommu systems /* Note: generic_file_mmap() returns ENOSYS on nommu systems
* so we call that before revalidating the mapping * so we call that before revalidating the mapping
...@@ -258,15 +244,12 @@ EXPORT_SYMBOL_GPL(nfs_file_mmap); ...@@ -258,15 +244,12 @@ EXPORT_SYMBOL_GPL(nfs_file_mmap);
int int
nfs_file_fsync_commit(struct file *file, loff_t start, loff_t end, int datasync) nfs_file_fsync_commit(struct file *file, loff_t start, loff_t end, int datasync)
{ {
struct dentry *dentry = file->f_path.dentry;
struct nfs_open_context *ctx = nfs_file_open_context(file); struct nfs_open_context *ctx = nfs_file_open_context(file);
struct inode *inode = dentry->d_inode; struct inode *inode = file_inode(file);
int have_error, do_resend, status; int have_error, do_resend, status;
int ret = 0; int ret = 0;
dprintk("NFS: fsync file(%s/%s) datasync %d\n", dprintk("NFS: fsync file(%pD2) datasync %d\n", file, datasync);
dentry->d_parent->d_name.name, dentry->d_name.name,
datasync);
nfs_inc_stats(inode, NFSIOS_VFSFSYNC); nfs_inc_stats(inode, NFSIOS_VFSFSYNC);
do_resend = test_and_clear_bit(NFS_CONTEXT_RESEND_WRITES, &ctx->flags); do_resend = test_and_clear_bit(NFS_CONTEXT_RESEND_WRITES, &ctx->flags);
...@@ -371,10 +354,8 @@ static int nfs_write_begin(struct file *file, struct address_space *mapping, ...@@ -371,10 +354,8 @@ static int nfs_write_begin(struct file *file, struct address_space *mapping,
struct page *page; struct page *page;
int once_thru = 0; int once_thru = 0;
dfprintk(PAGECACHE, "NFS: write_begin(%s/%s(%ld), %u@%lld)\n", dfprintk(PAGECACHE, "NFS: write_begin(%pD2(%ld), %u@%lld)\n",
file->f_path.dentry->d_parent->d_name.name, file, mapping->host->i_ino, len, (long long) pos);
file->f_path.dentry->d_name.name,
mapping->host->i_ino, len, (long long) pos);
start: start:
/* /*
...@@ -414,10 +395,8 @@ static int nfs_write_end(struct file *file, struct address_space *mapping, ...@@ -414,10 +395,8 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
struct nfs_open_context *ctx = nfs_file_open_context(file); struct nfs_open_context *ctx = nfs_file_open_context(file);
int status; int status;
dfprintk(PAGECACHE, "NFS: write_end(%s/%s(%ld), %u@%lld)\n", dfprintk(PAGECACHE, "NFS: write_end(%pD2(%ld), %u@%lld)\n",
file->f_path.dentry->d_parent->d_name.name, file, mapping->host->i_ino, len, (long long) pos);
file->f_path.dentry->d_name.name,
mapping->host->i_ino, len, (long long) pos);
/* /*
* Zero any uninitialised parts of the page, and then mark the page * Zero any uninitialised parts of the page, and then mark the page
...@@ -601,22 +580,21 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) ...@@ -601,22 +580,21 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
{ {
struct page *page = vmf->page; struct page *page = vmf->page;
struct file *filp = vma->vm_file; struct file *filp = vma->vm_file;
struct dentry *dentry = filp->f_path.dentry; struct inode *inode = file_inode(filp);
unsigned pagelen; unsigned pagelen;
int ret = VM_FAULT_NOPAGE; int ret = VM_FAULT_NOPAGE;
struct address_space *mapping; struct address_space *mapping;
dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%s/%s(%ld), offset %lld)\n", dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%ld), offset %lld)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, filp, filp->f_mapping->host->i_ino,
filp->f_mapping->host->i_ino,
(long long)page_offset(page)); (long long)page_offset(page));
/* make sure the cache has finished storing the page */ /* make sure the cache has finished storing the page */
nfs_fscache_wait_on_page_write(NFS_I(dentry->d_inode), page); nfs_fscache_wait_on_page_write(NFS_I(inode), page);
lock_page(page); lock_page(page);
mapping = page_file_mapping(page); mapping = page_file_mapping(page);
if (mapping != dentry->d_inode->i_mapping) if (mapping != inode->i_mapping)
goto out_unlock; goto out_unlock;
wait_on_page_writeback(page); wait_on_page_writeback(page);
...@@ -659,22 +637,21 @@ static int nfs_need_sync_write(struct file *filp, struct inode *inode) ...@@ -659,22 +637,21 @@ static int nfs_need_sync_write(struct file *filp, struct inode *inode)
ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov,
unsigned long nr_segs, loff_t pos) unsigned long nr_segs, loff_t pos)
{ {
struct dentry * dentry = iocb->ki_filp->f_path.dentry; struct file *file = iocb->ki_filp;
struct inode * inode = dentry->d_inode; struct inode *inode = file_inode(file);
unsigned long written = 0; unsigned long written = 0;
ssize_t result; ssize_t result;
size_t count = iov_length(iov, nr_segs); size_t count = iov_length(iov, nr_segs);
result = nfs_key_timeout_notify(iocb->ki_filp, inode); result = nfs_key_timeout_notify(file, inode);
if (result) if (result)
return result; return result;
if (iocb->ki_filp->f_flags & O_DIRECT) if (file->f_flags & O_DIRECT)
return nfs_file_direct_write(iocb, iov, nr_segs, pos, true); return nfs_file_direct_write(iocb, iov, nr_segs, pos, true);
dprintk("NFS: write(%s/%s, %lu@%Ld)\n", dprintk("NFS: write(%pD2, %lu@%Ld)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, file, (unsigned long) count, (long long) pos);
(unsigned long) count, (long long) pos);
result = -EBUSY; result = -EBUSY;
if (IS_SWAPFILE(inode)) if (IS_SWAPFILE(inode))
...@@ -682,8 +659,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, ...@@ -682,8 +659,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov,
/* /*
* O_APPEND implies that we must revalidate the file length. * O_APPEND implies that we must revalidate the file length.
*/ */
if (iocb->ki_filp->f_flags & O_APPEND) { if (file->f_flags & O_APPEND) {
result = nfs_revalidate_file_size(inode, iocb->ki_filp); result = nfs_revalidate_file_size(inode, file);
if (result) if (result)
goto out; goto out;
} }
...@@ -697,8 +674,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, ...@@ -697,8 +674,8 @@ ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov,
written = result; written = result;
/* Return error values for O_DSYNC and IS_SYNC() */ /* Return error values for O_DSYNC and IS_SYNC() */
if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { if (result >= 0 && nfs_need_sync_write(file, inode)) {
int err = vfs_fsync(iocb->ki_filp, 0); int err = vfs_fsync(file, 0);
if (err < 0) if (err < 0)
result = err; result = err;
} }
...@@ -717,14 +694,12 @@ ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe, ...@@ -717,14 +694,12 @@ ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe,
struct file *filp, loff_t *ppos, struct file *filp, loff_t *ppos,
size_t count, unsigned int flags) size_t count, unsigned int flags)
{ {
struct dentry *dentry = filp->f_path.dentry; struct inode *inode = file_inode(filp);
struct inode *inode = dentry->d_inode;
unsigned long written = 0; unsigned long written = 0;
ssize_t ret; ssize_t ret;
dprintk("NFS splice_write(%s/%s, %lu@%llu)\n", dprintk("NFS splice_write(%pD2, %lu@%llu)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, filp, (unsigned long) count, (unsigned long long) *ppos);
(unsigned long) count, (unsigned long long) *ppos);
/* /*
* The combination of splice and an O_APPEND destination is disallowed. * The combination of splice and an O_APPEND destination is disallowed.
...@@ -883,10 +858,8 @@ int nfs_lock(struct file *filp, int cmd, struct file_lock *fl) ...@@ -883,10 +858,8 @@ int nfs_lock(struct file *filp, int cmd, struct file_lock *fl)
int ret = -ENOLCK; int ret = -ENOLCK;
int is_local = 0; int is_local = 0;
dprintk("NFS: lock(%s/%s, t=%x, fl=%x, r=%lld:%lld)\n", dprintk("NFS: lock(%pD2, t=%x, fl=%x, r=%lld:%lld)\n",
filp->f_path.dentry->d_parent->d_name.name, filp, fl->fl_type, fl->fl_flags,
filp->f_path.dentry->d_name.name,
fl->fl_type, fl->fl_flags,
(long long)fl->fl_start, (long long)fl->fl_end); (long long)fl->fl_start, (long long)fl->fl_end);
nfs_inc_stats(inode, NFSIOS_VFSLOCK); nfs_inc_stats(inode, NFSIOS_VFSLOCK);
...@@ -923,10 +896,8 @@ int nfs_flock(struct file *filp, int cmd, struct file_lock *fl) ...@@ -923,10 +896,8 @@ int nfs_flock(struct file *filp, int cmd, struct file_lock *fl)
struct inode *inode = filp->f_mapping->host; struct inode *inode = filp->f_mapping->host;
int is_local = 0; int is_local = 0;
dprintk("NFS: flock(%s/%s, t=%x, fl=%x)\n", dprintk("NFS: flock(%pD2, t=%x, fl=%x)\n",
filp->f_path.dentry->d_parent->d_name.name, filp, fl->fl_type, fl->fl_flags);
filp->f_path.dentry->d_name.name,
fl->fl_type, fl->fl_flags);
if (!(fl->fl_flags & FL_FLOCK)) if (!(fl->fl_flags & FL_FLOCK))
return -ENOLCK; return -ENOLCK;
...@@ -960,9 +931,7 @@ EXPORT_SYMBOL_GPL(nfs_flock); ...@@ -960,9 +931,7 @@ EXPORT_SYMBOL_GPL(nfs_flock);
*/ */
int nfs_setlease(struct file *file, long arg, struct file_lock **fl) int nfs_setlease(struct file *file, long arg, struct file_lock **fl)
{ {
dprintk("NFS: setlease(%s/%s, arg=%ld)\n", dprintk("NFS: setlease(%pD2, arg=%ld)\n", file, arg);
file->f_path.dentry->d_parent->d_name.name,
file->f_path.dentry->d_name.name, arg);
return -EINVAL; return -EINVAL;
} }
EXPORT_SYMBOL_GPL(nfs_setlease); EXPORT_SYMBOL_GPL(nfs_setlease);
......
fs/nfs/namespace.c
View file @ 6de1472f
...@@ -253,9 +253,8 @@ struct vfsmount *nfs_do_submount(struct dentry *dentry, struct nfs_fh *fh, ...@@ -253,9 +253,8 @@ struct vfsmount *nfs_do_submount(struct dentry *dentry, struct nfs_fh *fh,
dprintk("--> nfs_do_submount()\n"); dprintk("--> nfs_do_submount()\n");
dprintk("%s: submounting on %s/%s\n", __func__, dprintk("%s: submounting on %pd2\n", __func__,
dentry->d_parent->d_name.name, dentry);
dentry->d_name.name);
if (page == NULL) if (page == NULL)
goto out; goto out;
devname = nfs_devname(dentry, page, PAGE_SIZE); devname = nfs_devname(dentry, page, PAGE_SIZE);
......
fs/nfs/nfs3proc.c
View file @ 6de1472f
...@@ -321,7 +321,7 @@ nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, ...@@ -321,7 +321,7 @@ nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr,
umode_t mode = sattr->ia_mode; umode_t mode = sattr->ia_mode;
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call create %s\n", dentry->d_name.name); dprintk("NFS call create %pd\n", dentry);
data = nfs3_alloc_createdata(); data = nfs3_alloc_createdata();
if (data == NULL) if (data == NULL)
...@@ -548,7 +548,7 @@ nfs3_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, ...@@ -548,7 +548,7 @@ nfs3_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page,
if (len > NFS3_MAXPATHLEN) if (len > NFS3_MAXPATHLEN)
return -ENAMETOOLONG; return -ENAMETOOLONG;
dprintk("NFS call symlink %s\n", dentry->d_name.name); dprintk("NFS call symlink %pd\n", dentry);
data = nfs3_alloc_createdata(); data = nfs3_alloc_createdata();
if (data == NULL) if (data == NULL)
...@@ -576,7 +576,7 @@ nfs3_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr) ...@@ -576,7 +576,7 @@ nfs3_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr)
umode_t mode = sattr->ia_mode; umode_t mode = sattr->ia_mode;
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call mkdir %s\n", dentry->d_name.name); dprintk("NFS call mkdir %pd\n", dentry);
sattr->ia_mode &= ~current_umask(); sattr->ia_mode &= ~current_umask();
...@@ -695,7 +695,7 @@ nfs3_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr, ...@@ -695,7 +695,7 @@ nfs3_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr,
umode_t mode = sattr->ia_mode; umode_t mode = sattr->ia_mode;
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call mknod %s %u:%u\n", dentry->d_name.name, dprintk("NFS call mknod %pd %u:%u\n", dentry,
MAJOR(rdev), MINOR(rdev)); MAJOR(rdev), MINOR(rdev));
sattr->ia_mode &= ~current_umask(); sattr->ia_mode &= ~current_umask();
......
fs/nfs/nfs4file.c
View file @ 6de1472f
...@@ -31,9 +31,7 @@ nfs4_file_open(struct inode *inode, struct file *filp) ...@@ -31,9 +31,7 @@ nfs4_file_open(struct inode *inode, struct file *filp)
* -EOPENSTALE. The VFS will retry the lookup/create/open. * -EOPENSTALE. The VFS will retry the lookup/create/open.
*/ */
dprintk("NFS: open file(%s/%s)\n", dprintk("NFS: open file(%pd2)\n", dentry);
dentry->d_parent->d_name.name,
dentry->d_name.name);
if ((openflags & O_ACCMODE) == 3) if ((openflags & O_ACCMODE) == 3)
openflags--; openflags--;
......
fs/nfs/nfs4namespace.c
View file @ 6de1472f
...@@ -283,8 +283,7 @@ static struct vfsmount *nfs_follow_referral(struct dentry *dentry, ...@@ -283,8 +283,7 @@ static struct vfsmount *nfs_follow_referral(struct dentry *dentry,
if (locations == NULL || locations->nlocations <= 0) if (locations == NULL || locations->nlocations <= 0)
goto out; goto out;
dprintk("%s: referral at %s/%s\n", __func__, dprintk("%s: referral at %pd2\n", __func__, dentry);
dentry->d_parent->d_name.name, dentry->d_name.name);
page = (char *) __get_free_page(GFP_USER); page = (char *) __get_free_page(GFP_USER);
if (!page) if (!page)
...@@ -348,8 +347,8 @@ static struct vfsmount *nfs_do_refmount(struct rpc_clnt *client, struct dentry * ...@@ -348,8 +347,8 @@ static struct vfsmount *nfs_do_refmount(struct rpc_clnt *client, struct dentry *
mnt = ERR_PTR(-ENOENT); mnt = ERR_PTR(-ENOENT);
parent = dget_parent(dentry); parent = dget_parent(dentry);
dprintk("%s: getting locations for %s/%s\n", dprintk("%s: getting locations for %pd2\n",
__func__, parent->d_name.name, dentry->d_name.name); __func__, dentry);
err = nfs4_proc_fs_locations(client, parent->d_inode, &dentry->d_name, fs_locations, page); err = nfs4_proc_fs_locations(client, parent->d_inode, &dentry->d_name, fs_locations, page);
dput(parent); dput(parent);
......
fs/nfs/nfs4proc.c
View file @ 6de1472f
...@@ -3738,9 +3738,8 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred, ...@@ -3738,9 +3738,8 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred,
}; };
int status; int status;
dprintk("%s: dentry = %s/%s, cookie = %Lu\n", __func__, dprintk("%s: dentry = %pd2, cookie = %Lu\n", __func__,
dentry->d_parent->d_name.name, dentry,
dentry->d_name.name,
(unsigned long long)cookie); (unsigned long long)cookie);
nfs4_setup_readdir(cookie, NFS_I(dir)->cookieverf, dentry, &args); nfs4_setup_readdir(cookie, NFS_I(dir)->cookieverf, dentry, &args);
res.pgbase = args.pgbase; res.pgbase = args.pgbase;
......
fs/nfs/proc.c
View file @ 6de1472f
...@@ -235,7 +235,7 @@ nfs_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, ...@@ -235,7 +235,7 @@ nfs_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr,
}; };
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call create %s\n", dentry->d_name.name); dprintk("NFS call create %pd\n", dentry);
data = nfs_alloc_createdata(dir, dentry, sattr); data = nfs_alloc_createdata(dir, dentry, sattr);
if (data == NULL) if (data == NULL)
goto out; goto out;
...@@ -265,7 +265,7 @@ nfs_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr, ...@@ -265,7 +265,7 @@ nfs_proc_mknod(struct inode *dir, struct dentry *dentry, struct iattr *sattr,
umode_t mode; umode_t mode;
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call mknod %s\n", dentry->d_name.name); dprintk("NFS call mknod %pd\n", dentry);
mode = sattr->ia_mode; mode = sattr->ia_mode;
if (S_ISFIFO(mode)) { if (S_ISFIFO(mode)) {
...@@ -423,7 +423,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, ...@@ -423,7 +423,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page,
}; };
int status = -ENAMETOOLONG; int status = -ENAMETOOLONG;
dprintk("NFS call symlink %s\n", dentry->d_name.name); dprintk("NFS call symlink %pd\n", dentry);
if (len > NFS2_MAXPATHLEN) if (len > NFS2_MAXPATHLEN)
goto out; goto out;
...@@ -462,7 +462,7 @@ nfs_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr) ...@@ -462,7 +462,7 @@ nfs_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr *sattr)
}; };
int status = -ENOMEM; int status = -ENOMEM;
dprintk("NFS call mkdir %s\n", dentry->d_name.name); dprintk("NFS call mkdir %pd\n", dentry);
data = nfs_alloc_createdata(dir, dentry, sattr); data = nfs_alloc_createdata(dir, dentry, sattr);
if (data == NULL) if (data == NULL)
goto out; goto out;
......
fs/nfs/unlink.c
View file @ 6de1472f
...@@ -495,9 +495,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry) ...@@ -495,9 +495,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry)
struct rpc_task *task; struct rpc_task *task;
int error = -EIO; int error = -EIO;
dfprintk(VFS, "NFS: silly-rename(%s/%s, ct=%d)\n", dfprintk(VFS, "NFS: silly-rename(%pd2, ct=%d)\n",
dentry->d_parent->d_name.name, dentry->d_name.name, dentry, d_count(dentry));
d_count(dentry));
nfs_inc_stats(dir, NFSIOS_SILLYRENAME); nfs_inc_stats(dir, NFSIOS_SILLYRENAME);
/* /*
...@@ -522,8 +521,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry) ...@@ -522,8 +521,8 @@ nfs_sillyrename(struct inode *dir, struct dentry *dentry)
SILLYNAME_FILEID_LEN, fileid, SILLYNAME_FILEID_LEN, fileid,
SILLYNAME_COUNTER_LEN, sillycounter); SILLYNAME_COUNTER_LEN, sillycounter);
dfprintk(VFS, "NFS: trying to rename %s to %s\n", dfprintk(VFS, "NFS: trying to rename %pd to %s\n",
dentry->d_name.name, silly); dentry, silly);
sdentry = lookup_one_len(silly, dentry->d_parent, slen); sdentry = lookup_one_len(silly, dentry->d_parent, slen);
/* /*
......
fs/nfs/write.c
View file @ 6de1472f
...@@ -954,10 +954,8 @@ int nfs_updatepage(struct file *file, struct page *page, ...@@ -954,10 +954,8 @@ int nfs_updatepage(struct file *file, struct page *page,
nfs_inc_stats(inode, NFSIOS_VFSUPDATEPAGE); nfs_inc_stats(inode, NFSIOS_VFSUPDATEPAGE);
dprintk("NFS: nfs_updatepage(%s/%s %d@%lld)\n", dprintk("NFS: nfs_updatepage(%pD2 %d@%lld)\n",
file->f_path.dentry->d_parent->d_name.name, file, count, (long long)(page_file_offset(page) + offset));
file->f_path.dentry->d_name.name, count,
(long long)(page_file_offset(page) + offset));
if (nfs_can_extend_write(file, page, inode)) { if (nfs_can_extend_write(file, page, inode)) {
count = max(count + offset, nfs_page_length(page)); count = max(count + offset, nfs_page_length(page));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7