Commit 761e9f4f authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij

drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

The of_drm_find_bridge() function returns NULL on error, it doesn't return
error pointers so this check doesn't work.

Fixes: 5fc537bf ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200430073145.52321-1-weiyongjun1@huawei.com
parent 81a15b9a
...@@ -1073,10 +1073,9 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, ...@@ -1073,10 +1073,9 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
panel = NULL; panel = NULL;
bridge = of_drm_find_bridge(child); bridge = of_drm_find_bridge(child);
if (IS_ERR(bridge)) { if (!bridge) {
dev_err(dev, "failed to find bridge (%ld)\n", dev_err(dev, "failed to find bridge\n");
PTR_ERR(bridge)); return -EINVAL;
return PTR_ERR(bridge);
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment