Commit 81bd0d56 authored by Roman Kubiak's avatar Roman Kubiak Committed by Casey Schaufler

Smack: type confusion in smak sendmsg() handler

Smack security handler for sendmsg() syscall
is vulnerable to type confusion issue what
can allow to privilege escalation into root
or cause denial of service.

A malicious attacker can create socket of one
type for example AF_UNIX and pass is into
sendmsg() function ensuring that this is
AF_INET socket.

Remedy
Do not trust user supplied data.
Proposed fix below.
Signed-off-by: default avatarRoman Kubiak <r.kubiak@samsung.com>
Signed-off-by: default avatarMateusz Fruba <m.fruba@samsung.com>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 79be0935
......@@ -3780,7 +3780,7 @@ static int smack_socket_sendmsg(struct socket *sock, struct msghdr *msg,
if (sip == NULL)
return 0;
switch (sip->sin_family) {
switch (sock->sk->sk_family) {
case AF_INET:
rc = smack_netlabel_send(sock->sk, sip);
break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment