Commit 88216a78 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva

scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with
"fall through" annotations, which is what GCC is expecting to find.
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent 309cf28a
...@@ -1137,7 +1137,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1137,7 +1137,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
break; break;
} }
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
* For WRITE_INSERT, force the error * For WRITE_INSERT, force the error
...@@ -1256,7 +1256,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1256,7 +1256,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
rc = BG_ERR_TGT | BG_ERR_CHECK; rc = BG_ERR_TGT | BG_ERR_CHECK;
break; break;
} }
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
* For WRITE_INSERT, force the * For WRITE_INSERT, force the
...@@ -1338,7 +1338,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc, ...@@ -1338,7 +1338,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
switch (op) { switch (op) {
case SCSI_PROT_WRITE_PASS: case SCSI_PROT_WRITE_PASS:
rc = BG_ERR_CHECK; rc = BG_ERR_CHECK;
/* Drop thru */ /* fall through */
case SCSI_PROT_WRITE_INSERT: case SCSI_PROT_WRITE_INSERT:
/* /*
...@@ -3822,7 +3822,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, ...@@ -3822,7 +3822,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
lpfc_cmd->cur_iocbq.sli4_lxritag, lpfc_cmd->cur_iocbq.sli4_lxritag,
0, 0); 0, 0);
} }
/* else: fall through */ /* fall through */
default: default:
cmd->result = DID_ERROR << 16; cmd->result = DID_ERROR << 16;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment