Commit 8906a822 authored by Eric Biggers's avatar Eric Biggers Committed by Theodore Ts'o

fscrypto: lock inode while setting encryption policy

i_rwsem needs to be acquired while setting an encryption policy so that
concurrent calls to FS_IOC_SET_ENCRYPTION_POLICY are correctly
serialized (especially the ->get_context() + ->set_context() pair), and
so that new files cannot be created in the directory during or after the
->empty_dir() check.
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarRichard Weinberger <richard@nod.at>
Cc: stable@vger.kernel.org
parent 19962509
...@@ -109,6 +109,8 @@ int fscrypt_process_policy(struct file *filp, ...@@ -109,6 +109,8 @@ int fscrypt_process_policy(struct file *filp,
if (ret) if (ret)
return ret; return ret;
inode_lock(inode);
if (!inode_has_encryption_context(inode)) { if (!inode_has_encryption_context(inode)) {
if (!S_ISDIR(inode->i_mode)) if (!S_ISDIR(inode->i_mode))
ret = -EINVAL; ret = -EINVAL;
...@@ -127,6 +129,8 @@ int fscrypt_process_policy(struct file *filp, ...@@ -127,6 +129,8 @@ int fscrypt_process_policy(struct file *filp,
ret = -EINVAL; ret = -EINVAL;
} }
inode_unlock(inode);
mnt_drop_write_file(filp); mnt_drop_write_file(filp);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment