Commit 906cf29c authored by Colin Ian King's avatar Colin Ian King Committed by Bjorn Andersson

rpmsg: glink: fix null pointer dereference on a null intent

In the case where glink->intentless is true and the call
to qcom_glink_tx fails then we have a condition where ret is
non-zero and intent is null, causing a null pointer deference
when setting intent->in_use to false.  Add an extra check to
only dereference intent if intent is non-null.

Detected by: CoverityScan CID#1455247 ("Explicit null dereferenced")

Fixes: 88c6060f ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 2b41d6c8
...@@ -1264,7 +1264,7 @@ static int __qcom_glink_send(struct glink_channel *channel, ...@@ -1264,7 +1264,7 @@ static int __qcom_glink_send(struct glink_channel *channel,
ret = qcom_glink_tx(glink, &req, sizeof(req), data, len, wait); ret = qcom_glink_tx(glink, &req, sizeof(req), data, len, wait);
/* Mark intent available if we failed */ /* Mark intent available if we failed */
if (ret) if (ret && intent)
intent->in_use = false; intent->in_use = false;
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment