Commit 93ed2490 authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart

platform/x86: intel-hid: simplify enabling/disabling HID events

ACPI method HDSM takes a single integer argument.  Use
acpi_execute_simple_method() instead of acpi_evaluate_object() for
calling that ACPI method to simplify code and reduce the number of local
variables inside intel_hid_set_enable().
Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-and-tested-by: default avatarAlex Hung <alex.hung@canonical.com>
parent ae50dfd6
...@@ -79,12 +79,10 @@ struct intel_hid_priv { ...@@ -79,12 +79,10 @@ struct intel_hid_priv {
static int intel_hid_set_enable(struct device *device, int enable) static int intel_hid_set_enable(struct device *device, int enable)
{ {
union acpi_object arg0 = { ACPI_TYPE_INTEGER };
struct acpi_object_list args = { 1, &arg0 };
acpi_status status; acpi_status status;
arg0.integer.value = enable; status = acpi_execute_simple_method(ACPI_HANDLE(device), "HDSM",
status = acpi_evaluate_object(ACPI_HANDLE(device), "HDSM", &args, NULL); enable);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
dev_warn(device, "failed to %sable hotkeys\n", dev_warn(device, "failed to %sable hotkeys\n",
enable ? "en" : "dis"); enable ? "en" : "dis");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment