Commit a5b4860b authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
  IB/ehca: Support small QP queues
  IB/ehca: Make internal_create/destroy_qp() static
  IB/ehca: Move ehca2ib_return_code() out of line
  IB/ehca: Generate async event when SRQ limit reached
  IB/ehca: Support large page MRs
  IB/mlx4: Fix error path in create_qp_common()
  mlx4_core: Change command token on timeout
  IB/mthca: Change command token on timeout
  IB/ipath: Remove ipath_layer dead code
  IB/mlx4: Fix leaks in __mlx4_ib_modify_qp
parents e9ed7e72 e2f81daf
...@@ -43,7 +43,6 @@ ...@@ -43,7 +43,6 @@
#ifndef __EHCA_CLASSES_H__ #ifndef __EHCA_CLASSES_H__
#define __EHCA_CLASSES_H__ #define __EHCA_CLASSES_H__
struct ehca_module; struct ehca_module;
struct ehca_qp; struct ehca_qp;
struct ehca_cq; struct ehca_cq;
...@@ -100,6 +99,11 @@ struct ehca_sport { ...@@ -100,6 +99,11 @@ struct ehca_sport {
struct ehca_sma_attr saved_attr; struct ehca_sma_attr saved_attr;
}; };
#define HCA_CAP_MR_PGSIZE_4K 1
#define HCA_CAP_MR_PGSIZE_64K 2
#define HCA_CAP_MR_PGSIZE_1M 4
#define HCA_CAP_MR_PGSIZE_16M 8
struct ehca_shca { struct ehca_shca {
struct ib_device ib_device; struct ib_device ib_device;
struct ibmebus_dev *ibmebus_dev; struct ibmebus_dev *ibmebus_dev;
...@@ -115,6 +119,8 @@ struct ehca_shca { ...@@ -115,6 +119,8 @@ struct ehca_shca {
struct h_galpas galpas; struct h_galpas galpas;
struct mutex modify_mutex; struct mutex modify_mutex;
u64 hca_cap; u64 hca_cap;
/* MR pgsize: bit 0-3 means 4K, 64K, 1M, 16M respectively */
u32 hca_cap_mr_pgsize;
int max_mtu; int max_mtu;
}; };
...@@ -122,6 +128,10 @@ struct ehca_pd { ...@@ -122,6 +128,10 @@ struct ehca_pd {
struct ib_pd ib_pd; struct ib_pd ib_pd;
struct ipz_pd fw_pd; struct ipz_pd fw_pd;
u32 ownpid; u32 ownpid;
/* small queue mgmt */
struct mutex lock;
struct list_head free[2];
struct list_head full[2];
}; };
enum ehca_ext_qp_type { enum ehca_ext_qp_type {
...@@ -206,6 +216,7 @@ struct ehca_mr { ...@@ -206,6 +216,7 @@ struct ehca_mr {
enum ehca_mr_flag flags; enum ehca_mr_flag flags;
u32 num_kpages; /* number of kernel pages */ u32 num_kpages; /* number of kernel pages */
u32 num_hwpages; /* number of hw pages to form MR */ u32 num_hwpages; /* number of hw pages to form MR */
u64 hwpage_size; /* hw page size used for this MR */
int acl; /* ACL (stored here for usage in reregister) */ int acl; /* ACL (stored here for usage in reregister) */
u64 *start; /* virtual start address (stored here for */ u64 *start; /* virtual start address (stored here for */
/* usage in reregister) */ /* usage in reregister) */
...@@ -240,6 +251,7 @@ struct ehca_mr_pginfo { ...@@ -240,6 +251,7 @@ struct ehca_mr_pginfo {
enum ehca_mr_pgi_type type; enum ehca_mr_pgi_type type;
u64 num_kpages; u64 num_kpages;
u64 kpage_cnt; u64 kpage_cnt;
u64 hwpage_size; /* hw page size used for this MR */
u64 num_hwpages; /* number of hw pages */ u64 num_hwpages; /* number of hw pages */
u64 hwpage_cnt; /* counter for hw pages */ u64 hwpage_cnt; /* counter for hw pages */
u64 next_hwpage; /* next hw page in buffer/chunk/listelem */ u64 next_hwpage; /* next hw page in buffer/chunk/listelem */
...@@ -298,6 +310,8 @@ int ehca_init_av_cache(void); ...@@ -298,6 +310,8 @@ int ehca_init_av_cache(void);
void ehca_cleanup_av_cache(void); void ehca_cleanup_av_cache(void);
int ehca_init_mrmw_cache(void); int ehca_init_mrmw_cache(void);
void ehca_cleanup_mrmw_cache(void); void ehca_cleanup_mrmw_cache(void);
int ehca_init_small_qp_cache(void);
void ehca_cleanup_small_qp_cache(void);
extern rwlock_t ehca_qp_idr_lock; extern rwlock_t ehca_qp_idr_lock;
extern rwlock_t ehca_cq_idr_lock; extern rwlock_t ehca_cq_idr_lock;
...@@ -315,7 +329,7 @@ struct ipzu_queue_resp { ...@@ -315,7 +329,7 @@ struct ipzu_queue_resp {
u32 queue_length; /* queue length allocated in bytes */ u32 queue_length; /* queue length allocated in bytes */
u32 pagesize; u32 pagesize;
u32 toggle_state; u32 toggle_state;
u32 dummy; /* padding for 8 byte alignment */ u32 offset; /* save offset within a page for small_qp */
}; };
struct ehca_create_cq_resp { struct ehca_create_cq_resp {
...@@ -357,15 +371,29 @@ enum ehca_ll_comp_flags { ...@@ -357,15 +371,29 @@ enum ehca_ll_comp_flags {
LLQP_COMP_MASK = 0x60, LLQP_COMP_MASK = 0x60,
}; };
struct ehca_alloc_queue_parms {
/* input parameters */
int max_wr;
int max_sge;
int page_size;
int is_small;
/* output parameters */
u16 act_nr_wqes;
u8 act_nr_sges;
u32 queue_size; /* bytes for small queues, pages otherwise */
};
struct ehca_alloc_qp_parms { struct ehca_alloc_qp_parms {
/* input parameters */ struct ehca_alloc_queue_parms squeue;
struct ehca_alloc_queue_parms rqueue;
/* input parameters */
enum ehca_service_type servicetype; enum ehca_service_type servicetype;
int qp_storage;
int sigtype; int sigtype;
enum ehca_ext_qp_type ext_type; enum ehca_ext_qp_type ext_type;
enum ehca_ll_comp_flags ll_comp_flags; enum ehca_ll_comp_flags ll_comp_flags;
int max_send_wr, max_recv_wr;
int max_send_sge, max_recv_sge;
int ud_av_l_key_ctl; int ud_av_l_key_ctl;
u32 token; u32 token;
...@@ -375,18 +403,10 @@ struct ehca_alloc_qp_parms { ...@@ -375,18 +403,10 @@ struct ehca_alloc_qp_parms {
u32 srq_qpn, srq_token, srq_limit; u32 srq_qpn, srq_token, srq_limit;
/* output parameters */ /* output parameters */
u32 real_qp_num; u32 real_qp_num;
struct ipz_qp_handle qp_handle; struct ipz_qp_handle qp_handle;
struct h_galpas galpas; struct h_galpas galpas;
u16 act_nr_send_wqes;
u16 act_nr_recv_wqes;
u8 act_nr_recv_sges;
u8 act_nr_send_sges;
u32 nr_rq_pages;
u32 nr_sq_pages;
}; };
int ehca_cq_assign_qp(struct ehca_cq *cq, struct ehca_qp *qp); int ehca_cq_assign_qp(struct ehca_cq *cq, struct ehca_qp *qp);
......
...@@ -190,8 +190,8 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector, ...@@ -190,8 +190,8 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector,
goto create_cq_exit2; goto create_cq_exit2;
} }
ipz_rc = ipz_queue_ctor(&my_cq->ipz_queue, param.act_pages, ipz_rc = ipz_queue_ctor(NULL, &my_cq->ipz_queue, param.act_pages,
EHCA_PAGESIZE, sizeof(struct ehca_cqe), 0); EHCA_PAGESIZE, sizeof(struct ehca_cqe), 0, 0);
if (!ipz_rc) { if (!ipz_rc) {
ehca_err(device, "ipz_queue_ctor() failed ipz_rc=%x device=%p", ehca_err(device, "ipz_queue_ctor() failed ipz_rc=%x device=%p",
ipz_rc, device); ipz_rc, device);
...@@ -285,7 +285,7 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector, ...@@ -285,7 +285,7 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector,
return cq; return cq;
create_cq_exit4: create_cq_exit4:
ipz_queue_dtor(&my_cq->ipz_queue); ipz_queue_dtor(NULL, &my_cq->ipz_queue);
create_cq_exit3: create_cq_exit3:
h_ret = hipz_h_destroy_cq(adapter_handle, my_cq, 1); h_ret = hipz_h_destroy_cq(adapter_handle, my_cq, 1);
...@@ -359,7 +359,7 @@ int ehca_destroy_cq(struct ib_cq *cq) ...@@ -359,7 +359,7 @@ int ehca_destroy_cq(struct ib_cq *cq)
"ehca_cq=%p cq_num=%x", h_ret, my_cq, cq_num); "ehca_cq=%p cq_num=%x", h_ret, my_cq, cq_num);
return ehca2ib_return_code(h_ret); return ehca2ib_return_code(h_ret);
} }
ipz_queue_dtor(&my_cq->ipz_queue); ipz_queue_dtor(NULL, &my_cq->ipz_queue);
kmem_cache_free(cq_cache, my_cq); kmem_cache_free(cq_cache, my_cq);
return 0; return 0;
......
...@@ -86,8 +86,8 @@ int ehca_create_eq(struct ehca_shca *shca, ...@@ -86,8 +86,8 @@ int ehca_create_eq(struct ehca_shca *shca,
return -EINVAL; return -EINVAL;
} }
ret = ipz_queue_ctor(&eq->ipz_queue, nr_pages, ret = ipz_queue_ctor(NULL, &eq->ipz_queue, nr_pages,
EHCA_PAGESIZE, sizeof(struct ehca_eqe), 0); EHCA_PAGESIZE, sizeof(struct ehca_eqe), 0, 0);
if (!ret) { if (!ret) {
ehca_err(ib_dev, "Can't allocate EQ pages eq=%p", eq); ehca_err(ib_dev, "Can't allocate EQ pages eq=%p", eq);
goto create_eq_exit1; goto create_eq_exit1;
...@@ -145,7 +145,7 @@ int ehca_create_eq(struct ehca_shca *shca, ...@@ -145,7 +145,7 @@ int ehca_create_eq(struct ehca_shca *shca,
return 0; return 0;
create_eq_exit2: create_eq_exit2:
ipz_queue_dtor(&eq->ipz_queue); ipz_queue_dtor(NULL, &eq->ipz_queue);
create_eq_exit1: create_eq_exit1:
hipz_h_destroy_eq(shca->ipz_hca_handle, eq); hipz_h_destroy_eq(shca->ipz_hca_handle, eq);
...@@ -181,7 +181,7 @@ int ehca_destroy_eq(struct ehca_shca *shca, struct ehca_eq *eq) ...@@ -181,7 +181,7 @@ int ehca_destroy_eq(struct ehca_shca *shca, struct ehca_eq *eq)
ehca_err(&shca->ib_device, "Can't free EQ resources."); ehca_err(&shca->ib_device, "Can't free EQ resources.");
return -EINVAL; return -EINVAL;
} }
ipz_queue_dtor(&eq->ipz_queue); ipz_queue_dtor(NULL, &eq->ipz_queue);
return 0; return 0;
} }
...@@ -175,9 +175,8 @@ int ehca_error_data(struct ehca_shca *shca, void *data, ...@@ -175,9 +175,8 @@ int ehca_error_data(struct ehca_shca *shca, void *data,
} }
static void qp_event_callback(struct ehca_shca *shca, static void qp_event_callback(struct ehca_shca *shca, u64 eqe,
u64 eqe, enum ib_event_type event_type, int fatal)
enum ib_event_type event_type)
{ {
struct ib_event event; struct ib_event event;
struct ehca_qp *qp; struct ehca_qp *qp;
...@@ -191,16 +190,26 @@ static void qp_event_callback(struct ehca_shca *shca, ...@@ -191,16 +190,26 @@ static void qp_event_callback(struct ehca_shca *shca,
if (!qp) if (!qp)
return; return;
ehca_error_data(shca, qp, qp->ipz_qp_handle.handle); if (fatal)
ehca_error_data(shca, qp, qp->ipz_qp_handle.handle);
if (!qp->ib_qp.event_handler) event.device = &shca->ib_device;
return;
event.device = &shca->ib_device; if (qp->ext_type == EQPT_SRQ) {
event.event = event_type; if (!qp->ib_srq.event_handler)
event.element.qp = &qp->ib_qp; return;
qp->ib_qp.event_handler(&event, qp->ib_qp.qp_context); event.event = fatal ? IB_EVENT_SRQ_ERR : event_type;
event.element.srq = &qp->ib_srq;
qp->ib_srq.event_handler(&event, qp->ib_srq.srq_context);
} else {
if (!qp->ib_qp.event_handler)
return;
event.event = event_type;
event.element.qp = &qp->ib_qp;
qp->ib_qp.event_handler(&event, qp->ib_qp.qp_context);
}
return; return;
} }
...@@ -234,17 +243,17 @@ static void parse_identifier(struct ehca_shca *shca, u64 eqe) ...@@ -234,17 +243,17 @@ static void parse_identifier(struct ehca_shca *shca, u64 eqe)
switch (identifier) { switch (identifier) {
case 0x02: /* path migrated */ case 0x02: /* path migrated */
qp_event_callback(shca, eqe, IB_EVENT_PATH_MIG); qp_event_callback(shca, eqe, IB_EVENT_PATH_MIG, 0);
break; break;
case 0x03: /* communication established */ case 0x03: /* communication established */
qp_event_callback(shca, eqe, IB_EVENT_COMM_EST); qp_event_callback(shca, eqe, IB_EVENT_COMM_EST, 0);
break; break;
case 0x04: /* send queue drained */ case 0x04: /* send queue drained */
qp_event_callback(shca, eqe, IB_EVENT_SQ_DRAINED); qp_event_callback(shca, eqe, IB_EVENT_SQ_DRAINED, 0);
break; break;
case 0x05: /* QP error */ case 0x05: /* QP error */
case 0x06: /* QP error */ case 0x06: /* QP error */
qp_event_callback(shca, eqe, IB_EVENT_QP_FATAL); qp_event_callback(shca, eqe, IB_EVENT_QP_FATAL, 1);
break; break;
case 0x07: /* CQ error */ case 0x07: /* CQ error */
case 0x08: /* CQ error */ case 0x08: /* CQ error */
...@@ -278,6 +287,11 @@ static void parse_identifier(struct ehca_shca *shca, u64 eqe) ...@@ -278,6 +287,11 @@ static void parse_identifier(struct ehca_shca *shca, u64 eqe)
ehca_err(&shca->ib_device, "Interface trace stopped."); ehca_err(&shca->ib_device, "Interface trace stopped.");
break; break;
case 0x14: /* first error capture info available */ case 0x14: /* first error capture info available */
ehca_info(&shca->ib_device, "First error capture available");
break;
case 0x15: /* SRQ limit reached */
qp_event_callback(shca, eqe, IB_EVENT_SRQ_LIMIT_REACHED, 0);
break;
default: default:
ehca_err(&shca->ib_device, "Unknown identifier: %x on %s.", ehca_err(&shca->ib_device, "Unknown identifier: %x on %s.",
identifier, shca->ib_device.name); identifier, shca->ib_device.name);
......
...@@ -63,6 +63,7 @@ int ehca_port_act_time = 30; ...@@ -63,6 +63,7 @@ int ehca_port_act_time = 30;
int ehca_poll_all_eqs = 1; int ehca_poll_all_eqs = 1;
int ehca_static_rate = -1; int ehca_static_rate = -1;
int ehca_scaling_code = 0; int ehca_scaling_code = 0;
int ehca_mr_largepage = 0;
module_param_named(open_aqp1, ehca_open_aqp1, int, 0); module_param_named(open_aqp1, ehca_open_aqp1, int, 0);
module_param_named(debug_level, ehca_debug_level, int, 0); module_param_named(debug_level, ehca_debug_level, int, 0);
...@@ -72,7 +73,8 @@ module_param_named(use_hp_mr, ehca_use_hp_mr, int, 0); ...@@ -72,7 +73,8 @@ module_param_named(use_hp_mr, ehca_use_hp_mr, int, 0);
module_param_named(port_act_time, ehca_port_act_time, int, 0); module_param_named(port_act_time, ehca_port_act_time, int, 0);
module_param_named(poll_all_eqs, ehca_poll_all_eqs, int, 0); module_param_named(poll_all_eqs, ehca_poll_all_eqs, int, 0);
module_param_named(static_rate, ehca_static_rate, int, 0); module_param_named(static_rate, ehca_static_rate, int, 0);
module_param_named(scaling_code, ehca_scaling_code, int, 0); module_param_named(scaling_code, ehca_scaling_code, int, 0);
module_param_named(mr_largepage, ehca_mr_largepage, int, 0);
MODULE_PARM_DESC(open_aqp1, MODULE_PARM_DESC(open_aqp1,
"AQP1 on startup (0: no (default), 1: yes)"); "AQP1 on startup (0: no (default), 1: yes)");
...@@ -95,6 +97,9 @@ MODULE_PARM_DESC(static_rate, ...@@ -95,6 +97,9 @@ MODULE_PARM_DESC(static_rate,
"set permanent static rate (default: disabled)"); "set permanent static rate (default: disabled)");
MODULE_PARM_DESC(scaling_code, MODULE_PARM_DESC(scaling_code,
"set scaling code (0: disabled/default, 1: enabled)"); "set scaling code (0: disabled/default, 1: enabled)");
MODULE_PARM_DESC(mr_largepage,
"use large page for MR (0: use PAGE_SIZE (default), "
"1: use large page depending on MR size");
DEFINE_RWLOCK(ehca_qp_idr_lock); DEFINE_RWLOCK(ehca_qp_idr_lock);
DEFINE_RWLOCK(ehca_cq_idr_lock); DEFINE_RWLOCK(ehca_cq_idr_lock);
...@@ -125,6 +130,23 @@ void ehca_free_fw_ctrlblock(void *ptr) ...@@ -125,6 +130,23 @@ void ehca_free_fw_ctrlblock(void *ptr)
} }
#endif #endif
int ehca2ib_return_code(u64 ehca_rc)
{
switch (ehca_rc) {
case H_SUCCESS:
return 0;
case H_RESOURCE: /* Resource in use */
case H_BUSY:
return -EBUSY;
case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
case H_CONSTRAINED: /* resource constraint */
case H_NO_MEM:
return -ENOMEM;
default:
return -EINVAL;
}
}
static int ehca_create_slab_caches(void) static int ehca_create_slab_caches(void)
{ {
int ret; int ret;
...@@ -159,6 +181,12 @@ static int ehca_create_slab_caches(void) ...@@ -159,6 +181,12 @@ static int ehca_create_slab_caches(void)
goto create_slab_caches5; goto create_slab_caches5;
} }
ret = ehca_init_small_qp_cache();
if (ret) {
ehca_gen_err("Cannot create small queue SLAB cache.");
goto create_slab_caches6;
}
#ifdef CONFIG_PPC_64K_PAGES #ifdef CONFIG_PPC_64K_PAGES
ctblk_cache = kmem_cache_create("ehca_cache_ctblk", ctblk_cache = kmem_cache_create("ehca_cache_ctblk",
EHCA_PAGESIZE, H_CB_ALIGNMENT, EHCA_PAGESIZE, H_CB_ALIGNMENT,
...@@ -166,12 +194,15 @@ static int ehca_create_slab_caches(void) ...@@ -166,12 +194,15 @@ static int ehca_create_slab_caches(void)
NULL); NULL);
if (!ctblk_cache) { if (!ctblk_cache) {
ehca_gen_err("Cannot create ctblk SLAB cache."); ehca_gen_err("Cannot create ctblk SLAB cache.");
ehca_cleanup_mrmw_cache(); ehca_cleanup_small_qp_cache();
goto create_slab_caches5; goto create_slab_caches6;
} }
#endif #endif
return 0; return 0;
create_slab_caches6:
ehca_cleanup_mrmw_cache();
create_slab_caches5: create_slab_caches5:
ehca_cleanup_av_cache(); ehca_cleanup_av_cache();
...@@ -189,6 +220,7 @@ static int ehca_create_slab_caches(void) ...@@ -189,6 +220,7 @@ static int ehca_create_slab_caches(void)
static void ehca_destroy_slab_caches(void) static void ehca_destroy_slab_caches(void)
{ {
ehca_cleanup_small_qp_cache();
ehca_cleanup_mrmw_cache(); ehca_cleanup_mrmw_cache();
ehca_cleanup_av_cache(); ehca_cleanup_av_cache();
ehca_cleanup_qp_cache(); ehca_cleanup_qp_cache();
...@@ -295,6 +327,8 @@ int ehca_sense_attributes(struct ehca_shca *shca) ...@@ -295,6 +327,8 @@ int ehca_sense_attributes(struct ehca_shca *shca)
if (EHCA_BMASK_GET(hca_cap_descr[i].mask, shca->hca_cap)) if (EHCA_BMASK_GET(hca_cap_descr[i].mask, shca->hca_cap))
ehca_gen_dbg(" %s", hca_cap_descr[i].descr); ehca_gen_dbg(" %s", hca_cap_descr[i].descr);
shca->hca_cap_mr_pgsize = rblock->memory_page_size_supported;
port = (struct hipz_query_port *)rblock; port = (struct hipz_query_port *)rblock;
h_ret = hipz_h_query_port(shca->ipz_hca_handle, 1, port); h_ret = hipz_h_query_port(shca->ipz_hca_handle, 1, port);
if (h_ret != H_SUCCESS) { if (h_ret != H_SUCCESS) {
...@@ -590,6 +624,14 @@ static ssize_t ehca_show_adapter_handle(struct device *dev, ...@@ -590,6 +624,14 @@ static ssize_t ehca_show_adapter_handle(struct device *dev,
} }
static DEVICE_ATTR(adapter_handle, S_IRUGO, ehca_show_adapter_handle, NULL); static DEVICE_ATTR(adapter_handle, S_IRUGO, ehca_show_adapter_handle, NULL);
static ssize_t ehca_show_mr_largepage(struct device *dev,
struct device_attribute *attr,
char *buf)
{
return sprintf(buf, "%d\n", ehca_mr_largepage);
}
static DEVICE_ATTR(mr_largepage, S_IRUGO, ehca_show_mr_largepage, NULL);
static struct attribute *ehca_dev_attrs[] = { static struct attribute *ehca_dev_attrs[] = {
&dev_attr_adapter_handle.attr, &dev_attr_adapter_handle.attr,
&dev_attr_num_ports.attr, &dev_attr_num_ports.attr,
...@@ -606,6 +648,7 @@ static struct attribute *ehca_dev_attrs[] = { ...@@ -606,6 +648,7 @@ static struct attribute *ehca_dev_attrs[] = {
&dev_attr_cur_mw.attr, &dev_attr_cur_mw.attr,
&dev_attr_max_pd.attr, &dev_attr_max_pd.attr,
&dev_attr_max_ah.attr, &dev_attr_max_ah.attr,
&dev_attr_mr_largepage.attr,
NULL NULL
}; };
......
This diff is collapsed.
...@@ -111,7 +111,7 @@ int ehca_mr_is_maxmr(u64 size, ...@@ -111,7 +111,7 @@ int ehca_mr_is_maxmr(u64 size,
void ehca_mrmw_map_acl(int ib_acl, void ehca_mrmw_map_acl(int ib_acl,
u32 *hipz_acl); u32 *hipz_acl);
void ehca_mrmw_set_pgsize_hipz_acl(u32 *hipz_acl); void ehca_mrmw_set_pgsize_hipz_acl(u32 pgsize, u32 *hipz_acl);
void ehca_mrmw_reverse_map_acl(const u32 *hipz_acl, void ehca_mrmw_reverse_map_acl(const u32 *hipz_acl,
int *ib_acl); int *ib_acl);
......
...@@ -49,6 +49,7 @@ struct ib_pd *ehca_alloc_pd(struct ib_device *device, ...@@ -49,6 +49,7 @@ struct ib_pd *ehca_alloc_pd(struct ib_device *device,
struct ib_ucontext *context, struct ib_udata *udata) struct ib_ucontext *context, struct ib_udata *udata)
{ {
struct ehca_pd *pd; struct ehca_pd *pd;
int i;
pd = kmem_cache_zalloc(pd_cache, GFP_KERNEL); pd = kmem_cache_zalloc(pd_cache, GFP_KERNEL);
if (!pd) { if (!pd) {
...@@ -58,6 +59,11 @@ struct ib_pd *ehca_alloc_pd(struct ib_device *device, ...@@ -58,6 +59,11 @@ struct ib_pd *ehca_alloc_pd(struct ib_device *device,
} }
pd->ownpid = current->tgid; pd->ownpid = current->tgid;
for (i = 0; i < 2; i++) {
INIT_LIST_HEAD(&pd->free[i]);
INIT_LIST_HEAD(&pd->full[i]);
}
mutex_init(&pd->lock);
/* /*
* Kernel PD: when device = -1, 0 * Kernel PD: when device = -1, 0
...@@ -81,6 +87,9 @@ int ehca_dealloc_pd(struct ib_pd *pd) ...@@ -81,6 +87,9 @@ int ehca_dealloc_pd(struct ib_pd *pd)
{ {
u32 cur_pid = current->tgid; u32 cur_pid = current->tgid;
struct ehca_pd *my_pd = container_of(pd, struct ehca_pd, ib_pd); struct ehca_pd *my_pd = container_of(pd, struct ehca_pd, ib_pd);
int i, leftovers = 0;
extern struct kmem_cache *small_qp_cache;
struct ipz_small_queue_page *page, *tmp;
if (my_pd->ib_pd.uobject && my_pd->ib_pd.uobject->context && if (my_pd->ib_pd.uobject && my_pd->ib_pd.uobject->context &&
my_pd->ownpid != cur_pid) { my_pd->ownpid != cur_pid) {
...@@ -89,8 +98,20 @@ int ehca_dealloc_pd(struct ib_pd *pd) ...@@ -89,8 +98,20 @@ int ehca_dealloc_pd(struct ib_pd *pd)
return -EINVAL; return -EINVAL;
} }
kmem_cache_free(pd_cache, for (i = 0; i < 2; i++) {
container_of(pd, struct ehca_pd, ib_pd)); list_splice(&my_pd->full[i], &my_pd->free[i]);
list_for_each_entry_safe(page, tmp, &my_pd->free[i], list) {
leftovers = 1;
free_page(page->page);
kmem_cache_free(small_qp_cache, page);
}
}
if (leftovers)
ehca_warn(pd->device,
"Some small queue pages were not freed");
kmem_cache_free(pd_cache, my_pd);
return 0; return 0;
} }
......
This diff is collapsed.
...@@ -154,24 +154,7 @@ extern int ehca_debug_level; ...@@ -154,24 +154,7 @@ extern int ehca_debug_level;
#define EHCA_BMASK_GET(mask, value) \ #define EHCA_BMASK_GET(mask, value) \
(EHCA_BMASK_MASK(mask) & (((u64)(value)) >> EHCA_BMASK_SHIFTPOS(mask))) (EHCA_BMASK_MASK(mask) & (((u64)(value)) >> EHCA_BMASK_SHIFTPOS(mask)))
/* Converts ehca to ib return code */ /* Converts ehca to ib return code */
static inline int ehca2ib_return_code(u64 ehca_rc) int ehca2ib_return_code(u64 ehca_rc);
{
switch (ehca_rc) {
case H_SUCCESS:
return 0;
case H_RESOURCE: /* Resource in use */
case H_BUSY:
return -EBUSY;
case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
case H_CONSTRAINED: /* resource constraint */
case H_NO_MEM:
return -ENOMEM;
default:
return -EINVAL;
}
}
#endif /* EHCA_TOOLS_H */ #endif /* EHCA_TOOLS_H */
...@@ -149,7 +149,7 @@ static int ehca_mmap_queue(struct vm_area_struct *vma, struct ipz_queue *queue, ...@@ -149,7 +149,7 @@ static int ehca_mmap_queue(struct vm_area_struct *vma, struct ipz_queue *queue,
ehca_gen_err("vm_insert_page() failed rc=%x", ret); ehca_gen_err("vm_insert_page() failed rc=%x", ret);
return ret; return ret;
} }
start += PAGE_SIZE; start += PAGE_SIZE;
} }
vma->vm_private_data = mm_count; vma->vm_private_data = mm_count;
(*mm_count)++; (*mm_count)++;
......
...@@ -52,10 +52,13 @@ ...@@ -52,10 +52,13 @@
#define H_ALL_RES_QP_ENHANCED_OPS EHCA_BMASK_IBM(9, 11) #define H_ALL_RES_QP_ENHANCED_OPS EHCA_BMASK_IBM(9, 11)
#define H_ALL_RES_QP_PTE_PIN EHCA_BMASK_IBM(12, 12) #define H_ALL_RES_QP_PTE_PIN EHCA_BMASK_IBM(12, 12)
#define H_ALL_RES_QP_SERVICE_TYPE EHCA_BMASK_IBM(13, 15) #define H_ALL_RES_QP_SERVICE_TYPE EHCA_BMASK_IBM(13, 15)
#define H_ALL_RES_QP_STORAGE EHCA_BMASK_IBM(16, 17)
#define H_ALL_RES_QP_LL_RQ_CQE_POSTING EHCA_BMASK_IBM(18, 18) #define H_ALL_RES_QP_LL_RQ_CQE_POSTING EHCA_BMASK_IBM(18, 18)
#define H_ALL_RES_QP_LL_SQ_CQE_POSTING EHCA_BMASK_IBM(19, 21) #define H_ALL_RES_QP_LL_SQ_CQE_POSTING EHCA_BMASK_IBM(19, 21)
#define H_ALL_RES_QP_SIGNALING_TYPE EHCA_BMASK_IBM(22, 23) #define H_ALL_RES_QP_SIGNALING_TYPE EHCA_BMASK_IBM(22, 23)
#define H_ALL_RES_QP_UD_AV_LKEY_CTRL EHCA_BMASK_IBM(31, 31) #define H_ALL_RES_QP_UD_AV_LKEY_CTRL EHCA_BMASK_IBM(31, 31)
#define H_ALL_RES_QP_SMALL_SQ_PAGE_SIZE EHCA_BMASK_IBM(32, 35)
#define H_ALL_RES_QP_SMALL_RQ_PAGE_SIZE EHCA_BMASK_IBM(36, 39)
#define H_ALL_RES_QP_RESOURCE_TYPE EHCA_BMASK_IBM(56, 63) #define H_ALL_RES_QP_RESOURCE_TYPE EHCA_BMASK_IBM(56, 63)
#define H_ALL_RES_QP_MAX_OUTST_SEND_WR EHCA_BMASK_IBM(0, 15) #define H_ALL_RES_QP_MAX_OUTST_SEND_WR EHCA_BMASK_IBM(0, 15)
...@@ -299,6 +302,11 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle, ...@@ -299,6 +302,11 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle,
| EHCA_BMASK_SET(H_ALL_RES_QP_PTE_PIN, 0) | EHCA_BMASK_SET(H_ALL_RES_QP_PTE_PIN, 0)
| EHCA_BMASK_SET(H_ALL_RES_QP_SERVICE_TYPE, parms->servicetype) | EHCA_BMASK_SET(H_ALL_RES_QP_SERVICE_TYPE, parms->servicetype)
| EHCA_BMASK_SET(H_ALL_RES_QP_SIGNALING_TYPE, parms->sigtype) | EHCA_BMASK_SET(H_ALL_RES_QP_SIGNALING_TYPE, parms->sigtype)
| EHCA_BMASK_SET(H_ALL_RES_QP_STORAGE, parms->qp_storage)
| EHCA_BMASK_SET(H_ALL_RES_QP_SMALL_SQ_PAGE_SIZE,
parms->squeue.page_size)
| EHCA_BMASK_SET(H_ALL_RES_QP_SMALL_RQ_PAGE_SIZE,
parms->rqueue.page_size)
| EHCA_BMASK_SET(H_ALL_RES_QP_LL_RQ_CQE_POSTING, | EHCA_BMASK_SET(H_ALL_RES_QP_LL_RQ_CQE_POSTING,
!!(parms->ll_comp_flags & LLQP_RECV_COMP)) !!(parms->ll_comp_flags & LLQP_RECV_COMP))
| EHCA_BMASK_SET(H_ALL_RES_QP_LL_SQ_CQE_POSTING, | EHCA_BMASK_SET(H_ALL_RES_QP_LL_SQ_CQE_POSTING,
...@@ -309,13 +317,13 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle, ...@@ -309,13 +317,13 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle,
max_r10_reg = max_r10_reg =
EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_SEND_WR, EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_SEND_WR,
parms->max_send_wr + 1) parms->squeue.max_wr + 1)
| EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_RECV_WR, | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_RECV_WR,
parms->max_recv_wr + 1) parms->rqueue.max_wr + 1)
| EHCA_BMASK_SET(H_ALL_RES_QP_MAX_SEND_SGE, | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_SEND_SGE,
parms->max_send_sge) parms->squeue.max_sge)
| EHCA_BMASK_SET(H_ALL_RES_QP_MAX_RECV_SGE, | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_RECV_SGE,
parms->max_recv_sge); parms->rqueue.max_sge);
r11 = EHCA_BMASK_SET(H_ALL_RES_QP_SRQ_QP_TOKEN, parms->srq_token); r11 = EHCA_BMASK_SET(H_ALL_RES_QP_SRQ_QP_TOKEN, parms->srq_token);
...@@ -335,17 +343,17 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle, ...@@ -335,17 +343,17 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle,
parms->qp_handle.handle = outs[0]; parms->qp_handle.handle = outs[0];
parms->real_qp_num = (u32)outs[1]; parms->real_qp_num = (u32)outs[1];
parms->act_nr_send_wqes = parms->squeue.act_nr_wqes =
(u16)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_OUTST_SEND_WR, outs[2]); (u16)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_OUTST_SEND_WR, outs[2]);
parms->act_nr_recv_wqes = parms->rqueue.act_nr_wqes =
(u16)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_OUTST_RECV_WR, outs[2]); (u16)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_OUTST_RECV_WR, outs[2]);
parms->act_nr_send_sges = parms->squeue.act_nr_sges =
(u8)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_SEND_SGE, outs[3]); (u8)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_SEND_SGE, outs[3]);
parms->act_nr_recv_sges = parms->rqueue.act_nr_sges =
(u8)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_RECV_SGE, outs[3]); (u8)EHCA_BMASK_GET(H_ALL_RES_QP_ACT_RECV_SGE, outs[3]);
parms->nr_sq_pages = parms->squeue.queue_size =
(u32)EHCA_BMASK_GET(H_ALL_RES_QP_SQUEUE_SIZE_PAGES, outs[4]); (u32)EHCA_BMASK_GET(H_ALL_RES_QP_SQUEUE_SIZE_PAGES, outs[4]);
parms->nr_rq_pages = parms->rqueue.queue_size =
(u32)EHCA_BMASK_GET(H_ALL_RES_QP_RQUEUE_SIZE_PAGES, outs[4]); (u32)EHCA_BMASK_GET(H_ALL_RES_QP_RQUEUE_SIZE_PAGES, outs[4]);
if (ret == H_SUCCESS) if (ret == H_SUCCESS)
...@@ -427,7 +435,8 @@ u64 hipz_h_register_rpage(const struct ipz_adapter_handle adapter_handle, ...@@ -427,7 +435,8 @@ u64 hipz_h_register_rpage(const struct ipz_adapter_handle adapter_handle,
{ {
return ehca_plpar_hcall_norets(H_REGISTER_RPAGES, return ehca_plpar_hcall_norets(H_REGISTER_RPAGES,
adapter_handle.handle, /* r4 */ adapter_handle.handle, /* r4 */
queue_type | pagesize << 8, /* r5 */ (u64)queue_type | ((u64)pagesize) << 8,
/* r5 */
resource_handle, /* r6 */ resource_handle, /* r6 */
logical_address_of_page, /* r7 */ logical_address_of_page, /* r7 */
count, /* r8 */ count, /* r8 */
...@@ -496,7 +505,7 @@ u64 hipz_h_register_rpage_qp(const struct ipz_adapter_handle adapter_handle, ...@@ -496,7 +505,7 @@ u64 hipz_h_register_rpage_qp(const struct ipz_adapter_handle adapter_handle,
const u64 count, const u64 count,
const struct h_galpa galpa) const struct h_galpa galpa)
{ {
if (count != 1) { if (count > 1) {
ehca_gen_err("Page counter=%lx", count); ehca_gen_err("Page counter=%lx", count);
return H_PARAMETER; return H_PARAMETER;
} }
...@@ -724,6 +733,9 @@ u64 hipz_h_alloc_resource_mr(const struct ipz_adapter_handle adapter_handle, ...@@ -724,6 +733,9 @@ u64 hipz_h_alloc_resource_mr(const struct ipz_adapter_handle adapter_handle,
u64 ret; u64 ret;
u64 outs[PLPAR_HCALL9_BUFSIZE]; u64 outs[PLPAR_HCALL9_BUFSIZE];
ehca_gen_dbg("kernel PAGE_SIZE=%x access_ctrl=%016x "
"vaddr=%lx length=%lx",
(u32)PAGE_SIZE, access_ctrl, vaddr, length);
ret = ehca_plpar_hcall9(H_ALLOC_RESOURCE, outs, ret = ehca_plpar_hcall9(H_ALLOC_RESOURCE, outs,
adapter_handle.handle, /* r4 */ adapter_handle.handle, /* r4 */
5, /* r5 */ 5, /* r5 */
...@@ -746,8 +758,22 @@ u64 hipz_h_register_rpage_mr(const struct ipz_adapter_handle adapter_handle, ...@@ -746,8 +758,22 @@ u64 hipz_h_register_rpage_mr(const struct ipz_adapter_handle adapter_handle,
const u64 logical_address_of_page, const u64 logical_address_of_page,
const u64 count) const u64 count)
{ {
extern int ehca_debug_level;
u64 ret; u64 ret;
if (unlikely(ehca_debug_level >= 2)) {
if (count > 1) {
u64 *kpage;
int i;
kpage = (u64 *)abs_to_virt(logical_address_of_page);
for (i = 0; i < count; i++)
ehca_gen_dbg("kpage[%d]=%p",
i, (void *)kpage[i]);
} else
ehca_gen_dbg("kpage=%p",
(void *)logical_address_of_page);
}
if ((count > 1) && (logical_address_of_page & (EHCA_PAGESIZE-1))) { if ((count > 1) && (logical_address_of_page & (EHCA_PAGESIZE-1))) {
ehca_gen_err("logical_address_of_page not on a 4k boundary " ehca_gen_err("logical_address_of_page not on a 4k boundary "
"adapter_handle=%lx mr=%p mr_handle=%lx " "adapter_handle=%lx mr=%p mr_handle=%lx "
......
...@@ -40,6 +40,11 @@ ...@@ -40,6 +40,11 @@
#include "ehca_tools.h" #include "ehca_tools.h"
#include "ipz_pt_fn.h" #include "ipz_pt_fn.h"
#include "ehca_classes.h"
#define PAGES_PER_KPAGE (PAGE_SIZE >> EHCA_PAGESHIFT)
struct kmem_cache *small_qp_cache;
void *ipz_qpageit_get_inc(struct ipz_queue *queue) void *ipz_qpageit_get_inc(struct ipz_queue *queue)
{ {
...@@ -49,7 +54,7 @@ void *ipz_qpageit_get_inc(struct ipz_queue *queue) ...@@ -49,7 +54,7 @@ void *ipz_qpageit_get_inc(struct ipz_queue *queue)
queue->current_q_offset -= queue->pagesize; queue->current_q_offset -= queue->pagesize;
ret = NULL; ret = NULL;
} }
if (((u64)ret) % EHCA_PAGESIZE) { if (((u64)ret) % queue->pagesize) {
ehca_gen_err("ERROR!! not at PAGE-Boundary"); ehca_gen_err("ERROR!! not at PAGE-Boundary");
return NULL; return NULL;
} }
...@@ -83,80 +88,195 @@ int ipz_queue_abs_to_offset(struct ipz_queue *queue, u64 addr, u64 *q_offset) ...@@ -83,80 +88,195 @@ int ipz_queue_abs_to_offset(struct ipz_queue *queue, u64 addr, u64 *q_offset)
return -EINVAL; return -EINVAL;
} }
int ipz_queue_ctor(struct ipz_queue *queue, #if PAGE_SHIFT < EHCA_PAGESHIFT
const u32 nr_of_pages, #error Kernel pages must be at least as large than eHCA pages (4K) !
const u32 pagesize, const u32 qe_size, const u32 nr_of_sg) #endif
/*
* allocate pages for queue:
* outer loop allocates whole kernel pages (page aligned) and
* inner loop divides a kernel page into smaller hca queue pages
*/
static int alloc_queue_pages(struct ipz_queue *queue, const u32 nr_of_pages)
{ {
int pages_per_kpage = PAGE_SIZE >> EHCA_PAGESHIFT; int k, f = 0;
int f; u8 *kpage;
if (pagesize > PAGE_SIZE) {
ehca_gen_err("FATAL ERROR: pagesize=%x is greater "
"than kernel page size", pagesize);
return 0;
}
if (!pages_per_kpage) {
ehca_gen_err("FATAL ERROR: invalid kernel page size. "
"pages_per_kpage=%x", pages_per_kpage);
return 0;
}
queue->queue_length = nr_of_pages * pagesize;
queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
if (!queue->queue_pages) {
ehca_gen_err("ERROR!! didn't get the memory");
return 0;
}
memset(queue->queue_pages, 0, nr_of_pages * sizeof(void *));
/*
* allocate pages for queue:
* outer loop allocates whole kernel pages (page aligned) and
* inner loop divides a kernel page into smaller hca queue pages
*/
f = 0;
while (f < nr_of_pages) { while (f < nr_of_pages) {
u8 *kpage = (u8 *)get_zeroed_page(GFP_KERNEL); kpage = (u8 *)get_zeroed_page(GFP_KERNEL);
int k;
if (!kpage) if (!kpage)
goto ipz_queue_ctor_exit0; /*NOMEM*/ goto out;
for (k = 0; k < pages_per_kpage && f < nr_of_pages; k++) {
(queue->queue_pages)[f] = (struct ipz_page *)kpage; for (k = 0; k < PAGES_PER_KPAGE && f < nr_of_pages; k++) {
queue->queue_pages[f] = (struct ipz_page *)kpage;
kpage += EHCA_PAGESIZE; kpage += EHCA_PAGESIZE;
f++; f++;
} }
} }
return 1;
queue->current_q_offset = 0; out:
for (f = 0; f < nr_of_pages && queue->queue_pages[f];
f += PAGES_PER_KPAGE)
free_page((unsigned long)(queue->queue_pages)[f]);
return 0;
}
static int alloc_small_queue_page(struct ipz_queue *queue, struct ehca_pd *pd)
{
int order = ilog2(queue->pagesize) - 9;
struct ipz_small_queue_page *page;
unsigned long bit;
mutex_lock(&pd->lock);
if (!list_empty(&pd->free[order]))
page = list_entry(pd->free[order].next,
struct ipz_small_queue_page, list);
else {
page = kmem_cache_zalloc(small_qp_cache, GFP_KERNEL);
if (!page)
goto out;
page->page = get_zeroed_page(GFP_KERNEL);
if (!page->page) {
kmem_cache_free(small_qp_cache, page);
goto out;
}
list_add(&page->list, &pd->free[order]);
}
bit = find_first_zero_bit(page->bitmap, IPZ_SPAGE_PER_KPAGE >> order);
__set_bit(bit, page->bitmap);
page->fill++;
if (page->fill == IPZ_SPAGE_PER_KPAGE >> order)
list_move(&page->list, &pd->full[order]);
mutex_unlock(&pd->lock);
queue->queue_pages[0] = (void *)(page->page | (bit << (order + 9)));
queue->small_page = page;
return 1;
out:
ehca_err(pd->ib_pd.device, "failed to allocate small queue page");
return 0;
}
static void free_small_queue_page(struct ipz_queue *queue, struct ehca_pd *pd)
{
int order = ilog2(queue->pagesize) - 9;
struct ipz_small_queue_page *page = queue->small_page;
unsigned long bit;
int free_page = 0;
bit = ((unsigned long)queue->queue_pages[0] & PAGE_MASK)
>> (order + 9);
mutex_lock(&pd->lock);
__clear_bit(bit, page->bitmap);
page->fill--;
if (page->fill == 0) {
list_del(&page->list);
free_page = 1;
}
if (page->fill == (IPZ_SPAGE_PER_KPAGE >> order) - 1)
/* the page was full until we freed the chunk */
list_move_tail(&page->list, &pd->free[order]);
mutex_unlock(&pd->lock);
if (free_page) {
free_page(page->page);
kmem_cache_free(small_qp_cache, page);
}
}
int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
const u32 nr_of_pages, const u32 pagesize,
const u32 qe_size, const u32 nr_of_sg,
int is_small)
{
if (pagesize > PAGE_SIZE) {
ehca_gen_err("FATAL ERROR: pagesize=%x "
"is greater than kernel page size", pagesize);
return 0;
}
/* init queue fields */
queue->queue_length = nr_of_pages * pagesize;
queue->pagesize = pagesize;
queue->qe_size = qe_size; queue->qe_size = qe_size;
queue->act_nr_of_sg = nr_of_sg; queue->act_nr_of_sg = nr_of_sg;
queue->pagesize = pagesize; queue->current_q_offset = 0;
queue->toggle_state = 1; queue->toggle_state = 1;
return 1; queue->small_page = NULL;
ipz_queue_ctor_exit0: /* allocate queue page pointers */
ehca_gen_err("Couldn't get alloc pages queue=%p f=%x nr_of_pages=%x", queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
queue, f, nr_of_pages); if (!queue->queue_pages) {
for (f = 0; f < nr_of_pages; f += pages_per_kpage) { ehca_gen_err("Couldn't allocate queue page list");
if (!(queue->queue_pages)[f]) return 0;
break;
free_page((unsigned long)(queue->queue_pages)[f]);
} }
memset(queue->queue_pages, 0, nr_of_pages * sizeof(void *));
/* allocate actual queue pages */
if (is_small) {
if (!alloc_small_queue_page(queue, pd))
goto ipz_queue_ctor_exit0;
} else
if (!alloc_queue_pages(queue, nr_of_pages))
goto ipz_queue_ctor_exit0;
return 1;
ipz_queue_ctor_exit0:
ehca_gen_err("Couldn't alloc pages queue=%p "
"nr_of_pages=%x", queue, nr_of_pages);
vfree(queue->queue_pages);
return 0; return 0;
} }
int ipz_queue_dtor(struct ipz_queue *queue) int ipz_queue_dtor(struct ehca_pd *pd, struct ipz_queue *queue)
{ {
int pages_per_kpage = PAGE_SIZE >> EHCA_PAGESHIFT; int i, nr_pages;
int g;
int nr_pages;
if (!queue || !queue->queue_pages) { if (!queue || !queue->queue_pages) {
ehca_gen_dbg("queue or queue_pages is NULL"); ehca_gen_dbg("queue or queue_pages is NULL");
return 0; return 0;
} }
nr_pages = queue->queue_length / queue->pagesize;
for (g = 0; g < nr_pages; g += pages_per_kpage) if (queue->small_page)
free_page((unsigned long)(queue->queue_pages)[g]); free_small_queue_page(queue, pd);
else {
nr_pages = queue->queue_length / queue->pagesize;
for (i = 0; i < nr_pages; i += PAGES_PER_KPAGE)
free_page((unsigned long)queue->queue_pages[i]);
}
vfree(queue->queue_pages); vfree(queue->queue_pages);
return 1; return 1;
} }
int ehca_init_small_qp_cache(void)
{
small_qp_cache = kmem_cache_create("ehca_cache_small_qp",
sizeof(struct ipz_small_queue_page),
0, SLAB_HWCACHE_ALIGN, NULL);
if (!small_qp_cache)
return -ENOMEM;
return 0;
}
void ehca_cleanup_small_qp_cache(void)
{
kmem_cache_destroy(small_qp_cache);
}
...@@ -51,11 +51,25 @@ ...@@ -51,11 +51,25 @@
#include "ehca_tools.h" #include "ehca_tools.h"
#include "ehca_qes.h" #include "ehca_qes.h"
struct ehca_pd;
struct ipz_small_queue_page;
/* struct generic ehca page */ /* struct generic ehca page */
struct ipz_page { struct ipz_page {
u8 entries[EHCA_PAGESIZE]; u8 entries[EHCA_PAGESIZE];
}; };
#define IPZ_SPAGE_PER_KPAGE (PAGE_SIZE / 512)
struct ipz_small_queue_page {
unsigned long page;
unsigned long bitmap[IPZ_SPAGE_PER_KPAGE / BITS_PER_LONG];
int fill;
void *mapped_addr;
u32 mmap_count;
struct list_head list;
};
/* struct generic queue in linux kernel virtual memory (kv) */ /* struct generic queue in linux kernel virtual memory (kv) */
struct ipz_queue { struct ipz_queue {
u64 current_q_offset; /* current queue entry */ u64 current_q_offset; /* current queue entry */
...@@ -66,7 +80,8 @@ struct ipz_queue { ...@@ -66,7 +80,8 @@ struct ipz_queue {
u32 queue_length; /* queue length allocated in bytes */ u32 queue_length; /* queue length allocated in bytes */
u32 pagesize; u32 pagesize;
u32 toggle_state; /* toggle flag - per page */ u32 toggle_state; /* toggle flag - per page */
u32 dummy3; /* 64 bit alignment */ u32 offset; /* save offset within page for small_qp */
struct ipz_small_queue_page *small_page;
}; };
/* /*
...@@ -188,9 +203,10 @@ struct ipz_qpt { ...@@ -188,9 +203,10 @@ struct ipz_qpt {
* see ipz_qpt_ctor() * see ipz_qpt_ctor()
* returns true if ok, false if out of memory * returns true if ok, false if out of memory
*/ */
int ipz_queue_ctor(struct ipz_queue *queue, const u32 nr_of_pages, int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
const u32 pagesize, const u32 qe_size, const u32 nr_of_pages, const u32 pagesize,
const u32 nr_of_sg); const u32 qe_size, const u32 nr_of_sg,
int is_small);
/* /*
* destructor for a ipz_queue_t * destructor for a ipz_queue_t
...@@ -198,7 +214,7 @@ int ipz_queue_ctor(struct ipz_queue *queue, const u32 nr_of_pages, ...@@ -198,7 +214,7 @@ int ipz_queue_ctor(struct ipz_queue *queue, const u32 nr_of_pages,
* see ipz_queue_ctor() * see ipz_queue_ctor()
* returns true if ok, false if queue was NULL-ptr of free failed * returns true if ok, false if queue was NULL-ptr of free failed
*/ */
int ipz_queue_dtor(struct ipz_queue *queue); int ipz_queue_dtor(struct ehca_pd *pd, struct ipz_queue *queue);
/* /*
* constructor for a ipz_qpt_t, * constructor for a ipz_qpt_t,
......
...@@ -14,7 +14,6 @@ ib_ipath-y := \ ...@@ -14,7 +14,6 @@ ib_ipath-y := \
ipath_init_chip.o \ ipath_init_chip.o \
ipath_intr.o \ ipath_intr.o \
ipath_keys.o \ ipath_keys.o \
ipath_layer.o \
ipath_mad.o \ ipath_mad.o \
ipath_mmap.o \ ipath_mmap.o \
ipath_mr.o \ ipath_mr.o \
......
/*
* Copyright (c) 2006, 2007 QLogic Corporation. All rights reserved.
* Copyright (c) 2003, 2004, 2005, 2006 PathScale, Inc. All rights reserved.
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
* General Public License (GPL) Version 2, available from the file
* COPYING in the main directory of this source tree, or the
* OpenIB.org BSD license below:
*
* Redistribution and use in source and binary forms, with or
* without modification, are permitted provided that the following
* conditions are met:
*
* - Redistributions of source code must retain the above
* copyright notice, this list of conditions and the following
* disclaimer.
*
* - Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
/*
* These are the routines used by layered drivers, currently just the
* layered ethernet driver and verbs layer.
*/
#include <linux/io.h>
#include <asm/byteorder.h>
#include "ipath_kernel.h"
#include "ipath_layer.h"
#include "ipath_verbs.h"
#include "ipath_common.h"
/* Acquire before ipath_devs_lock. */
static DEFINE_MUTEX(ipath_layer_mutex);
u16 ipath_layer_rcv_opcode;
static int (*layer_intr)(void *, u32);
static int (*layer_rcv)(void *, void *, struct sk_buff *);
static int (*layer_rcv_lid)(void *, void *);
static void *(*layer_add_one)(int, struct ipath_devdata *);
static void (*layer_remove_one)(void *);
int __ipath_layer_intr(struct ipath_devdata *dd, u32 arg)
{
int ret = -ENODEV;
if (dd->ipath_layer.l_arg && layer_intr)
ret = layer_intr(dd->ipath_layer.l_arg, arg);
return ret;
}
int ipath_layer_intr(struct ipath_devdata *dd, u32 arg)
{
int ret;
mutex_lock(&ipath_layer_mutex);
ret = __ipath_layer_intr(dd, arg);
mutex_unlock(&ipath_layer_mutex);
return ret;
}
int __ipath_layer_rcv(struct ipath_devdata *dd, void *hdr,
struct sk_buff *skb)
{
int ret = -ENODEV;
if (dd->ipath_layer.l_arg && layer_rcv)
ret = layer_rcv(dd->ipath_layer.l_arg, hdr, skb);
return ret;
}
int __ipath_layer_rcv_lid(struct ipath_devdata *dd, void *hdr)
{
int ret = -ENODEV;
if (dd->ipath_layer.l_arg && layer_rcv_lid)
ret = layer_rcv_lid(dd->ipath_layer.l_arg, hdr);
return ret;
}
void ipath_layer_lid_changed(struct ipath_devdata *dd)
{
mutex_lock(&ipath_layer_mutex);
if (dd->ipath_layer.l_arg && layer_intr)
layer_intr(dd->ipath_layer.l_arg, IPATH_LAYER_INT_LID);
mutex_unlock(&ipath_layer_mutex);
}
void ipath_layer_add(struct ipath_devdata *dd)
{
mutex_lock(&ipath_layer_mutex);
if (layer_add_one)
dd->ipath_layer.l_arg =
layer_add_one(dd->ipath_unit, dd);
mutex_unlock(&ipath_layer_mutex);
}
void ipath_layer_remove(struct ipath_devdata *dd)
{
mutex_lock(&ipath_layer_mutex);
if (dd->ipath_layer.l_arg && layer_remove_one) {
layer_remove_one(dd->ipath_layer.l_arg);
dd->ipath_layer.l_arg = NULL;
}
mutex_unlock(&ipath_layer_mutex);
}
int ipath_layer_register(void *(*l_add)(int, struct ipath_devdata *),
void (*l_remove)(void *),
int (*l_intr)(void *, u32),
int (*l_rcv)(void *, void *, struct sk_buff *),
u16 l_rcv_opcode,
int (*l_rcv_lid)(void *, void *))
{
struct ipath_devdata *dd, *tmp;
unsigned long flags;
mutex_lock(&ipath_layer_mutex);
layer_add_one = l_add;
layer_remove_one = l_remove;
layer_intr = l_intr;
layer_rcv = l_rcv;
layer_rcv_lid = l_rcv_lid;
ipath_layer_rcv_opcode = l_rcv_opcode;
spin_lock_irqsave(&ipath_devs_lock, flags);
list_for_each_entry_safe(dd, tmp, &ipath_dev_list, ipath_list) {
if (!(dd->ipath_flags & IPATH_INITTED))
continue;
if (dd->ipath_layer.l_arg)
continue;
spin_unlock_irqrestore(&ipath_devs_lock, flags);
dd->ipath_layer.l_arg = l_add(dd->ipath_unit, dd);
spin_lock_irqsave(&ipath_devs_lock, flags);
}
spin_unlock_irqrestore(&ipath_devs_lock, flags);
mutex_unlock(&ipath_layer_mutex);
return 0;
}
EXPORT_SYMBOL_GPL(ipath_layer_register);
void ipath_layer_unregister(void)
{
struct ipath_devdata *dd, *tmp;
unsigned long flags;
mutex_lock(&ipath_layer_mutex);
spin_lock_irqsave(&ipath_devs_lock, flags);
list_for_each_entry_safe(dd, tmp, &ipath_dev_list, ipath_list) {
if (dd->ipath_layer.l_arg && layer_remove_one) {
spin_unlock_irqrestore(&ipath_devs_lock, flags);
layer_remove_one(dd->ipath_layer.l_arg);
spin_lock_irqsave(&ipath_devs_lock, flags);
dd->ipath_layer.l_arg = NULL;
}
}
spin_unlock_irqrestore(&ipath_devs_lock, flags);
layer_add_one = NULL;
layer_remove_one = NULL;
layer_intr = NULL;
layer_rcv = NULL;
layer_rcv_lid = NULL;
mutex_unlock(&ipath_layer_mutex);
}
EXPORT_SYMBOL_GPL(ipath_layer_unregister);
int ipath_layer_open(struct ipath_devdata *dd, u32 * pktmax)
{
int ret;
u32 intval = 0;
mutex_lock(&ipath_layer_mutex);
if (!dd->ipath_layer.l_arg) {
ret = -EINVAL;
goto bail;
}
ret = ipath_setrcvhdrsize(dd, IPATH_HEADER_QUEUE_WORDS);
if (ret < 0)
goto bail;
*pktmax = dd->ipath_ibmaxlen;
if (*dd->ipath_statusp & IPATH_STATUS_IB_READY)
intval |= IPATH_LAYER_INT_IF_UP;
if (dd->ipath_lid)
intval |= IPATH_LAYER_INT_LID;
if (dd->ipath_mlid)
intval |= IPATH_LAYER_INT_BCAST;
/*
* do this on open, in case low level is already up and
* just layered driver was reloaded, etc.
*/
if (intval)
layer_intr(dd->ipath_layer.l_arg, intval);
ret = 0;
bail:
mutex_unlock(&ipath_layer_mutex);
return ret;
}
EXPORT_SYMBOL_GPL(ipath_layer_open);
u16 ipath_layer_get_lid(struct ipath_devdata *dd)
{
return dd->ipath_lid;
}
EXPORT_SYMBOL_GPL(ipath_layer_get_lid);
/**
* ipath_layer_get_mac - get the MAC address
* @dd: the infinipath device
* @mac: the MAC is put here
*
* This is the EUID-64 OUI octets (top 3), then
* skip the next 2 (which should both be zero or 0xff).
* The returned MAC is in network order
* mac points to at least 6 bytes of buffer
* We assume that by the time the LID is set, that the GUID is as valid
* as it's ever going to be, rather than adding yet another status bit.
*/
int ipath_layer_get_mac(struct ipath_devdata *dd, u8 * mac)
{
u8 *guid;
guid = (u8 *) &dd->ipath_guid;
mac[0] = guid[0];
mac[1] = guid[1];
mac[2] = guid[2];
mac[3] = guid[5];
mac[4] = guid[6];
mac[5] = guid[7];
if ((guid[3] || guid[4]) && !(guid[3] == 0xff && guid[4] == 0xff))
ipath_dbg("Warning, guid bytes 3 and 4 not 0 or 0xffff: "
"%x %x\n", guid[3], guid[4]);
return 0;
}
EXPORT_SYMBOL_GPL(ipath_layer_get_mac);
u16 ipath_layer_get_bcast(struct ipath_devdata *dd)
{
return dd->ipath_mlid;
}
EXPORT_SYMBOL_GPL(ipath_layer_get_bcast);
int ipath_layer_send_hdr(struct ipath_devdata *dd, struct ether_header *hdr)
{
int ret = 0;
u32 __iomem *piobuf;
u32 plen, *uhdr;
size_t count;
__be16 vlsllnh;
if (!(dd->ipath_flags & IPATH_RCVHDRSZ_SET)) {
ipath_dbg("send while not open\n");
ret = -EINVAL;
} else
if ((dd->ipath_flags & (IPATH_LINKUNK | IPATH_LINKDOWN)) ||
dd->ipath_lid == 0) {
/*
* lid check is for when sma hasn't yet configured
*/
ret = -ENETDOWN;
ipath_cdbg(VERBOSE, "send while not ready, "
"mylid=%u, flags=0x%x\n",
dd->ipath_lid, dd->ipath_flags);
}
vlsllnh = *((__be16 *) hdr);
if (vlsllnh != htons(IPATH_LRH_BTH)) {
ipath_dbg("Warning: lrh[0] wrong (%x, not %x); "
"not sending\n", be16_to_cpu(vlsllnh),
IPATH_LRH_BTH);
ret = -EINVAL;
}
if (ret)
goto done;
/* Get a PIO buffer to use. */
piobuf = ipath_getpiobuf(dd, NULL);
if (piobuf == NULL) {
ret = -EBUSY;
goto done;
}
plen = (sizeof(*hdr) >> 2); /* actual length */
ipath_cdbg(EPKT, "0x%x+1w pio %p\n", plen, piobuf);
writeq(plen+1, piobuf); /* len (+1 for pad) to pbc, no flags */
ipath_flush_wc();
piobuf += 2;
uhdr = (u32 *)hdr;
count = plen-1; /* amount we can copy before trigger word */
__iowrite32_copy(piobuf, uhdr, count);
ipath_flush_wc();
__raw_writel(uhdr[count], piobuf + count);
ipath_flush_wc(); /* ensure it's sent, now */
ipath_stats.sps_ether_spkts++; /* ether packet sent */
done:
return ret;
}
EXPORT_SYMBOL_GPL(ipath_layer_send_hdr);
int ipath_layer_set_piointbufavail_int(struct ipath_devdata *dd)
{
set_bit(IPATH_S_PIOINTBUFAVAIL, &dd->ipath_sendctrl);
ipath_write_kreg(dd, dd->ipath_kregs->kr_sendctrl,
dd->ipath_sendctrl);
return 0;
}
EXPORT_SYMBOL_GPL(ipath_layer_set_piointbufavail_int);
/*
* Copyright (c) 2006, 2007 QLogic Corporation. All rights reserved.
* Copyright (c) 2003, 2004, 2005, 2006 PathScale, Inc. All rights reserved.
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
* General Public License (GPL) Version 2, available from the file
* COPYING in the main directory of this source tree, or the
* OpenIB.org BSD license below:
*
* Redistribution and use in source and binary forms, with or
* without modification, are permitted provided that the following
* conditions are met:
*
* - Redistributions of source code must retain the above
* copyright notice, this list of conditions and the following
* disclaimer.
*
* - Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
#ifndef _IPATH_LAYER_H
#define _IPATH_LAYER_H
/*
* This header file is for symbols shared between the infinipath driver
* and drivers layered upon it (such as ipath).
*/
struct sk_buff;
struct ipath_devdata;
struct ether_header;
int ipath_layer_register(void *(*l_add)(int, struct ipath_devdata *),
void (*l_remove)(void *),
int (*l_intr)(void *, u32),
int (*l_rcv)(void *, void *,
struct sk_buff *),
u16 rcv_opcode,
int (*l_rcv_lid)(void *, void *));
void ipath_layer_unregister(void);
int ipath_layer_open(struct ipath_devdata *, u32 * pktmax);
u16 ipath_layer_get_lid(struct ipath_devdata *dd);
int ipath_layer_get_mac(struct ipath_devdata *dd, u8 *);
u16 ipath_layer_get_bcast(struct ipath_devdata *dd);
int ipath_layer_send_hdr(struct ipath_devdata *dd,
struct ether_header *hdr);
int ipath_layer_set_piointbufavail_int(struct ipath_devdata *dd);
/* ipath_ether interrupt values */
#define IPATH_LAYER_INT_IF_UP 0x2
#define IPATH_LAYER_INT_IF_DOWN 0x4
#define IPATH_LAYER_INT_LID 0x8
#define IPATH_LAYER_INT_SEND_CONTINUE 0x10
#define IPATH_LAYER_INT_BCAST 0x40
extern unsigned ipath_debug; /* debugging bit mask */
#endif /* _IPATH_LAYER_H */
...@@ -42,8 +42,6 @@ ...@@ -42,8 +42,6 @@
#include <rdma/ib_pack.h> #include <rdma/ib_pack.h>
#include <rdma/ib_user_verbs.h> #include <rdma/ib_user_verbs.h>
#include "ipath_layer.h"
#define IPATH_MAX_RDMA_ATOMIC 4 #define IPATH_MAX_RDMA_ATOMIC 4
#define QPN_MAX (1 << 24) #define QPN_MAX (1 << 24)
......
...@@ -415,9 +415,11 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd, ...@@ -415,9 +415,11 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
return 0; return 0;
err_wrid: err_wrid:
if (pd->uobject && !init_attr->srq) if (pd->uobject) {
mlx4_ib_db_unmap_user(to_mucontext(pd->uobject->context), &qp->db); if (!init_attr->srq)
else { mlx4_ib_db_unmap_user(to_mucontext(pd->uobject->context),
&qp->db);
} else {
kfree(qp->sq.wrid); kfree(qp->sq.wrid);
kfree(qp->rq.wrid); kfree(qp->rq.wrid);
} }
...@@ -742,7 +744,7 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp, ...@@ -742,7 +744,7 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp,
if (attr->path_mtu < IB_MTU_256 || attr->path_mtu > IB_MTU_4096) { if (attr->path_mtu < IB_MTU_256 || attr->path_mtu > IB_MTU_4096) {
printk(KERN_ERR "path MTU (%u) is invalid\n", printk(KERN_ERR "path MTU (%u) is invalid\n",
attr->path_mtu); attr->path_mtu);
return -EINVAL; goto out;
} }
context->mtu_msgmax = (attr->path_mtu << 5) | 31; context->mtu_msgmax = (attr->path_mtu << 5) | 31;
} }
...@@ -781,10 +783,8 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp, ...@@ -781,10 +783,8 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp,
if (attr_mask & IB_QP_AV) { if (attr_mask & IB_QP_AV) {
if (mlx4_set_path(dev, &attr->ah_attr, &context->pri_path, if (mlx4_set_path(dev, &attr->ah_attr, &context->pri_path,
attr_mask & IB_QP_PORT ? attr->port_num : qp->port)) { attr_mask & IB_QP_PORT ? attr->port_num : qp->port))
err = -EINVAL;
goto out; goto out;
}
optpar |= (MLX4_QP_OPTPAR_PRIMARY_ADDR_PATH | optpar |= (MLX4_QP_OPTPAR_PRIMARY_ADDR_PATH |
MLX4_QP_OPTPAR_SCHED_QUEUE); MLX4_QP_OPTPAR_SCHED_QUEUE);
...@@ -798,15 +798,15 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp, ...@@ -798,15 +798,15 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp,
if (attr_mask & IB_QP_ALT_PATH) { if (attr_mask & IB_QP_ALT_PATH) {
if (attr->alt_port_num == 0 || if (attr->alt_port_num == 0 ||
attr->alt_port_num > dev->dev->caps.num_ports) attr->alt_port_num > dev->dev->caps.num_ports)
return -EINVAL; goto out;
if (attr->alt_pkey_index >= if (attr->alt_pkey_index >=
dev->dev->caps.pkey_table_len[attr->alt_port_num]) dev->dev->caps.pkey_table_len[attr->alt_port_num])
return -EINVAL; goto out;
if (mlx4_set_path(dev, &attr->alt_ah_attr, &context->alt_path, if (mlx4_set_path(dev, &attr->alt_ah_attr, &context->alt_path,
attr->alt_port_num)) attr->alt_port_num))
return -EINVAL; goto out;
context->alt_path.pkey_index = attr->alt_pkey_index; context->alt_path.pkey_index = attr->alt_pkey_index;
context->alt_path.ackto = attr->alt_timeout << 3; context->alt_path.ackto = attr->alt_timeout << 3;
......
...@@ -357,8 +357,6 @@ void mthca_cmd_event(struct mthca_dev *dev, ...@@ -357,8 +357,6 @@ void mthca_cmd_event(struct mthca_dev *dev,
context->status = status; context->status = status;
context->out_param = out_param; context->out_param = out_param;
context->token += dev->cmd.token_mask + 1;
complete(&context->done); complete(&context->done);
} }
...@@ -380,6 +378,7 @@ static int mthca_cmd_wait(struct mthca_dev *dev, ...@@ -380,6 +378,7 @@ static int mthca_cmd_wait(struct mthca_dev *dev,
spin_lock(&dev->cmd.context_lock); spin_lock(&dev->cmd.context_lock);
BUG_ON(dev->cmd.free_head < 0); BUG_ON(dev->cmd.free_head < 0);
context = &dev->cmd.context[dev->cmd.free_head]; context = &dev->cmd.context[dev->cmd.free_head];
context->token += dev->cmd.token_mask + 1;
dev->cmd.free_head = context->next; dev->cmd.free_head = context->next;
spin_unlock(&dev->cmd.context_lock); spin_unlock(&dev->cmd.context_lock);
......
...@@ -246,8 +246,6 @@ void mlx4_cmd_event(struct mlx4_dev *dev, u16 token, u8 status, u64 out_param) ...@@ -246,8 +246,6 @@ void mlx4_cmd_event(struct mlx4_dev *dev, u16 token, u8 status, u64 out_param)
context->result = mlx4_status_to_errno(status); context->result = mlx4_status_to_errno(status);
context->out_param = out_param; context->out_param = out_param;
context->token += priv->cmd.token_mask + 1;
complete(&context->done); complete(&context->done);
} }
...@@ -264,6 +262,7 @@ static int mlx4_cmd_wait(struct mlx4_dev *dev, u64 in_param, u64 *out_param, ...@@ -264,6 +262,7 @@ static int mlx4_cmd_wait(struct mlx4_dev *dev, u64 in_param, u64 *out_param,
spin_lock(&cmd->context_lock); spin_lock(&cmd->context_lock);
BUG_ON(cmd->free_head < 0); BUG_ON(cmd->free_head < 0);
context = &cmd->context[cmd->free_head]; context = &cmd->context[cmd->free_head];
context->token += cmd->token_mask + 1;
cmd->free_head = context->next; cmd->free_head = context->next;
spin_unlock(&cmd->context_lock); spin_unlock(&cmd->context_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment