Commit a84f273c authored by Gavin Shan's avatar Gavin Shan Committed by Benjamin Herrenschmidt

powerpc/eeh: Cleanup for EEH core

Cleanup on EEH core to remove unnecessary whitespaces.
Signed-off-by: default avatarGavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 87b4e539
...@@ -368,7 +368,7 @@ int eeh_dev_check_failure(struct eeh_dev *edev) ...@@ -368,7 +368,7 @@ int eeh_dev_check_failure(struct eeh_dev *edev)
} }
eeh_stats.slot_resets++; eeh_stats.slot_resets++;
/* Avoid repeated reports of this failure, including problems /* Avoid repeated reports of this failure, including problems
* with other functions on this device, and functions under * with other functions on this device, and functions under
* bridges. * bridges.
...@@ -525,7 +525,7 @@ static void eeh_reset_pe_once(struct eeh_pe *pe) ...@@ -525,7 +525,7 @@ static void eeh_reset_pe_once(struct eeh_pe *pe)
* or a fundamental reset (3). * or a fundamental reset (3).
* A fundamental reset required by any device under * A fundamental reset required by any device under
* Partitionable Endpoint trumps hot-reset. * Partitionable Endpoint trumps hot-reset.
*/ */
eeh_pe_dev_traverse(pe, eeh_set_dev_freset, &freset); eeh_pe_dev_traverse(pe, eeh_set_dev_freset, &freset);
if (freset) if (freset)
...@@ -538,8 +538,8 @@ static void eeh_reset_pe_once(struct eeh_pe *pe) ...@@ -538,8 +538,8 @@ static void eeh_reset_pe_once(struct eeh_pe *pe)
*/ */
#define PCI_BUS_RST_HOLD_TIME_MSEC 250 #define PCI_BUS_RST_HOLD_TIME_MSEC 250
msleep(PCI_BUS_RST_HOLD_TIME_MSEC); msleep(PCI_BUS_RST_HOLD_TIME_MSEC);
/* We might get hit with another EEH freeze as soon as the /* We might get hit with another EEH freeze as soon as the
* pci slot reset line is dropped. Make sure we don't miss * pci slot reset line is dropped. Make sure we don't miss
* these, and clear the flag now. * these, and clear the flag now.
*/ */
...@@ -604,7 +604,7 @@ void eeh_save_bars(struct eeh_dev *edev) ...@@ -604,7 +604,7 @@ void eeh_save_bars(struct eeh_dev *edev)
if (!edev) if (!edev)
return; return;
dn = eeh_dev_to_of_node(edev); dn = eeh_dev_to_of_node(edev);
for (i = 0; i < 16; i++) for (i = 0; i < 16; i++)
eeh_ops->read_config(dn, i * 4, 4, &edev->config_space[i]); eeh_ops->read_config(dn, i * 4, 4, &edev->config_space[i]);
} }
...@@ -803,12 +803,12 @@ void eeh_add_device_tree_late(struct pci_bus *bus) ...@@ -803,12 +803,12 @@ void eeh_add_device_tree_late(struct pci_bus *bus)
struct pci_dev *dev; struct pci_dev *dev;
list_for_each_entry(dev, &bus->devices, bus_list) { list_for_each_entry(dev, &bus->devices, bus_list) {
eeh_add_device_late(dev); eeh_add_device_late(dev);
if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) { if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
struct pci_bus *subbus = dev->subordinate; struct pci_bus *subbus = dev->subordinate;
if (subbus) if (subbus)
eeh_add_device_tree_late(subbus); eeh_add_device_tree_late(subbus);
} }
} }
} }
EXPORT_SYMBOL_GPL(eeh_add_device_tree_late); EXPORT_SYMBOL_GPL(eeh_add_device_tree_late);
......
...@@ -154,9 +154,9 @@ static void eeh_enable_irq(struct pci_dev *dev) ...@@ -154,9 +154,9 @@ static void eeh_enable_irq(struct pci_dev *dev)
* eeh_report_error - Report pci error to each device driver * eeh_report_error - Report pci error to each device driver
* @data: eeh device * @data: eeh device
* @userdata: return value * @userdata: return value
* *
* Report an EEH error to each device driver, collect up and * Report an EEH error to each device driver, collect up and
* merge the device driver responses. Cumulative response * merge the device driver responses. Cumulative response
* passed back in "userdata". * passed back in "userdata".
*/ */
static void *eeh_report_error(void *data, void *userdata) static void *eeh_report_error(void *data, void *userdata)
...@@ -376,9 +376,9 @@ static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus) ...@@ -376,9 +376,9 @@ static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus)
eeh_pe_restore_bars(pe); eeh_pe_restore_bars(pe);
/* Give the system 5 seconds to finish running the user-space /* Give the system 5 seconds to finish running the user-space
* hotplug shutdown scripts, e.g. ifdown for ethernet. Yes, * hotplug shutdown scripts, e.g. ifdown for ethernet. Yes,
* this is a hack, but if we don't do this, and try to bring * this is a hack, but if we don't do this, and try to bring
* the device up before the scripts have taken it down, * the device up before the scripts have taken it down,
* potentially weird things happen. * potentially weird things happen.
*/ */
if (bus) { if (bus) {
...@@ -520,7 +520,7 @@ void eeh_handle_event(struct eeh_pe *pe) ...@@ -520,7 +520,7 @@ void eeh_handle_event(struct eeh_pe *pe)
eeh_pe_dev_traverse(pe, eeh_report_resume, NULL); eeh_pe_dev_traverse(pe, eeh_report_resume, NULL);
return; return;
excess_failures: excess_failures:
/* /*
* About 90% of all real-life EEH failures in the field * About 90% of all real-life EEH failures in the field
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment