Commit b27d8517 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Torvalds

gpio: pca953x: tighten up indentation

There is no need to split some of the lines.  However, improve the style
of multi-line comment.  On top of this there is no need to have double
space.

Correct above indentation issues without altering the functionality.

Link: http://lkml.kernel.org/r/20191022172922.61232-12-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Yury Norov <yury.norov@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 35d13d94
...@@ -421,7 +421,9 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off) ...@@ -421,7 +421,9 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off)
ret = regmap_read(chip->regmap, inreg, &reg_val); ret = regmap_read(chip->regmap, inreg, &reg_val);
mutex_unlock(&chip->i2c_lock); mutex_unlock(&chip->i2c_lock);
if (ret < 0) { if (ret < 0) {
/* NOTE: diagnostic already emitted; that's all we should /*
* NOTE:
* diagnostic already emitted; that's all we should
* do unless gpio_*_value_cansleep() calls become different * do unless gpio_*_value_cansleep() calls become different
* from their nonsleeping siblings (and report faults). * from their nonsleeping siblings (and report faults).
*/ */
...@@ -736,8 +738,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid) ...@@ -736,8 +738,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static int pca953x_irq_setup(struct pca953x_chip *chip, static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
int irq_base)
{ {
struct i2c_client *client = chip->client; struct i2c_client *client = chip->client;
struct irq_chip *irq_chip = &chip->irq_chip; struct irq_chip *irq_chip = &chip->irq_chip;
...@@ -787,9 +788,9 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, ...@@ -787,9 +788,9 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
irq_chip->irq_set_type = pca953x_irq_set_type; irq_chip->irq_set_type = pca953x_irq_set_type;
irq_chip->irq_shutdown = pca953x_irq_shutdown; irq_chip->irq_shutdown = pca953x_irq_shutdown;
ret = gpiochip_irqchip_add_nested(&chip->gpio_chip, irq_chip, ret = gpiochip_irqchip_add_nested(&chip->gpio_chip, irq_chip,
irq_base, handle_simple_irq, irq_base, handle_simple_irq,
IRQ_TYPE_NONE); IRQ_TYPE_NONE);
if (ret) { if (ret) {
dev_err(&client->dev, dev_err(&client->dev,
"could not connect irqchip to gpiochip\n"); "could not connect irqchip to gpiochip\n");
...@@ -863,7 +864,7 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert) ...@@ -863,7 +864,7 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert)
static const struct of_device_id pca953x_dt_ids[]; static const struct of_device_id pca953x_dt_ids[];
static int pca953x_probe(struct i2c_client *client, static int pca953x_probe(struct i2c_client *client,
const struct i2c_device_id *i2c_id) const struct i2c_device_id *i2c_id)
{ {
struct pca953x_platform_data *pdata; struct pca953x_platform_data *pdata;
struct pca953x_chip *chip; struct pca953x_chip *chip;
...@@ -872,8 +873,7 @@ static int pca953x_probe(struct i2c_client *client, ...@@ -872,8 +873,7 @@ static int pca953x_probe(struct i2c_client *client,
u32 invert = 0; u32 invert = 0;
struct regulator *reg; struct regulator *reg;
chip = devm_kzalloc(&client->dev, chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
sizeof(struct pca953x_chip), GFP_KERNEL);
if (chip == NULL) if (chip == NULL)
return -ENOMEM; return -ENOMEM;
...@@ -987,7 +987,7 @@ static int pca953x_probe(struct i2c_client *client, ...@@ -987,7 +987,7 @@ static int pca953x_probe(struct i2c_client *client,
if (pdata && pdata->setup) { if (pdata && pdata->setup) {
ret = pdata->setup(client, chip->gpio_chip.base, ret = pdata->setup(client, chip->gpio_chip.base,
chip->gpio_chip.ngpio, pdata->context); chip->gpio_chip.ngpio, pdata->context);
if (ret < 0) if (ret < 0)
dev_warn(&client->dev, "setup failed, %d\n", ret); dev_warn(&client->dev, "setup failed, %d\n", ret);
} }
...@@ -1007,7 +1007,7 @@ static int pca953x_remove(struct i2c_client *client) ...@@ -1007,7 +1007,7 @@ static int pca953x_remove(struct i2c_client *client)
if (pdata && pdata->teardown) { if (pdata && pdata->teardown) {
ret = pdata->teardown(client, chip->gpio_chip.base, ret = pdata->teardown(client, chip->gpio_chip.base,
chip->gpio_chip.ngpio, pdata->context); chip->gpio_chip.ngpio, pdata->context);
if (ret < 0) if (ret < 0)
dev_err(&client->dev, "teardown failed, %d\n", ret); dev_err(&client->dev, "teardown failed, %d\n", ret);
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment