Commit b53046cb authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Lee Jones

mfd: ucb1x00: Remove NO_IRQ check

probe_irq_off() returns '0' on failure, not NO_IRQ, so the check
in this driver is clearly wrong. This replaces it with the
regular '!irq' check used in other drivers.

The sa1100 platform that this driver is used on originally numbered
all its interrupts starting at '0', which would have conflicted with
this change, but as of commit 18f3aec3 ("ARM: 8230/1: sa1100: shift
IRQs by one"), this is not a problem any more.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent bab1e0c0
...@@ -537,7 +537,7 @@ static int ucb1x00_probe(struct mcp *mcp) ...@@ -537,7 +537,7 @@ static int ucb1x00_probe(struct mcp *mcp)
ucb1x00_enable(ucb); ucb1x00_enable(ucb);
ucb->irq = ucb1x00_detect_irq(ucb); ucb->irq = ucb1x00_detect_irq(ucb);
ucb1x00_disable(ucb); ucb1x00_disable(ucb);
if (ucb->irq == NO_IRQ) { if (!ucb->irq) {
dev_err(&ucb->dev, "IRQ probe failed\n"); dev_err(&ucb->dev, "IRQ probe failed\n");
ret = -ENODEV; ret = -ENODEV;
goto err_no_irq; goto err_no_irq;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment