Commit c5a4a91d authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (lm63) Convert to use devm_ functions

Convert to use devm_ functions to reduce code size and simplify the code.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
parent 647ff514
...@@ -1108,11 +1108,9 @@ static int lm63_probe(struct i2c_client *client, ...@@ -1108,11 +1108,9 @@ static int lm63_probe(struct i2c_client *client,
struct lm63_data *data; struct lm63_data *data;
int err; int err;
data = kzalloc(sizeof(struct lm63_data), GFP_KERNEL); data = devm_kzalloc(&client->dev, sizeof(struct lm63_data), GFP_KERNEL);
if (!data) { if (!data)
err = -ENOMEM; return -ENOMEM;
goto exit;
}
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0; data->valid = 0;
...@@ -1129,7 +1127,7 @@ static int lm63_probe(struct i2c_client *client, ...@@ -1129,7 +1127,7 @@ static int lm63_probe(struct i2c_client *client,
/* Register sysfs hooks */ /* Register sysfs hooks */
err = sysfs_create_group(&client->dev.kobj, &lm63_group); err = sysfs_create_group(&client->dev.kobj, &lm63_group);
if (err) if (err)
goto exit_free; return err;
if (data->config & 0x04) { /* tachometer enabled */ if (data->config & 0x04) { /* tachometer enabled */
err = sysfs_create_group(&client->dev.kobj, &lm63_group_fan1); err = sysfs_create_group(&client->dev.kobj, &lm63_group_fan1);
if (err) if (err)
...@@ -1161,9 +1159,6 @@ static int lm63_probe(struct i2c_client *client, ...@@ -1161,9 +1159,6 @@ static int lm63_probe(struct i2c_client *client,
device_remove_file(&client->dev, &dev_attr_temp2_type); device_remove_file(&client->dev, &dev_attr_temp2_type);
sysfs_remove_group(&client->dev.kobj, &lm63_group_extra_lut); sysfs_remove_group(&client->dev.kobj, &lm63_group_extra_lut);
} }
exit_free:
kfree(data);
exit:
return err; return err;
} }
...@@ -1179,7 +1174,6 @@ static int lm63_remove(struct i2c_client *client) ...@@ -1179,7 +1174,6 @@ static int lm63_remove(struct i2c_client *client)
sysfs_remove_group(&client->dev.kobj, &lm63_group_extra_lut); sysfs_remove_group(&client->dev.kobj, &lm63_group_extra_lut);
} }
kfree(data);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment