regulator: Fix regression due to NULL constraints check
The commit [39f802d6: 'regulator: Build sysfs entries with static attribute groups'] converted the sysfs entry creation to static attribute groups, but this resulted in a regression due to the NULL check of rdev->constraints. At the point where the device is registered, rdev->constraints isn't set, so the attributes depending on it are missing. We may fix it by shuffling the code order in regulator_register(), but a quicker fix is to just remove this NULL check. rdev->constraints is in anyway always set to non-NULL in set_machine_constraints(), thus the check there is basically superfluous. Fixes: 39f802d6 ('regulator: Build sysfs entries with static attribute groups') Signed-off-by:Takashi Iwai <tiwai@suse.de> Reportded-by:
Steve Twiss <stwiss.opensource@diasemi.com> Tested-by:
Steve Twiss <stwiss.opensource@diasemi.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
Showing
Please register or sign in to comment