[PATCH] Make the v850 leds driver's seek routine always return a value

Make the v850 leds driver's seek routine always return a value

[PATCH] Make the v850 leds driver's seek routine always return a value
Make the v850 leds driver's seek routine always return a value
d4b1dfa6 · Miles Bader · Linus Torvalds · bbd128b7 · d4b1dfa6
Commit d4b1dfa6 authored Nov 26, 2002 by Miles Bader Committed by Linus Torvalds Nov 26, 2002
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

arch/v850/kernel/rte_cb_leds.c arch/v850/kernel/rte_cb_leds.c +5 -3

No files found.
--- a/arch/v850/kernel/rte_cb_leds.c
+++ b/arch/v850/kernel/rte_cb_leds.c
@@ -109,10 +109,12 @@ static loff_t leds_dev_lseek (struct file *file, loff_t offs, int whence)
 	else if (whence == 2)
 		offs += LED_NUM_DIGITS; /* end-relative */

-	if (offs >= 0 && offs <= LED_NUM_DIGITS)
-		file->f_pos = offs;
-	else
+	if (offs < 0 || offs > LED_NUM_DIGITS)
 		return -EINVAL;
+
+	file->f_pos = offs;
+
+	return 0;
 }

 static struct file_operations leds_fops = {