Commit daad52c8 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

media: drxk_hard: check if parameter is not NULL

There is a smatch warning:
	drivers/media/dvb-frontends/drxk_hard.c: drivers/media/dvb-frontends/drxk_hard.c:1478 scu_command() error: we previously assumed 'parameter' could be null (see line 1467)

Telling that parameter might be NULL. Well, it can't, due to the
way the driver works, but it doesn't hurt to add a check, in order
to shut up smatch.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent e7121ab4
...@@ -1474,9 +1474,11 @@ static int scu_command(struct drxk_state *state, ...@@ -1474,9 +1474,11 @@ static int scu_command(struct drxk_state *state,
/* assume that the command register is ready /* assume that the command register is ready
since it is checked afterwards */ since it is checked afterwards */
for (ii = parameter_len - 1; ii >= 0; ii -= 1) { if (parameter) {
buffer[cnt++] = (parameter[ii] & 0xFF); for (ii = parameter_len - 1; ii >= 0; ii -= 1) {
buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF); buffer[cnt++] = (parameter[ii] & 0xFF);
buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF);
}
} }
buffer[cnt++] = (cmd & 0xFF); buffer[cnt++] = (cmd & 0xFF);
buffer[cnt++] = ((cmd >> 8) & 0xFF); buffer[cnt++] = ((cmd >> 8) & 0xFF);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment