Commit e3303268 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown

ASoC: soc-core: don't use soc_find_component() at snd_soc_find_dai()

commit b9f2e25c ("ASoC: soc-core: use soc_find_component() at
snd_soc_find_dai()") used soc_find_component() at snd_soc_find_dai(),
but, some CPU driver has CPU component for DAI and Platform component,
for example generic DMAEngine component.
In such case, CPU component and Platform component have same
of_node / name.

Here soc_find_component() returns *1st* found component.
Thus, we shouldn't use soc_find_component() at snd_soc_find_dai().
This patch fixup this it, and add comment to indicate this limitation.

Fixes: commit b9f2e25c ("ASoC: soc-core: use soc_find_component() at snd_soc_find_dai()")
Reported-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reported-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 526a6d45
...@@ -786,6 +786,14 @@ static struct snd_soc_component *soc_find_component( ...@@ -786,6 +786,14 @@ static struct snd_soc_component *soc_find_component(
lockdep_assert_held(&client_mutex); lockdep_assert_held(&client_mutex);
/*
* NOTE
*
* It returns *1st* found component, but some driver
* has few components by same of_node/name
* ex)
* CPU component and generic DMAEngine component
*/
for_each_component(component) for_each_component(component)
if (snd_soc_is_matching_component(dlc, component)) if (snd_soc_is_matching_component(dlc, component))
return component; return component;
...@@ -813,8 +821,9 @@ struct snd_soc_dai *snd_soc_find_dai( ...@@ -813,8 +821,9 @@ struct snd_soc_dai *snd_soc_find_dai(
lockdep_assert_held(&client_mutex); lockdep_assert_held(&client_mutex);
/* Find CPU DAI from registered DAIs */ /* Find CPU DAI from registered DAIs */
component = soc_find_component(dlc); for_each_component(component) {
if (component) { if (!snd_soc_is_matching_component(dlc, component))
continue;
for_each_component_dais(component, dai) { for_each_component_dais(component, dai) {
if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
&& (!dai->driver->name && (!dai->driver->name
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment