Commit e78c420b authored by Brian Foster's avatar Brian Foster Committed by Ben Myers

xfs: fix potential infinite loop in xfs_iomap_prealloc_size()

If freesp == 0, we could end up in an infinite loop while squashing
the preallocation. Break the loop when we've killed the prealloc
entirely.
Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent 6dbe51c2
...@@ -413,7 +413,7 @@ xfs_iomap_prealloc_size( ...@@ -413,7 +413,7 @@ xfs_iomap_prealloc_size(
* have a large file on a small filesystem and the above * have a large file on a small filesystem and the above
* lowspace thresholds are smaller than MAXEXTLEN. * lowspace thresholds are smaller than MAXEXTLEN.
*/ */
while (alloc_blocks >= freesp) while (alloc_blocks && alloc_blocks >= freesp)
alloc_blocks >>= 4; alloc_blocks >>= 4;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment