Commit e9aeabae authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville

mac80211: validate SIOCSIWPOWER arguments better

Don't accept any arguments we don't handle, and return error codes
instead of using an uninitialised stack value.
Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Reviewed-by: default avatarKalle Valo <kalle.valo@nokia.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4797938c
...@@ -853,9 +853,12 @@ static int ieee80211_ioctl_siwpower(struct net_device *dev, ...@@ -853,9 +853,12 @@ static int ieee80211_ioctl_siwpower(struct net_device *dev,
ps = true; ps = true;
break; break;
default: /* Otherwise we ignore */ default: /* Otherwise we ignore */
break; return -EINVAL;
} }
if (wrq->flags & ~(IW_POWER_MODE | IW_POWER_TIMEOUT))
return -EINVAL;
if (wrq->flags & IW_POWER_TIMEOUT) if (wrq->flags & IW_POWER_TIMEOUT)
timeout = wrq->value / 1000; timeout = wrq->value / 1000;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment