Commit eb87868a authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski

ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5260

Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and
generates an error:
	genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68)

The GIC requires shared interrupts to be edge rising or level high.
Platform declares support for both.  Arbitrarily choose level high
everywhere hoping it will work on each platform.
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reported-by: default avatarAlban Browaeys <alban.browaeys@gmail.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAlim Akhtar <alim.akhtar@samsung.com>
parent 6abdf8d1
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
*/ */
#include <dt-bindings/clock/exynos5260-clk.h> #include <dt-bindings/clock/exynos5260-clk.h>
#include <dt-bindings/interrupt-controller/irq.h>
/ { / {
compatible = "samsung,exynos5260", "samsung,exynos5"; compatible = "samsung,exynos5260", "samsung,exynos5";
...@@ -181,10 +182,18 @@ mct: mct@100B0000 { ...@@ -181,10 +182,18 @@ mct: mct@100B0000 {
reg = <0x100B0000 0x1000>; reg = <0x100B0000 0x1000>;
clocks = <&fin_pll>, <&clock_peri PERI_CLK_MCT>; clocks = <&fin_pll>, <&clock_peri PERI_CLK_MCT>;
clock-names = "fin_pll", "mct"; clock-names = "fin_pll", "mct";
interrupts = <0 104 0>, <0 105 0>, <0 106 0>, interrupts = <0 104 IRQ_TYPE_LEVEL_HIGH>,
<0 107 0>, <0 122 0>, <0 123 0>, <0 105 IRQ_TYPE_LEVEL_HIGH>,
<0 124 0>, <0 125 0>, <0 126 0>, <0 106 IRQ_TYPE_LEVEL_HIGH>,
<0 127 0>, <0 128 0>, <0 129 0>; <0 107 IRQ_TYPE_LEVEL_HIGH>,
<0 122 IRQ_TYPE_LEVEL_HIGH>,
<0 123 IRQ_TYPE_LEVEL_HIGH>,
<0 124 IRQ_TYPE_LEVEL_HIGH>,
<0 125 IRQ_TYPE_LEVEL_HIGH>,
<0 126 IRQ_TYPE_LEVEL_HIGH>,
<0 127 IRQ_TYPE_LEVEL_HIGH>,
<0 128 IRQ_TYPE_LEVEL_HIGH>,
<0 129 IRQ_TYPE_LEVEL_HIGH>;
}; };
cci: cci@10F00000 { cci: cci@10F00000 {
...@@ -210,25 +219,25 @@ cci_control1: slave-if@5000 { ...@@ -210,25 +219,25 @@ cci_control1: slave-if@5000 {
pinctrl_0: pinctrl@11600000 { pinctrl_0: pinctrl@11600000 {
compatible = "samsung,exynos5260-pinctrl"; compatible = "samsung,exynos5260-pinctrl";
reg = <0x11600000 0x1000>; reg = <0x11600000 0x1000>;
interrupts = <0 79 0>; interrupts = <0 79 IRQ_TYPE_LEVEL_HIGH>;
wakeup-interrupt-controller { wakeup-interrupt-controller {
compatible = "samsung,exynos4210-wakeup-eint"; compatible = "samsung,exynos4210-wakeup-eint";
interrupt-parent = <&gic>; interrupt-parent = <&gic>;
interrupts = <0 32 0>; interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>;
}; };
}; };
pinctrl_1: pinctrl@12290000 { pinctrl_1: pinctrl@12290000 {
compatible = "samsung,exynos5260-pinctrl"; compatible = "samsung,exynos5260-pinctrl";
reg = <0x12290000 0x1000>; reg = <0x12290000 0x1000>;
interrupts = <0 157 0>; interrupts = <0 157 IRQ_TYPE_LEVEL_HIGH>;
}; };
pinctrl_2: pinctrl@128B0000 { pinctrl_2: pinctrl@128B0000 {
compatible = "samsung,exynos5260-pinctrl"; compatible = "samsung,exynos5260-pinctrl";
reg = <0x128B0000 0x1000>; reg = <0x128B0000 0x1000>;
interrupts = <0 243 0>; interrupts = <0 243 IRQ_TYPE_LEVEL_HIGH>;
}; };
pmu_system_controller: system-controller@10D50000 { pmu_system_controller: system-controller@10D50000 {
...@@ -239,7 +248,7 @@ pmu_system_controller: system-controller@10D50000 { ...@@ -239,7 +248,7 @@ pmu_system_controller: system-controller@10D50000 {
uart0: serial@12C00000 { uart0: serial@12C00000 {
compatible = "samsung,exynos4210-uart"; compatible = "samsung,exynos4210-uart";
reg = <0x12C00000 0x100>; reg = <0x12C00000 0x100>;
interrupts = <0 146 0>; interrupts = <0 146 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock_peri PERI_CLK_UART0>, <&clock_peri PERI_SCLK_UART0>; clocks = <&clock_peri PERI_CLK_UART0>, <&clock_peri PERI_SCLK_UART0>;
clock-names = "uart", "clk_uart_baud0"; clock-names = "uart", "clk_uart_baud0";
status = "disabled"; status = "disabled";
...@@ -248,7 +257,7 @@ uart0: serial@12C00000 { ...@@ -248,7 +257,7 @@ uart0: serial@12C00000 {
uart1: serial@12C10000 { uart1: serial@12C10000 {
compatible = "samsung,exynos4210-uart"; compatible = "samsung,exynos4210-uart";
reg = <0x12C10000 0x100>; reg = <0x12C10000 0x100>;
interrupts = <0 147 0>; interrupts = <0 147 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock_peri PERI_CLK_UART1>, <&clock_peri PERI_SCLK_UART1>; clocks = <&clock_peri PERI_CLK_UART1>, <&clock_peri PERI_SCLK_UART1>;
clock-names = "uart", "clk_uart_baud0"; clock-names = "uart", "clk_uart_baud0";
status = "disabled"; status = "disabled";
...@@ -257,7 +266,7 @@ uart1: serial@12C10000 { ...@@ -257,7 +266,7 @@ uart1: serial@12C10000 {
uart2: serial@12C20000 { uart2: serial@12C20000 {
compatible = "samsung,exynos4210-uart"; compatible = "samsung,exynos4210-uart";
reg = <0x12C20000 0x100>; reg = <0x12C20000 0x100>;
interrupts = <0 148 0>; interrupts = <0 148 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock_peri PERI_CLK_UART2>, <&clock_peri PERI_SCLK_UART2>; clocks = <&clock_peri PERI_CLK_UART2>, <&clock_peri PERI_SCLK_UART2>;
clock-names = "uart", "clk_uart_baud0"; clock-names = "uart", "clk_uart_baud0";
status = "disabled"; status = "disabled";
...@@ -266,7 +275,7 @@ uart2: serial@12C20000 { ...@@ -266,7 +275,7 @@ uart2: serial@12C20000 {
uart3: serial@12860000 { uart3: serial@12860000 {
compatible = "samsung,exynos4210-uart"; compatible = "samsung,exynos4210-uart";
reg = <0x12860000 0x100>; reg = <0x12860000 0x100>;
interrupts = <0 145 0>; interrupts = <0 145 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock_aud AUD_CLK_AUD_UART>, <&clock_aud AUD_SCLK_AUD_UART>; clocks = <&clock_aud AUD_CLK_AUD_UART>, <&clock_aud AUD_SCLK_AUD_UART>;
clock-names = "uart", "clk_uart_baud0"; clock-names = "uart", "clk_uart_baud0";
status = "disabled"; status = "disabled";
...@@ -275,7 +284,7 @@ uart3: serial@12860000 { ...@@ -275,7 +284,7 @@ uart3: serial@12860000 {
mmc_0: mmc@12140000 { mmc_0: mmc@12140000 {
compatible = "samsung,exynos5250-dw-mshc"; compatible = "samsung,exynos5250-dw-mshc";
reg = <0x12140000 0x2000>; reg = <0x12140000 0x2000>;
interrupts = <0 156 0>; interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>; #address-cells = <1>;
#size-cells = <0>; #size-cells = <0>;
clocks = <&clock_fsys FSYS_CLK_MMC0>, <&clock_top TOP_SCLK_MMC0>; clocks = <&clock_fsys FSYS_CLK_MMC0>, <&clock_top TOP_SCLK_MMC0>;
...@@ -287,7 +296,7 @@ mmc_0: mmc@12140000 { ...@@ -287,7 +296,7 @@ mmc_0: mmc@12140000 {
mmc_1: mmc@12150000 { mmc_1: mmc@12150000 {
compatible = "samsung,exynos5250-dw-mshc"; compatible = "samsung,exynos5250-dw-mshc";
reg = <0x12150000 0x2000>; reg = <0x12150000 0x2000>;
interrupts = <0 158 0>; interrupts = <0 158 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>; #address-cells = <1>;
#size-cells = <0>; #size-cells = <0>;
clocks = <&clock_fsys FSYS_CLK_MMC1>, <&clock_top TOP_SCLK_MMC1>; clocks = <&clock_fsys FSYS_CLK_MMC1>, <&clock_top TOP_SCLK_MMC1>;
...@@ -299,7 +308,7 @@ mmc_1: mmc@12150000 { ...@@ -299,7 +308,7 @@ mmc_1: mmc@12150000 {
mmc_2: mmc@12160000 { mmc_2: mmc@12160000 {
compatible = "samsung,exynos5250-dw-mshc"; compatible = "samsung,exynos5250-dw-mshc";
reg = <0x12160000 0x2000>; reg = <0x12160000 0x2000>;
interrupts = <0 159 0>; interrupts = <0 159 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>; #address-cells = <1>;
#size-cells = <0>; #size-cells = <0>;
clocks = <&clock_fsys FSYS_CLK_MMC2>, <&clock_top TOP_SCLK_MMC2>; clocks = <&clock_fsys FSYS_CLK_MMC2>, <&clock_top TOP_SCLK_MMC2>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment