Commit f1680565 authored by Sanjeev Chugh's avatar Sanjeev Chugh Committed by Greg Kroah-Hartman

Input: atmel_mxt_ts - don't try to free unallocated kernel memory

commit 1e3c336a upstream.

If the user attempts to update Atmel device with an invalid configuration
cfg file, error handling code is trying to free cfg file memory which is
not allocated yet hence results into kernel crash.

This patch fixes the order of memory free operations.
Signed-off-by: default avatarSanjeev Chugh <sanjeev_chugh@mentor.com>
Fixes: a4891f10 ("Input: atmel_mxt_ts - zero terminate config firmware file")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d648a9bd
...@@ -1586,10 +1586,10 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) ...@@ -1586,10 +1586,10 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw)
/* T7 config may have changed */ /* T7 config may have changed */
mxt_init_t7_power_cfg(data); mxt_init_t7_power_cfg(data);
release_raw:
kfree(cfg.raw);
release_mem: release_mem:
kfree(cfg.mem); kfree(cfg.mem);
release_raw:
kfree(cfg.raw);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment