- 20 Dec, 2013 1 commit
-
-
John Stultz authored
Prior to subitting this, Colin reworked the compat_ioctl support for the ion_test driver, moving the structure to be the same size on both 32 and 64 bit architectures. Two small things were left out. The compat_ioctl ptr assignment, and the fact that despite having uniform sized types in the structure, the structure pads out to different sizes on different arches. This patch resolves this issue by adding a padding entry after the write flag, and adding the compat_ioctl ptr. Changes in v2: - Add a padding int rather then making write a u64 Acked-by:
Colin Cross <ccross@android.com> Cc: Android Kernel Team <kernel-team@android.com> Signed-off-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 19 Dec, 2013 8 commits
-
-
Masanari Iida authored
This patch fixed trailing whitespace found by checkpatch.pl within dgap_trace.c Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Gokulnath A authored
Fixed all the line over 80 characters warning found by checkpatch.pl script. Signed-off-by:
Gokulnath A <Gokulnath.Avanashilingam@in.bosch.com> Signed-off-by:
-
Gokulnath A authored
Removed the developer debug prints BCM_DEBUG_PRINT() as per the TODO list, also removed braces for the if-statement to match coding style Signed-off-by:
-
Gary Rookard authored
I have deleated some unintelligible comments, and made a few minor white space corrections. Signed-off-by: Gary Alan Rookard Signed-off-by: -
Masanari Iida authored
This patch fixed "ERROR:trailing whitespace found by checkpatch.pl within dgap_tty.c Signed-off-by:
-
Masanari Iida authored
This patch fix "ERROR: trailing whitespace found by checkpatch.pl, whithin downld.c Signed-off-by:
-
Aaron Sierra authored
Signed-off-by:
Aaron Sierra <asierra@xes-inc.com> Signed-off-by:
-
Aaron Sierra authored
Now that the VME userspace API structures compile to a consistent size in mixed environments (32-bit userspace and 64-bit kernel), enable the .compat_ioctl to allow ioctls to execute in this environment. Signed-off-by:
-
- 18 Dec, 2013 9 commits
-
-
Gary Rookard authored
removed C99 comments to follow the linux kernel coding style thus fixing checkpatch errors respectfully. Signed-off-by:
Gary Alan Rookard <garyrookard@gmail.com> Signed-off-by:
-
John Stultz authored
RT_MUTEXES can be configured out of the kernel, causing compile problems with ION. To quote Colin: "rt_mutexes were added with the deferred freeing feature. Heaps need to return zeroed memory to userspace, but zeroing the memory on every allocation was causing performance issues. We added a SCHED_IDLE thread to zero memory in the background after freeing, but locking the heap from the SCHED_IDLE thread might block a high priority allocation thread for a long time. The lock is only used to protect the heap's free_list and free_list_size members, and is not held for any long or sleeping operations. Converting to a spinlock should prevent priority inversion without using the rt_mutex. I'd also rename it to free_lock to so it doesn't get used as a general heap lock." Thus this patch converts the rt_mutex usage to a spinlock and renames the lock free_lock to be more clear as to its use. I also had to change a bit of logic in ion_heap_freelist_drain() to safely avoid list corruption. Acked-by:
Jim Davis <jim.epost@gmail.com> Signed-off-by:
-
Matthias Wirth authored
These two macros needed reformatting but as they are not used anywhere we just removed them. Signed-off-by:
Matthias Wirth <matthias.wirth@gmail.com> Signed-off-by:
Lukas Senger <lukas@fridolin.com> Signed-off-by:
-
Matthias Wirth authored
Signed-off-by:
-
Matthias Wirth authored
Signed-off-by:
-
Eli Billauer authored
This patch replicates the correction made by Wei Yongjun on a second occurrence of the same bug. The first correction was in commit 8eec4555. Bug fixed: The error code was not set, so the error condition wasn't reflected in the return value. Reported-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
-
Alan authored
Scan only to the length permitted by the buffer One of a set of sscanf problems noted by Jackie Chang Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Aaron Sierra authored
This patch updates the vme_master and vme_slave structures to use types with well defined size and to prevent the compiler from inserting padding (between enable and vme_addr for one). The original vme_master and vme_slave structs would be different sizes and have different layouts depending on whether they were built for a 32-bit or 64-bit system. On x86 it is possible to have a 32-bit userspace and a 64-bit kernel. In this type of environment, the userspace and kernel vme_user APIs would disagree and prevent ioctls from executing (based on ioctl signatures from _IOR and _IOW). Signed-off-by:
Martyn Welch <martyn.welch@ge.com> Signed-off-by:
-
Aaron Sierra authored
Previously, VME bridge support was treated as any other driver (using module_init() macro), but if VME bridge and vme_user (staging) drivers were compiled into the kernel, then vme_user would attempt to register itself before the VME core support had been loaded. This would result in a kernel panic. The load order of these built-in drivers is based on the order in which drivers/staging/vme and driver/vme are compiled. This patch changes the VME core driver to use the subsys_initcall() macro which ensures that it is loaded before all other VME drivers regardless of the order in which they are compiled. Tested-by:
-
- 17 Dec, 2013 22 commits
-
-
Bernd Porr authored
If the channel list is not set in userspace we get an error at PTR_ERR(async->cmd.chanlist). However, do_become_nonbusy(dev, s) cleans up this pointer which causes a kernel ooops. Setting the channel list in async to NULL and checking this in do_become_nonbusy prevents the oops. [Ian Abbott] Also do the same for the chanlist allocated in do_cmdtest_ioctl(). Signed-off-by:
Bernd Porr <mail@berndporr.me.uk> Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Masanari Iida authored
Correct spelling typo in comment and printk. Signed-off-by:
-
Malcolm Priestley authored
White space and commented out code. Camel case clean up. pDevice -> priv uConnectionChannel -> connection_channel Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Ian Abbott authored
When a dynamically created comedi device is being automatically removed by a call to `comedi_auto_unconfig()` from the lower level driver, `comedi_device_cleanup()` is called to perform the detachment from the lower level driver. If the comedi device is open at the time, `dev->use_count` will be the the number of outstanding opens. The function currently decrements the the module counts of the "comedi" module and the low-level driver module by this amount and reduces `dev->use_count` to zero. There are various problems with this as the `release` file operation handler `comedi_close()` also decrements `dev->use_count` and decrements the module usage counts. This means that `dev->use_count` and the module counts can end up negative. Also, the assumed one-to-one relationship between the file open count and the low-level module usage count is invalid and can get screwed up. We only want to stop the low-level module being unloaded while a comedi device using the module has an open file object. Also, there is no need to manipulate the module count of the core "comedi" module at all since the comedi module is the owner of the file operations structure and the system will not unload the module while there are open file objects using it. Correct the bugs and simplify as follows: 1. Get rid of the module count manipulations of the core "comedi" module (`THIS_MODULE`) altogether. 2. Don't alter `dev->use_count` in `comedi_device_cleanup()` as it should only be altered by the `open` and `release` file operation handlers `comedi_open()` and `comedi_close()`. 3. Increment the low-level module count for the following reasons: a) In `comedi_open()` if the open count was zero and the comedi device is attached to the low-level driver. b) When the `COMEDI_DEVCONFIG` ioctl is used to manually attach an unattached comedi device to a low-level driver. The open count will be greater than zero at this time. The actual increment of the low-level module count is already done by `comedi_device_attach()`. 4. Decrement the low-level module count for the following reasons: a) In `comedi_close()` if the open count was 1 and the comedi device is attached to the low-level driver. b) In `comedi_device_cleanup()` (called via `comedi_auto_unconfig()` --> `comedi_release_hardware_device()` --> `comedi_free_board_dev()` when the comedi device is automatically unconfigured due to action by the low-level driver) if the device was attached (which it should be) and open count was non-zero (greater than zero). c) When the `COMEDI_DEVCONFIG` ioctl is used to manually detach the comedi device from the low-level driver. The open count will be greater than zero at this time. The open count should never go negative. Parts 3 and 4 ensure that the low-level module usage count is incremented on entering the state where the comedi device is attached to the low-level driver AND the open count is greater than zero, and is decremented on leaving that state. Signed-off-by: -
Ian Abbott authored
When a dynamically allocated `struct comedi_device` gets automatically unconfigured by a call to `comedi_auto_unconfig()` from a lower-level driver's bus removal function (e.g. when a USB device is disconnected), the class device in `dev->class_dev` (where `dev` points to the `struct comedi_device`) is destroyed by a call to `device_destroy()` that matches a previous call to `device_create()`. However, if the `struct comedi_device` is still associated with an open file object, the now invalid `dev->class_dev` pointer may still be passed to `dev_printk()` (via `dev_dbg()` etc.), producing bogus output or worse. To fix this, call `get_device()` on the class device if `device_create()` was successful. Add a matching call to `put_device()` in `comedi_dev_kref_release()` when the `struct comedi_device` is freed. The calls to `dev_dbg()` etc. after the call to `device_destroy()` will still produce valid output, although the device will have been unregistered in sysfs. Signed-off-by:
-
Ivaylo Dimitrov authored
Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by using sscanf. Signed-off-by:
Ivaylo Dimitrov <freemangordon@abv.bg> Signed-off-by:
-
Malcolm Priestley authored
None of these stats reach user. So delete them from driver mib.c and mib.h becomes dead code as result of this patch. Signed-off-by:
-
Malcolm Priestley authored
As result of patch staging: vt6656: Remove unused scStatistic data from driver. mib.c mic.h is dead code Signed-off-by:
-
Paul Gortmaker authored
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by:
Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:
-
Steven Luo authored
Commit 559c71fe ("Staging: TIDSPBRIDGE: Use vm_iomap_memory for mmap-ing instead of remap_pfn_range") had the effect of inadvertently shifting the start of the physical memory area mapped by pdata->phys_mempool_base. Correct this by subtracting that shift before calling vm_iomap_memory() and adding it back afterwards. Reported-by:
Dheeraj CVR <cvr.dheeraj@gmail.com> Signed-off-by:
-
ZHAO Gang authored
Let all the code use a pointer called tx_ring to access struct tx_ring members. Signed-off-by:
ZHAO Gang <gamerh2o@gmail.com> Acked-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
ZHAO Gang authored
Let all the code use a pointer called rx_ring to access struct rx_ring members. Signed-off-by:
-
H Hartley Sweeten authored
The comedi_lrange tables are fixed length based on the 'length' value before the array of comedi_krange 'range' values. For aesthetics, remove the trailing comma from last 'range' value. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
-
H Hartley Sweeten authored
Tidy up the format of the comedi_lrange table. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the format of the comedi_lrange table. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE macro instead of the more generic RANGE macro to reduce the potential for typos. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the whitespace in the comedi_lrange tables. Signed-off-by:
-
