1. 31 May, 2006 22 commits
    • Tejun Heo's avatar
      [PATCH] libata-hp: implement hotplug · 084fe639
      Tejun Heo authored
      Implement ATA part of hotplug.  To avoid probing broken devices over
      and over again, disabled devices are not automatically detached.  They
      are detached only if probing is requested for the device or the
      associated port is offline.  Also, to avoid infinite probing loop,
      Each device is probed only once per EH run.
      
      As SATA PHY status is fragile, devices are detached only after it has
      used up its recovery chances unless explicitly requested by LLDD or
      user (LLDD may request direct detach if, for example, it supports cold
      presence detection).
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      084fe639
    • Tejun Heo's avatar
      [PATCH] libata-hp: implement ata_eh_detach_dev() · 0ea035a3
      Tejun Heo authored
      Implement ata_eh_detach_dev().  This function is responsible for
      detaching an ATA device and offlining the associated SCSI device
      atomically so that the detached device is not accessed after ATA
      detach is complete.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      0ea035a3
    • Tejun Heo's avatar
      [PATCH] sata_sil24: update sil24_hardreset() · e8e008e7
      Tejun Heo authored
      Use phy debouncing instead of unconditional wait after DEV_RST and
      make sil24_hardreset() to request followup SRST as that's the only way
      to wait for !BSY.  Note that the original implementation never worked
      - if the cached status was !BSY, ata_busy_sleep() finished
      immediately; otherwise, it timed out regardless of the actual device
      status.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      e8e008e7
    • Tejun Heo's avatar
      [PATCH] sata_sil24: rename PORT_PRB to PORT_LRAM and add PORT_LRAM_SLOT_SZ · 135da345
      Tejun Heo authored
      PORT_PRB is a misnomer as the area also contains other stuff.  Rename
      it to PORT_LRAM and add PORT_LRAM_SLOT_SZ.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      135da345
    • Tejun Heo's avatar
      [PATCH] sata_sil: new interrupt handler · cbe88fbc
      Tejun Heo authored
      The DMA complete bit of these controllers reflects ATA IRQ status
      while no DMA command is in progress.  So, we can tell whether the
      controller is raising an interrupt or not in deterministic manner.
      This patch gives sata_sil its own interrupt handler which behaves much
      better than the original one in terms of error detection and handling.
      This change is also necessary for later hotplug support.
      
      Further improvements are possible, in both 2 and 4 ports versions, we
      can get all status with only one readl and using custom bmdma
      operations can further cut down register accesses.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      cbe88fbc
    • Tejun Heo's avatar
      [PATCH] sata_sil: add new constants in preparation for new interrupt handler · 20888d83
      Tejun Heo authored
      sata_sil is about to get a brand new interrupt handler.  Add relevant
      constants.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      20888d83
    • Tejun Heo's avatar
      [PATCH] libata: export ata_hsm_move() · 9a1004d0
      Tejun Heo authored
      ata_hsm_move() will be used by LLDDs which depend on standard PIO HSM
      but implement their own interrupt handlers.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      9a1004d0
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: implement followup softreset handling · 664faf09
      Tejun Heo authored
      In some cases, hardreset must be followed by SRST.
      
      * some controllers can't classify with hardreset
      * some controllers can't wait for !BSY after hardreset (LLDD should
        explicitly request followup softreset by returning -EAGAIN)
      * (later) PM needs SRST w/ PMP==15 to operate after hardreset
      
      To handle above cases, this patch implements follow-up softreset.
      After a hardreset, ata_eh_reset() checks whether any of above
      conditions are met and do a follow-up softreset if necessary.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      664faf09
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: add prereset() method and implement ata_std_prereset() · f5914a46
      Tejun Heo authored
      With hotplug, every reset might be a probing reset and thus something
      similar to probe_init() is needed.  prereset() method is called before
      a series of resets to a port and is the counterpart of postreset().
      prereset() can tell EH to use different type of reset or skip reset by
      modifying ehc->i.action.
      
      This patch also implements ata_std_prereset().  Most controllers
      should be able to use this function directly or with some wrapping.
      After hotplug, different controllers need different actions to resume
      the PHY and detect the newly attached device.  Controllers can be
      categorized as follows.
      
      * Controllers which can wait for the first D2H FIS after hotplug.
        Note that if the waiting is implemented by polling TF status, there
        needs to be a way to set BSY on PHY status change.  It can be
        implemented by hardware or with the help of the driver.
      
      * Controllers which can wait for the first D2H FIS after sending
        COMRESET.  These controllers need to issue COMRESET to wait for the
        first FIS.  Note that the received D2H FIS could be the first D2H
        FIS after POR (power-on-reset) or D2H FIS in response to the
        COMRESET.  Some controllers use COMRESET as TF status
        synchronization point and clear TF automatically (sata_sil).
      
      * Controllers which cannot wait for the first D2H FIS reliably.
        Blindly issuing SRST to spinning-up device often results in command
        issue failure or timeout, causing extended delay.  For these
        controllers, ata_std_prereset() explicitly waits ATA_SPINUP_WAIT
        (currently 8s) to give newly attached device time to spin up, then
        issues reset.  Note that failing to getting ready in ATA_SPINUP_WAIT
        is not critical.  libata will retry.  So, the timeout needs to be
        long enough to spin up most devices.
      
      LLDDs can tell ata_std_prereset() which of above action is needed with
      ATA_FLAG_HRST_TO_RESUME and ATA_FLAG_SKIP_D2H_BSY flags.  These flags
      are PHY-specific property and will be moved to ata_link later.
      
      While at it, this patch unifies function typedef's such that they all
      have named arguments.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      f5914a46
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: implement sata_phy_debounce() · d7bb4cc7
      Tejun Heo authored
      With hotplug, PHY always needs to be debounced before a reset as any
      reset might find new devices.  Extract PHY waiting code from
      sata_phy_resume() and extend it to include SStatus debouncing.  Note
      that sata_phy_debounce() is superset of what used to be done inside
      sata_phy_resume().
      
      Three default debounce timing parameters are defined to be used by
      hot/boot plug.  As resume failure during probing will be properly
      handled as errors, timeout doesn't have to be long as before.
      probeinit() uses the same timeout to retain the original behavior.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      d7bb4cc7
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: make probing related functions global · a9beec95
      Tejun Heo authored
      Hotplug will be implemented in libata-eh.c.  Make ata_dev_read_id()
      and ata_dev_configure() global.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      a9beec95
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: add ata_aux_wq · 453b07ac
      Tejun Heo authored
      It's best to run ATA hotplug from EH but attaching SCSI devices needs
      working EH.  ata_aux_wq is used to give SCSI hotplug operations a
      separate context.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      453b07ac
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: store attached SCSI device · 3edebac4
      Tejun Heo authored
      Add device persistent field dev->sdev and store the attached SCSI
      device.  With hotplug, libata needs to know the attached SCSI device
      to offline and detach it, but scsi_device_lookup() cannot be used
      because libata will reuse SCSI ID numbers - dead but not gone devices
      (due to zombie opens, etc...) interfere with the lookup.
      
      dev->sdev doesn't hold reference to the SCSI device.  It's cleared
      when the SCSI device goes away.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      3edebac4
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: implement ap->hw_sata_spd_limit · 5a04bf4b
      Tejun Heo authored
      Add ap->hw_sata_spd_limit and initialize it once during the boot
      initialization (or driver load initialization).  ap->sata_spd_limit is
      reset to ap->hw_sata_spd_limit on hotplug.  This prevents spd limits
      introduced by earlier devices from affecting new devices.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      5a04bf4b
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: use __ata_scsi_find_dev() · 31534363
      Tejun Heo authored
      Convert direct sdev -> dev lookup to __ata_scsi_find_dev().
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      31534363
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: update ata_scsi_find_dev() and friends · ab5b3a5b
      Tejun Heo authored
      Separate out ata_find_dev() and __ata_scsi_find_dev() from
      ata_scsi_find_dev().  These will be used by later hotplug
      implementation.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      ab5b3a5b
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: make some ata_device fields persistent · 72fa4b74
      Tejun Heo authored
      Lifetimes of some fields span over device plugging/unplugging.  This
      patch moves such persistent fields to the top of ata_device and
      separate them with ATA_DEVICE_CLEAR_OFFSET.  Fields above the offset
      are initialized once during host initializatino while all other fields
      are cleared before hotplugging.  Currently ->ap, devno and part of
      flags are persistent.
      
      Note that flags is partially cleared while holding host_set lock.
      This is to synchronize with later warm plug implementation which will
      record hotplug request in dev->flags.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      72fa4b74
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: implement ata_dev_init() · 3ef3b43d
      Tejun Heo authored
      Move initialization of struct ata_device into ata_dev_init() in
      preparation for hotplug.  This patch calls ata_dev_init() from
      ata_host_init() and thus makes no functional difference.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      3ef3b43d
    • Tejun Heo's avatar
      [PATCH] libata-hp-prep: add flags and eh_info/context fields for hotplug · abdda733
      Tejun Heo authored
      Add hotplug related flags and eh_info/context fields.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      abdda733
    • Tejun Heo's avatar
      [PATCH] libata: implement ata_eh_wait() · c6cf9e99
      Tejun Heo authored
      Implement ata_eh_wait().  On return from this function, it's
      guaranteed that the EH which was pending or in progress when the
      function was called is complete - including the tailing part of SCSI
      EH.  This will be used by hotplug and others to synchronize with EH.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      c6cf9e99
    • Tejun Heo's avatar
      [PATCH] libata: shift host flag constants · 7395acb2
      Tejun Heo authored
      Nudge host flag constants to make a room after ATA_FLAG_EH_PENDING.
      New EH flag will be added.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      7395acb2
    • Tejun Heo's avatar
      [PATCH] libata: set PIO-0 after successful EH reset · 20952b69
      Tejun Heo authored
      Set ata_device->pio_mode to XFER_PIO_0 after a successful reset.  This
      is to keep EH resets consistent with probe resets as updated by the
      commit b6079ca4.  Note that, with
      soon-to-follow hotplug update, EH resets will include probe resets.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      20952b69
  2. 29 May, 2006 2 commits
    • Borislav Petkov's avatar
      libata debugging: set initial dbg value · ef282407
      Borislav Petkov authored
      This patch sets the prerequisites for the new debugging scheme that more or
      less resembles Donald Becker's net driver example. This one liner doesn't
      change any functionality beside setting the appropriate debug level for the
      msg_enable control in the ata_port struct, which will be later used by the
      ata_msg_* macros to control the amount of debug information sent to printk.
      
      Signed-off-by: <petkov@uni-muenster.de>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      ef282407
    • Jeff Garzik's avatar
      Merge branch 'master' into upstream · 89f8185e
      Jeff Garzik authored
      89f8185e
  3. 28 May, 2006 4 commits
  4. 27 May, 2006 12 commits