1. 01 Dec, 2011 2 commits
    • Sarah Sharp's avatar
      Revert "xHCI: reset-on-resume quirk for NEC uPD720200" · 0de13500
      Sarah Sharp authored
      This reverts commit df711fc9.
      
      The commit added a reset-on-resume quirk because the NEC chipset stopped
      responding to commands about 30 minutes after a system resume from
      suspend.  We thought it was a chipset issue, but it turns out that the
      xHCI driver was zeroing out the link TRB after a successful context
      restore during resume.  The host controller would fall off the command
      ring sometime later, causing it to not respond to new commands.
      
      The link TRB issue has been fixed with commit
      158886cd "xHCI: fix bug in
      xhci_clear_command_ring()", so revert the reset-on-resume quirk, as it's
      not necessary.
      
      Commit df711fc9 was marked for stable
      trees back to 2.6.37, but according to my mail, it has not made it into
      Linus' tree or the stable trees yet.
      Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
      Tested-by: default avatarJulian Sikorski <belegdol@gmail.com>
      Cc: Andiry Xu <andiry.xu@amd.com>
      0de13500
    • Andiry Xu's avatar
      xHCI: fix bug in xhci_clear_command_ring() · 158886cd
      Andiry Xu authored
      When system enters suspend, xHCI driver clears command ring by writing zero
      to all the TRBs. However, this also writes zero to the Link TRB, and the ring
      is mangled. This may cause driver accesses wrong memory address and the
      result is unpredicted.
      
      When clear the command ring, keep the last Link TRB intact, only clear its
      cycle bit. This should fix the "command ring full" issue reported by Oliver
      Neukum.
      
      This should be backported to stable kernels as old as 2.6.37, since the
      commit 89821320 "xhci: Fix command ring replay after resume" is merged.
      Signed-off-by: default avatarAndiry Xu <andiry.xu@amd.com>
      Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
      Reported-by: default avatarOliver Neukum <oneukum@suse.de>
      158886cd
  2. 29 Nov, 2011 13 commits
  3. 28 Nov, 2011 1 commit
  4. 27 Nov, 2011 4 commits
  5. 24 Nov, 2011 6 commits
  6. 23 Nov, 2011 14 commits