- 23 Jan, 2017 2 commits
-
-
Guenter Roeck authored
Since there is no call to dev_get_drvdata() or input_get_drvdata(), the call to input_set_drvdata() is unnecessary and can be dropped. Signed-off-by:
Guenter Roeck <linux@roeck-us.net> Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
Guenter Roeck authored
If there is no call to dev_get_drvdata() or input_get_drvdata(), the call to input_set_drvdata() is unnecessary and can be dropped. Signed-off-by:
-
- 22 Jan, 2017 21 commits
-
-
Marcos Paulo de Souza authored
This can happen in cases like bug #102951[1], so add a proper debug msg as done in wait_read. Also, change wait_read debug message to differ from wait_write. [1] https://bugzilla.kernel.org/show_bug.cgi?id=102951Signed-off-by:
Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by:
-
Dmitry Torokhov authored
Nobody calls input_get_drvdata() so setting it is not required. Signed-off-by: -
Dmitry Torokhov authored
The "atomic" API allows us to configure PWM period and duty cycle and enable it in one call. Reviewed-by:
Thierry Reding <thierry.reding@gmail.com> Tested-by:
David Lechner <david@lechnology.com> Signed-off-by:
-
David Lechner authored
This adds an optional regulator to the pwm-beeper device. This regulator acts as an amplifier. The amplifier is only enabled while beeping in order to reduce power consumption. Tested on LEGO MINDSTORMS EV3, which has a speaker connected to PWM through an amplifier. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
David Lechner authored
This suppress printing an error message when pwm_get returns -EPROBE_DEFER. Otherwise you get a bunch of noise in the kernel log. Signed-off-by:
-
Dmitry Torokhov authored
Usually userspace sends SND_BELL and SND_TONE events, and by the time pwm_beeper_suspend() runs userpsace is already frozen, but theoretically in-kernel users may send these events too, and that may cause pwm_beeper_event() scheduling another work after we canceled it. Let's introduce a "suspended" flag and check it in pwm_beeper_event() to avoid this race. Reviewed-by:
-
Dmitry Torokhov authored
Instead of manipulating capability bits directly, let's use input_set_capability() API. Reviewed-by:
-
Dmitry Torokhov authored
Use of managed resources (devm) simplifies error handling and tear down of the driver. Reviewed-by:
-
Dmitry Torokhov authored
There are no more users of pwm-beeper driver in mainline relying on this legacy API, so let's remove it and simplify the driver code. Acked-by:
-
Guenter Roeck authored
Empty remove functions don't serve a useful purpose and can be removed. Signed-off-by:
-
Guenter Roeck authored
Calling device_init_wakeup in the remove function is unnecessary since the device is going away, and thus won't be able to cause any wakeups under any circumstances. Besides, the driver cleanup code already handles the necessary cleanup. Similarly, disabling wakeup in the probe error path is unnecessary, as is disabling wakeup in the probe function in the first place. Signed-off-by:
-
Guenter Roeck authored
Calling device_init_wakeup in the remove function is unnecessary since the device is going away, and thus won't be able to cause any wakeups under any circumstances. Besides, the driver cleanup code already handles the necessary cleanup. Similarly, disabling wakeup in the probe error path is unnecessary, as is disabling wakeup in the probe function in the first place. Signed-off-by:
-
Guenter Roeck authored
Calling device_init_wakeup in the remove function is unnecessary since the device is going away, and thus won't be able to cause any wakeups under any circumstances. Besides, the driver cleanup code already handles the necessary cleanup. Similarly, disabling wakeup in the probe error path is unnecessary, as is disabling wakeup in the probe function in the first place. Signed-off-by:
-
Guenter Roeck authored
Calling device_init_wakeup in the remove function is unnecessary since the device is going away, and thus won't be able to cause any wakeups under any circumstances. Besides, the driver cleanup code already handles the necessary cleanup. Similarly, disabling wakeup in the probe error path is unnecessary, as is disabling wakeup in the probe function in the first place. Signed-off-by:
-
Guenter Roeck authored
If a function declares a variable to access a structure element, use it consistently. Signed-off-by:
-
Guenter Roeck authored
If a function declares a variable to access a structure element, use it consistently. Signed-off-by:
-
Guenter Roeck authored
If a function declares a variable to access a structure element, use it consistently. Signed-off-by:
-
Guenter Roeck authored
If a function declares a variable to access a structure element, use it consistently. Signed-off-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata(), platform_get_drvdata(), or dev_get_drvdata() in any of the drivers in this patch. Signed-off-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata(), platform_get_drvdata(), or dev_get_drvdata() in any of the drivers in this patch. Signed-off-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata(), platform_get_drvdata(), or dev_get_drvdata() in any of the drivers in this patch. Signed-off-by:
-
- 21 Jan, 2017 2 commits
-
-
Hans de Goede authored
gpio-keys input devices created by the soc_button_array driver are configured with key-codes based on ACPI provided information. Unfortunately on some tablets this info is wrong, and we need to have a quirk to fix things up. Add support for input_setkeycode to the gpio-keys driver, so that the existing udev hwdb mechanism can be used to fix things up on these tablets. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
Hans de Goede authored
The soc_button_array driver was initializing (kzalloc) the debounce_interval value to 0, leading to no debouncing at all, while the buttons are simple mechanical switches. This commit sets debounce_interval to 50ms to avoid spurious button press reports both on press and release of the button. Note 50ms may seem like a lot but soc_button_array is typically used with cheap tablets, with not so great buttons. I tried 10ms on my tablet and it is not enough, where as 50ms works well. Signed-off-by:
-
- 18 Jan, 2017 15 commits
-
-
Jaechul Lee authored
This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by:
Beomho Seo <beomho.seo@samsung.com> Signed-off-by:
Jaechul Lee <jcsing.lee@samsung.com> Reviewed-by:
Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by:
Andi Shyti <andi.shyti@samsung.com> Reviewed-by:
Chanwoo Choi <cw00.choi@samsung.com> Tested-by:
Krzysztof Kozlowski <krzk@kernel.org> Acked-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata() or dev_get_drvdata(). Drop the unnecessary call to i2c_set_clientdata(). Signed-off-by:
-
Guenter Roeck authored
There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Signed-off-by:
-
Guenter Roeck authored
There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Signed-off-by:
-
Guenter Roeck authored
There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Signed-off-by:
-
Guenter Roeck authored
There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Also use existing variable 'dev' instead of dereferencing it several times. Signed-off-by:
-
Guenter Roeck authored
Use local variable 'dev' instead of dereferencing it several times. Signed-off-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata() or dev_get_drvdata(). Drop the unnecessary call to i2c_set_clientdata(). Signed-off-by:
-
Guenter Roeck authored
There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Signed-off-by:
-
Guenter Roeck authored
Use local variable 'dev' instead of dereferencing it several times and replace devm_add_action() and manual error handling with devm_add_action_or_reset(). Signed-off-by:
-
Guenter Roeck authored
Replace 'goto l; ... l: return e;' with 'return e;' Signed-off-by:
-
Guenter Roeck authored
Error messages after memory allocation failures are unnecessary and can be dropped, especially give that they were emitted as dev_dbg() so noone except person actively debugging the driver would see them. Signed-off-by:
-
Guenter Roeck authored
There is no call to i2c_get_clientdata() or dev_get_drvdata(). Drop the unnecessary call to i2c_set_clientdata(). Signed-off-by:
-
Guenter Roeck authored
Use local variable 'dev' instead of dereferencing it several times. Signed-off-by:
-
Guenter Roeck authored
Error messages after memory allocation failures are unnecessary and can be dropped, given that they are emitted as dev_dbg() so nobody except person actively debugging the driver would see them. Also replace jump to return 'goto l; ... l: return e;' with 'return e;' Signed-off-by:
-
