- 13 Mar, 2014 13 commits
-
-
Ana Rey authored
This patch fixes whitespaces as the codingStyle of the kernel recommends. Thus, this patch fixes these errors found by checkpatch.pl: ERROR: space required before the open parenthesis '(' ERROR: space required before that '*' (ctx:OxV) ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: Ana Rey <anarey@gmail.com> Reviewed-by: Bob Copeland <me@bobcopeland.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
After the next warning messages by sparse tools: drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:6: warning: symbol 'rtl8225z2_rf_set_mode' was not declared. Should it be static? drivers/staging/rtl8187se/r8180_rtl8225z2.c:609:13: warning: ‘rtl8225z2_rf_set_mode’ defined but not used [-Wunused-function] static void rtl8225z2_rf_set_mode(struct net_device *dev) And the next search: ~/opw/dev/staging/drivers/staging/rtl8187se (staging-next) $ git grep rtl8225z2_rf_set_mode r8180_rtl8225z2.c:void rtl8225z2_rf_set_mode(struct net_device *dev) I decided to delete rtl8225z2_rf_set_mode function. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
This patch deletes all commented code in r8180.h that is not necessary. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this into an enum. While at it, I have also renamed the variable names that were used in this typedef not to use Hungarian notation. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The typedef _LED_CTL_MODE (and the enum constants) is not used in the driver. I delete it. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch fixes the sparse warning - drivers/staging/wlan-ng/p80211netdev.c:289:38: warning: cast to restricted __le16 by eliminating the variable fc as it is not required. Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this to an enum. While at it, I have also renamed the variable names that were used in this typedef not to use Hungarian notation. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this into an enum. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this to enum. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this to enum. While at it, I have also renamed the variable names that were used in this typedef not to use Hungarian notation. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Jérôme Pinot authored
This fixes the following spacing issues detected by checkpatch.pl: WARNING: line over 80 characters #357: FILE: drivers/staging/ozwpan/ozhcd.c:357: +static struct oz_urb_link *oz_uncancel_urb(struct oz_hcd *ozhcd, struct urb *urb) ERROR: trailing whitespace #25: FILE: drivers/staging/ozwpan/ozpd.h:25: +/* $ Signed-off-by: Jerome Pinot <ngc891@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pinot authored
This fixes the following issues detected by checkpatch.pl: WARNING: __constant_cpu_to_le16 should be cpu_to_le16 #1991: FILE: drivers/staging/ozwpan/ozhcd.c:1991: + __constant_cpu_to_le16(0x0001); WARNING: __constant_cpu_to_le32 should be cpu_to_le32 #2185: FILE: drivers/staging/ozwpan/ozhcd.c:2185: + put_unaligned(__constant_cpu_to_le32(0), (__le32 *)buf); WARNING: __constant_htons should be htons #675: FILE: drivers/staging/ozwpan/ozproto.c:675: + binding->ptype.type = __constant_htons(OZ_ETHERTYPE); Signed-off-by: Jerome Pinot <ngc891@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 11 Mar, 2014 15 commits
-
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: expected unsigned int volatile [unsigned] [usertype] pci_start_addr drivers/staging/comedi/drivers/gsc_hpdi.c:367:53: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: expected unsigned int volatile [unsigned] [usertype] local_start_addr drivers/staging/comedi/drivers/gsc_hpdi.c:370:55: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: expected unsigned int volatile [unsigned] [usertype] transfer_size drivers/staging/comedi/drivers/gsc_hpdi.c:371:52: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/gsc_hpdi.c:373:43: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/gsc_hpdi.c:390:39: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/gsc_hpdi.c:704:15: warning: cast to restricted __le32 drivers/staging/comedi/drivers/gsc_hpdi.c:707:15: warning: cast to restricted __le32 drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: expected unsigned int volatile [unsigned] [usertype] pci_start_addr drivers/staging/comedi/drivers/cb_pcidas64.c:1495:56: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr drivers/staging/comedi/drivers/cb_pcidas64.c:1498:66: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr drivers/staging/comedi/drivers/cb_pcidas64.c:1502:66: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: expected unsigned int volatile [unsigned] [usertype] transfer_size drivers/staging/comedi/drivers/cb_pcidas64.c:1505:55: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/cb_pcidas64.c:1506:46: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: expected unsigned int volatile [unsigned] [usertype] pci_start_addr drivers/staging/comedi/drivers/cb_pcidas64.c:1515:64: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: expected unsigned int volatile [unsigned] [usertype] local_start_addr drivers/staging/comedi/drivers/cb_pcidas64.c:1517:66: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: expected unsigned int volatile [unsigned] [usertype] transfer_size drivers/staging/comedi/drivers/cb_pcidas64.c:1520:63: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/cb_pcidas64.c:1521:54: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: expected unsigned int volatile [unsigned] [usertype] transfer_size drivers/staging/comedi/drivers/cb_pcidas64.c:2540:63: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: expected unsigned int volatile [unsigned] [usertype] transfer_size drivers/staging/comedi/drivers/cb_pcidas64.c:2890:58: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:2893:21: warning: cast to restricted __le32 drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/cb_pcidas64.c:2895:49: got restricted __le32 [usertype] <noident> drivers/staging/comedi/drivers/cb_pcidas64.c:2898:21: warning: cast to restricted __le32 drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: expected unsigned int volatile [unsigned] [usertype] next drivers/staging/comedi/drivers/cb_pcidas64.c:2900:54: got restricted __le32 [usertype] <noident> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch solves the warning "possible switch case/default not preceded by break or fallthrough comment" for the file /drivers/staging/dgrp/dgrp_tty.c Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with do not add new typedefs in p80211mgmt.h Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch makes the function _rtl8821ae_map_hwqueue_to_fwqueue static as it is used only in the file trx.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
This patch solves the warning: unchecked sscanf return value from the script checkpatch.pl for the file dgrp_sysfs.c Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch disgards the variable declaration and initialization of rsn_authen_cipher_suite as it is not used anywhere throughout the kernel. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Himangi Saraogi authored
This patch disgards the variable declaration and initialization of rsn_authen_cipher_suite as it is not used in anywhere throughout the kernel. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Jelena Bjelja authored
This patch fixes trailing whitespace error found in ozpd.h Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Andreea-Cristina Bernat authored
Fix checkpatch.pl issue with line over 80. Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Aybuke Ozdemir authored
Fix checkpatch.pl issues with line over 80 characters in xd.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Deleted space between sizeof and open parenthethis. Signed-off-by: Iulia Manda <iulia.manda21@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by: Iulia Manda <iulia.manda21@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Deleted unnecessary braces for single statement if blocks. Signed-off-by: Iulia Manda <iulia.manda21@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Iulia Manda authored
Fix checkpatch.pl warning - else should follow close brace. Signed-off-by: Iulia Manda <iulia.manda21@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Chi Pham authored
Removes assignments from if statements and simplifies unnecessary 0/NULL-checking. The following coccinelle script found the match: @@ expression E0, E1, E2; statement S0; @@ - if (E0 == (E1 = E2)) + E1 = E2; + if (E1 == E0) S0 Signed-off-by: Chi Pham <fempsci@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
- 10 Mar, 2014 5 commits
-
-
Andreea-Cristina Bernat authored
This patch solves the error: that open brace { should be on the previous line. Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Chi Pham authored
The following coccinelle script found the match: @@ expression E0, E1, E2; statement S0, S1; @@ - if ((E1 = E2) != E0) + E1 = E2; + if (E1 != E0) S0 else S1 Signed-off-by: Chi Pham <fempsci@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Monam Agarwal authored
This patch removes unused macro in slicoss.c as mentioned in TODO tasks. Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Chi Pham authored
The following coccinelle script found the match: @@ expression E0, E1, E2; statement S0; @@ - if ((E1 = E2) == E0) + E1 = E2; + if (E1 == E0) S0 Signed-off-by: Chi Pham <fempsci@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
Valentina Manea authored
Since it is needed outside usbcore and exposed in include/linux/usb.h, it conflicts with enum dev_state in rt2x00 wireless driver. Mark it as usb specific to avoid conflicts in the future. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 09 Mar, 2014 7 commits
-
-
Valentina Manea authored
This is an optional dependency since USB/IP can fully work without it. However, it is needed to display device information such as vendor. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
When a device has just been bound to usbip-host but the client hasn't set a configuration on it, certain attributes will not exist. Don't treat this as an error. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
A device should not be able to be used concurrently both by the server and the client. Claiming the port used by the shared device ensures no interface drivers bind to it and that it is not usable from the server. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
A sysfs attribute is used to announce kernel space that a new driver probing session should be triggered for the just unbinded device. In order to have the address of struct device associated to this USB device, a new member has been added to struct bus_id_priv. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
Since usbip-host is now a device driver and the client has full access to the shared device, it makes sense to let the client choose device configuration. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Valentina Manea authored
Add libudev as dependency and remove libsysfs. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-