- 16 Mar, 2017 2 commits
-
-
Okash Khawaja authored
This patch adds spk_io_ops struct which contain those methods whose job is to communicate with synth device. Currently, all comms with external synth device use raw serial i/o. The idea is to group all methods which do the actual communication with external device into this new struct. Then migrating a serial-based synth over to an alternative to raw serial i/o will mean swapping serial spk_io_ops instance with the io_ops instance of the new method, making the migration simpler. At the moment, this struct only contains one method, synth_out but more will be added in future when migrating synths which require input functionality. Also at the moment, synth_out method has one implementation which uses serial i/o. Plan is to add an alternative. Signed-off-by:
Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Okash Khawaja authored
These two functions are always called from a context where spk_synth instance is available. They also use the spk_synth instance but instead of taking it as an argument, they rely on a global spk_synth instance inside synth.c which points to the same synth as the one being passed in as argument. Signed-off-by:
-
- 14 Mar, 2017 30 commits
-
-
Daeseok Youn authored
The dgnc_tty_send_break() has a switch-case condition for msec. It is no use except case -1. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Daeseok Youn authored
The bd variables in functions are already assigned from ch->ch_bd but it is not used in those functions except checking NULL. The ch->ch_bd could be replaced with bd variable. Signed-off-by:
-
Roy Pledge authored
add Roy Pledge as maintainer of DPIO Signed-off-by:
Roy Pledge <Roy.Pledge@nxp.com> Signed-off-by:
Stuart Yoder <stuart.yoder@nxp.com> Signed-off-by:
-
Roy Pledge authored
The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by:
Haiying Wang <haiying.wang@nxp.com> Signed-off-by:
-
Roy Pledge authored
The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notifications are received. Signed-off-by:
-
Roy Pledge authored
Add QBman APIs for frame queue and buffer pool operations. Signed-off-by:
-
Roy Pledge authored
Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by:
-
Roy Pledge authored
Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by:
-
Ioana Radulescu authored
Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
Stuart Yoder authored
add document describing the dpio driver and it's role, components and major interfaces Signed-off-by:
-
Tobin C. Harding authored
Code may be refactored to take advantage of previous patches which reduced the level of indentation. Function parameter line breaks can be adjusted in line with kernel coding standards. Refactor layout of function call parameters. Make whitespace changes only. Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: Too many leading tabs - consider code refactoring. One level of indentation may be removed by inverting an if statement conditional (and returning if new conditional evaluates to true). Code contains switch statement that also contains multiple layers of indentation. Indentation may be reduced by breaking out of the case statement in multiple places instead of guarding code with if/else statements. Invert conditional. Return original error code if new conditional evaluates to true. Break out of case blocks instead of using if/else. Do not modify program logic. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: single byte memset is suspicious. Swapped 2nd/3rd argument? Call site in question is correct but is an unusual use of memset() to zero a single byte. The same can be achieved by assigning 0 directly to the memory location. Dereference pointer and assign 0 to that memory location. Use '\0' to make explicit that it is a char pointer. Signed-off-by:
-
Tobin C. Harding authored
Return value from kmalloc() does not require a cast. Remove unnecessary cast. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: else is not generally useful after a break or return. Two warnings of this type are emitted, both are the result of a else statement after a return statement. The 'else' can safely be removed. Remove unnecessary else statement. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: Comparisons should place the constant on the right side of the test. Move constant to right hand side of test, modify operator to ensure logic is maintained. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits CHECK: multiple assignments should be avoided. Move multiple assignment onto separate lines. Fix comment to use more natural English. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits CHECK: Alignment should match open parenthesis. This is due to commented out code. Remove commented out (dead) code. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits CHECK: Logical continuations should be on the previous line. Move logical continuation to previous line. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits block comments warnings. Change comments blocks to be inline with kernel coding style for networking code. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits over 100 instances of CHECK: No space is necessary after a cast. Remove unnecessary space. Signed-off-by:
-
Tobin C. Harding authored
Driver mixes spelling michael and michel in symbol names and comments. Michael here references the IEEE 802.11i Message Integrity Code. It is incorrect to spell it michel and confusing having two spellings for the same thing. Change michel -> micheal in both symbol names and comments. Signed-off-by:
-
simran singhal authored
Commenting out code is a bad idea. As comments are for explaining what code is about. Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Signed-off-by:
-
Colin Ian King authored
I believe there is a missing break in the switch statement for case V4L2_CID_FOCUS_STATUS as the current fall-through looks suspect to me. Detected by CoverityScan, CID#1416580 ("Missing break in switch") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Colin Ian King authored
There is no need to perform a null check on frame as there is an earlier null check check and return hence making the null check redundant. Remove it. Detected by CoverityScan, CID#1416563 ("Logically Dead Code") Signed-off-by: -
Dan Carpenter authored
md_type is an enum. On my tests, GCC treats it as unsigned but according to the C standard it's an implementation dependant thing so we should check for negatives. Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
simran singhal authored
The function atomisp_set_stop_timeout on being called, simply returns back. The function hasn't been mentioned in the TODO and doesn't have FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been removed. This was done using Coccinelle. @@ identifier f; @@ void f(...) { -return; } Signed-off-by: -
Varsha Rao authored
Remove gc2235_init() function definition and call, as it is used only once in gc2235.c file. Replace the function call with return value, __gc2235_init() function call. Signed-off-by:
Varsha Rao <rvarsha016@gmail.com> Signed-off-by:
-
Varsha Rao authored
Simplify function return by merging assignment and return into a single line. The following coccinelle script is used to fix this issue. @@ expression e; local idexpression ret; @@ -ret = e; -return ret; +return e; This patch also removes unnecessary declarations. Signed-off-by:
-
sayli karnik authored
Bool initializations should use true and false instead of 1 and 0. Detected by coccinelle/misc/boolinit.cocci. Signed-off-by:
sayli karnik <karniksayli1995@gmail.com> Signed-off-by:
-
- 13 Mar, 2017 8 commits
-
-
Aishwarya Pant authored
In bcm2835_audio_open_connection(), if VCHI connection fails or initialisation of VCHI audio instance fails vchi_instance needs to be deallocated otherwise it will cause a memory leak. Signed-off-by:
Aishwarya Pant <aishpant@gmail.com> Signed-off-by:
-
Aishwarya Pant authored
This patch de-allocates work when queue_work(..) fails in the bcm2835-audio work functions Signed-off-by:
-
Aishwarya Pant authored
* Refactor conditional to check if memory allocation has failed and immediately return (-ENOMEM); if block for success case is removed. * Return the error value -EBUSY when queue_work() fails. Signed-off-by:
-
Aishwarya Pant authored
It is better to propagate PTR_ERR value instead of a hardcoded value (-EPERM here) Signed-off-by:
-
Aishwarya Pant authored
This patch replaces NULL values returned by vc_vchi_audio_init(...) with error pointer values: - Return ERR_PTR(-EINVAL) when too many instances of audio service are initialised - Return ERR_PTR(-ENOMEM) when kzalloc fails - RETURN ERR_PTR(-EPERM) when vchi connections fail to open Similarly, a NULL check where vc_vchi_audio_init(...) is called is replaced by IS_ERR(..) Signed-off-by:
-
Aishwarya Pant authored
Replace kmalloc and memset with kzalloc. Signed-off-by:
-
Arushi Singhal authored
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
Arushi Singhal authored
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by:
-
