- 18 Mar, 2014 40 commits
-
-
Tugce Sirin authored
This patch fixes checkpatch.pl error prefer netdev_info to printk in wlan-ng driver. Signed-off-by:
Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tugce Sirin authored
This patch fixes checkpatch.pl error prefer netdev_error to printk in wlan-ng driver. Signed-off-by:
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with printk() should include KERN_ facility level in wb35rx.c Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with line over 80 characters in imx-hdmi.c Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by:
-
Aybuke Ozdemir authored
Fix checkpatch.pl issues with line over 80 characters in imx-ldb.c Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
Monam Agarwal authored
This patch fixes following checkpatch.pl warning: WARNING: unchecked sscanf value in gdm_lte.c Signed-off-by:
Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with no space before tabs in base.c Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/rtl8821ae/rtl8821ae/phy.c:444:39: warning: cast truncates bits from constant value (ffffff01 becomes 1) drivers/staging/rtl8821ae/rtl8821ae/phy.c:445:39: warning: cast truncates bits from constant value (ffffff01 becomes 1) Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with quoted string split across lines in base.c Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with space required before the open parenthesis '(' error in base.c Signed-off-by: -
Gulsah Kose authored
Fix checkpatch.pl issues with do not use C99 // comments in base.c Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with unnecessary whitespace before a quoted newline in base.c Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with code indent should use tabs where possible in base.c Signed-off-by:
-
Aybuke Ozdemir authored
Fix checkpatch.pl issues with line over 80 characters in serqt_usb2.c Signed-off-by:
-
Jelena Bjelja authored
Fix the following sparse warning: drivers/staging/wlags49_h2/wl_netdev.c:533:6: warning: symbol 'wl_poll' was not declared. Should it be static? Signed-off-by:
Jelena Bjelja <jelena.bjelja.ing@gmail.com> Acked-by:
-
Keerthimai Janarthanan authored
Prefer pr_err instead of printk(KERN_ERR) Signed-off-by:
Keerthimai Janarthanan <keerthimaipb@gmail.com> Signed-off-by:
-
Ana Rey authored
Convert from printk functions into netdev_err or netdev_info in ieee80211/dot11d.c Fix checkpatch.pl warning: WARNING: printk() should include KERN_ facility level WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
-
Ana Rey authored
Move export_symbol below its function in ieee80211/dot11d.c Fix checkpatch.pl warning: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by:
-
Ana Rey authored
Remove innecessary spaces and indentation errors in function definition Signed-off-by:
-
Ana Rey authored
Add whitespace in ieee80211/dot11d.c and fix coding style these lines when It is necessary Signed-off-by:
-
Ana Rey authored
Delete unnecesary braces and fix coding style these lines when It is necessary in ieee80211/dot11d.c Fix checkpatch.pl errors: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Ana Rey authored
Move open brace on the previous line and fix coding style in these lines when It is necessary in ieee80211/dot11d.c Fix checkpatch.pl errors: ERROR: that open brace { should be on the previous line Signed-off-by: -
Ana Rey authored
Convert style of comments from C99-style to C89 and fix coding style in these lines when It is necessary. Signed-off-by:
-
Ana Rey authored
Delete all commented code in ieee80211/dot11d.c that are not necessary. Signed-off-by:
-
Himangi Saraogi authored
This patch removes use of explicit extern specifier and quietens the sparse warnings: drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1846:1: warning: function 'dm_change_fsync_setting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1863:1: warning: function 'dm_change_rxpath_selection_setting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2663:13: warning: function 'DM_CTSToSelfSetting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition Signed-off-by:
-
Aybuke Ozdemir authored
The patch fixes the following checkpatch.pl errors: ERROR: that open brace { should be on the previous line. Signed-off-by: -
Chi Pham authored
The following coccinelle script found the match: @simple@ expression E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 ) S1 else S2 @left@ expression E0, E1, E2; statement S0, S1; @@ - if ((E1 = E2) < E0) + E1 = E2; + if (E1 < E0) S1 Signed-off-by:
Chi Pham <fempsci@gmail.com> Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/vt6656/aes_ccmp.c:272:32: warning: restricted __le16 degrades to integer drivers/staging/vt6656/aes_ccmp.c:274:32: warning: restricted __le16 degrades to integer drivers/staging/vt6656/aes_ccmp.c:282:32: warning: restricted __le16 degrades to integer Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/vt6655/wmgr.c:970:42: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:971:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:972:38: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:973:43: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4110:37: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4111:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4112:34: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4113:30: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4114:35: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4123:32: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1815:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1816:34: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1817:30: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1818:35: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:2075:63: warning: Using plain integer as NULL pointer The following coccinelle script was used to achieve this: @rule1@ expression *x; @@ ( - x = 0; + x = NULL; | - (x == 0) + (x == NULL) | - (x != 0) + (x != NULL) ) Signed-off-by:
-
Chi Pham authored
Fixed some minor checkpatch warnings such as whitespace. Coccinelle was used for this patch (NOTE: some of the changes were made by hand). The script is not complete (semantically) and might raise some checkpatch warnings in terms of indentation depending on existing code. *** IFASSIGNMENT.COCCI START *** /* Coccinelle script to handle assignments in if statements * For compound statements, can so far only handle statements with the * assignment on either extreme */ /* This rule is for simple cases * e.g. just an assignment in if, possibly with unary operator */ @simple@ expression E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 ) S1 else S2 /* This rule is for compound statements where the assignment is on the right.*/ @right@ expression E, E1, E2; statement S1, S2; @@ ( /* and */ - if (E && (E1 = E2)) + if (E) { + E1 = E2; + if (E1) S1 else S2 + } else S2 | - if (E && (E1 = E2)) + if (E) { + E1 = E2; + if (E1) S1 + } /* or */ | - if (E || (E1 = E2)) + if (!E) { + E1 = E2; + if (E1) S1 else S2 + } + else S1 | - if (E || (E1 = E2)) + if (!E) { + E1 = E2; + if (E1) S1 + } else S1 /* not equal */ | - if (E != (E1 = E2)) + E1 = E2; + if (E != E1) S1 else S2 | - if (E != (E1 = E2)) + E1 = E2; + if (E != E1) S1 /* equal */ | - if (E == (E1 = E2)) + E1 = E2; + if (E == E1) S1 else S2 | - if (E == (E1 = E2)) + E1 = E2; + if (E == E1) S1 /* greater than */ | - if (E > (E1 = E2)) + E1 = E2; + if (E > E1) S1 else S2 | - if (E > (E1 = E2)) + E1 = E2; + if (E > E1) S1 /* less than */ | - if (E < (E1 = E2)) + E1 = E2; + if (E < E1) S1 else S2 | - if (E < (E1 = E2)) + E1 = E2; + if (E < E1) S1 /* lesser than or equal to */ | - if (E <= (E1 = E2)) + E1 = E2; + if (E <= E1) S1 else S2 | - if (E <= (E1 = E2)) + E1 = E2; + if (E <= E1) S1 /* greater than or equal to */ | - if (E >= (E1 = E2)) + E1 = E2; + if (E >= E1) S1 else S2 | - if (E >= (E1 = E2)) + E1 = E2; + if (E >= E1) S1 ) /* This rule is for compound statements where the assignment is on the left.*/ @left@ expression E, E1, E2; statement S1, S2; @@ ( /* and */ - if ((E1 = E2) && E) + E1 = E2; + if (E1 && E) S1 else S2 | - if ((E1 = E2) && E) + E1 = E2; + if (E1 && E) S1 | /* or */ - if ((E1 = E2) || E) + E1 = E2; + if (E1 || E) S1 | - if ((E1 = E2) || E) + E1 = E2; + if (E1 || E) S1 else S2 | /* not equal */ - if ((E1 = E2) != E) + E1 = E2; + if (E1 != E) S1 | - if ((E1 = E2) != E) + E1 = E2; + if (E1 != E) S1 else S2 | /* equal */ - if ((E1 = E2) == E) + E1 = E2; + if (E1 == E) S1 | - if ((E1 = E2) == E) + E1 = E2; + if (E1 == E) S1 else S2 | /* greater */ - if ((E1 = E2) > E) + E1 = E2; + if (E1 > E) S1 | - if ((E1 = E2) > E) + E1 = E2; + if (E1 > E) S1 else S2 | /* less */ - if ((E1 = E2) < E) + E1 = E2; + if (E1 < E) S1 | - if ((E1 = E2) < E) + E1 = E2; + if (E1 < E) S1 else S2 /* lesser than or equal to */ - if ((E1 = E2) <= E) + E1 = E2; + if (E1 <= E) S1 | - if ((E1 = E2) <= E) + E1 = E2; + if (E1 <= E) S1 else S2 /* greater than or equal to */ - if ((E1 = E2) >= E) + E1 = E2; + if (E1 >= E) S1 | - if ((E1 = E2) >= E) + E1 = E2; + if (E1 >= E) S1 else S2 ) *** IFASSIGNMENT.COCCI END *** Signed-off-by: -
Aybuke Ozdemir authored
Fix checkpatch.pl issues with line over 80 characters in dgrp_tty.c Signed-off-by:
-
Kristina Martšenko authored
As the TODO file suggests, move firmware file macros from the header file to the file that deals with firmware. In the process also move MODULE_FIRMWARE() instances to the same file. Remove the relevant item from the TODO file. Signed-off-by:
Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with line over 80 characters in nokia_core.c Signed-off-by:
-
Himangi Saraogi authored
This patch removes unnecessary variable assignments which are assigned immediately after the first initialization. Signed-off-by:
-
Chi Pham authored
Fixed some indentation to silence (some) checkpatch errors. The following coccinelle script found the match: @@ expression E0, E1, E2; statement S0, S1; @@ - if ((E1 = E2) != E) + E1 = E2; + if (E1 != E) S1 else S2 Signed-off-by:
-
Elena Oat authored
This patch replaces rtw_zmalloc with kzalloc in function rtw_setstandby_cmd. There are no locks, hence GFP_KERNEL flag is used. Signed-off-by:
Elena Oat <oat.elena@gmail.com> Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/cxt1e1/linux.c:106:13: warning: symbol 'log_level_default' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:110:13: warning: symbol 'max_mru_default' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:255:1: warning: symbol 'c4_linux_interrupt' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:265:1: warning: symbol 'c4_ebus_interrupt' was not declared. Should it be static? Signed-off-by:
-
Gulsah Kose authored
This patch fixes "do not use // C99 comments" errors in linux.c Signed-off-by:
-
Gulsah Kose authored
Fix checkpatch.pl issues with line over 80 characters in comet.c Signed-off-by:
-
Aybuke Ozdemir authored
The patch fixes the following checkpatch.pl warnings: WARNING: Unnecessary space after function pointer name. Signed-off-by:
-
