Commits · 24199c5436f267399afed0c4f1f57663c0408f57 · nexedi / linux

12 Dec, 2018 2 commits

drm/nouveau/kms: Fix memory leak in nv50_mstm_del() · 24199c54

Lyude Paul authored Dec 11, 2018

Noticed this while working on redoing the reference counting scheme in
the DP MST helpers. Nouveau doesn't attempt to call
drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of
the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports.

Fixes: f479c0ba ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v4.10+
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

24199c54

drm/nouveau/kms/nv50-: also flush fb writes when rewinding push buffer · 970a5ee4

Ben Skeggs authored Dec 12, 2018

Should hopefully fix a regression some people have been seeing since EVO
push buffers were moved to VRAM by default on Pascal GPUs.

Fixes: d00ddd9d ("drm/nouveau/kms/nv50-: allocate push buffers in vidmem on pascal")
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Cc: <stable@vger.kernel.org> # 4.19+

970a5ee4

11 Dec, 2018 1 commit

drm/nouveau/drm/nouveau: tegra: Call nouveau_drm_device_init() · 4ac0a807

Thierry Reding authored Nov 23, 2018

As part of commit cfea88a4 ("drm/nouveau: Start using new drm_dev
initialization helpers"), the initialization of the Nouveau DRM device
was reworked and along the way the platform driver initialization was
left incomplete. Add a call to nouveau_drm_device_init() to make sure
all of the structures are properly initialized.
Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

4ac0a807

10 Oct, 2018 16 commits

drm/nouveau/secboot/acr: fix memory leak · 74a07c0a

Gustavo A. R. Silva authored Jul 24, 2018

In case memory resources for *bl_desc* were allocated, release
them before return.

Addresses-Coverity-ID: 1472021 ("Resource leak")
Fixes: 0d466901 ("drm/nouveau/secboot/acr: Remove VLA usage")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

74a07c0a

drm/nouveau/disp: take sink support into account for exposing 594mhz · 9340d77f

Ilia Mirkin authored Sep 03, 2018

Scrambling is required for supporting any mode over 340MHz. If it's not
supported, reject any modes that would require it.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

9340d77f

drm/nouveau/disp: add support for setting scdc parameters for high modes · 7a406f8a

Ilia Mirkin authored Sep 03, 2018

When SCDC is supported, make sure that we configure the GPU and monitor
to the same parameters.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

7a406f8a

drm/nouveau/disp: keep track of high-speed state, program into clock · a971558c

Ilia Mirkin authored Sep 03, 2018

The register programmed by the clock method needs to contain a different
setting for the link speed as well as special divider settings.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

a971558c

drm/nouveau/disp/gm200-: add scdc parameter setter · 4834e050

Ilia Mirkin authored Sep 03, 2018

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

4834e050

drm/nouveau/disp: add a way to configure scrambling/tmds for hdmi 2.0 · 4126b99e

Ilia Mirkin authored Sep 03, 2018

High pixel clocks are required to use a 40 TMDS divider instead of 10,
and even low ones may optionally use scrambling depending on device
support.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

4126b99e

drm/nouveau: Start using new drm_dev initialization helpers · cfea88a4

Lyude Paul authored Aug 22, 2018

Per the documentation in drm_get_pci_dev(), this function is deprecated
and shouldn't be used anymore. As it turns out, we're going to need to
stop using drm_get_pci_dev() anyway in order to allow us to turn off the
card before full system shutdowns, otherwise we'll hit race conditions
with userspace while trying to tear down the card on shutdown.

So, start using drm_dev_get() and drm_dev_put(), and just turn our
load/unload callbacks into open coded init/fini() functions.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

cfea88a4

drm/nouveau: Fix potential memory leak in nouveau_drm_load() · c4cee69a

Lyude Paul authored Aug 22, 2018

We forget to free drm in all instances of failure, and additionally also
forget to destroy the master client if the other client fails
initialization.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

c4cee69a

drm/nouveau: Refactor nvXX_backlight_init() · e15e4c13