- 05 Mar, 2016 23 commits
-
-
Rasmus Linusson authored
Reorder comments to keep 80 character limit Signed-off-by:
Rasmus Linusson <rasmus@linusson.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Rasmus Linusson authored
Add asterisks to multi-line comments currently missing them Signed-off-by:
-
Bhumika Goyal authored
The functions s626_get_clk_mult, s626_get_clk_mult, s626_get_enc_mode, s626_set_index_pol are not used anywhere in the kernel so they can be removed. This also cleans the code. Grepped to find the occurences. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace pci_[alloc|free]_consistent occurences with dma_[alloc|free]_coherent. The Coccinelle semantic patch that was used to make some of these changes is as follows: @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id, ...) ) @bad1@ idexpression id; position deprecated.p; @@ ...when != &id->dev when != pci_get_drvdata ( id ) when != pci_enable_device ( id ) ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id, ...) ) @depends on !bad1@ idexpression id; expression direction; position deprecated.p; @@ ( - pci_dma_supported@p ( id, + dma_supported ( &id->dev, ... + , GFP_KERNEL ) | - pci_alloc_consistent@p ( id, + dma_alloc_coherent ( &id->dev, ... + , GFP_KERNEL ) ) alloc_and_init_dma_members does not affect the interrupt status and is only called by auto_attach, which also does not affect the interrupt status. auto_attach() also contains a call to comedi_alloc_devpriv() which calls kzalloc with GFP_KERNEL flag. Thus, there seems to be no danger that dma_alloc_coherent can be called with interrupts turned off, and GFP_KERNEL can be used. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Remove NULL check before kfree as it is not needed. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Philippe Loctaux authored
Makes the comment blocks start with /* on separate lines, and end with */ on separate lines as well, starting with * for each comment lines. Signed-off-by:
Philippe Loctaux <phil@philippeloctaux.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Bhaktipriya Shridhar authored
Occurences of the computation (x +d/2)/d can be replaced with the macro DIV_ROUND_CLOSEST. This was detected by the following Coccinelle script. @@ expression e1,e2; @@ ( - ((e1) + e2/2) / (e2) + DIV_ROUND_CLOSEST(e1,e2) | - ((e1) + (e2/2)) / (e2) + DIV_ROUND_CLOSEST(e1,e2) ) Since some lines exceeded the 80 character limit, some changes were made by hand. Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Alan authored
It's not trivial to just post up a fix, so add it to the TODO list and ensure it doesn't get lost. Signed-off-by: -
Bhumika Goyal authored
The macro random_ether_addr is calling the function eth_random_addr. Therefore, the call to random_ether_addr can be replaced with eth_random_addr. Done using coccinelle: @@ expression addr; @@ - random_ether_addr(addr); + eth_random_addr(addr); Signed-off-by:
-
Bhumika Goyal authored
This patch replaces ternary operator with macro min as it shorter and thus increases code readability. Macro min return the minimum of the two compared values. Made a semantic patch for changes: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by:
-
Amitoj Kaur Chawla authored
With concurrency managed workqueues, use of dedicated workqueues can be replaced by using system_wq. Drop usb_tx_wq and usb_rx_wq by using system_wq. Since there are multiple work items per udev but different udevs do not need to be ordered, increase of concurrency level by switching to system_wq should not break anything. cancel_work_sync() is used to ensure that work is not pending or executing on any CPU. Lastly, since all devices are suspended, which shutdowns the work items before the driver can be unregistered, it is guaranteed that no work item is pending or executing by the time exit path runs. Signed-off-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
-
Dan Carpenter authored
We know "len" is not zero because we tested for that at the beginning of the function so this test can be removed. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
"size" here should be unsigned, otherwise we might end up trying to copy negative bytes in gdm_wimax_ioctl_get_data() resulting in an information leak. Reported-by:
Alan Cox <gnomes@lxorguk.ukuu.org.uk> Signed-off-by:
-
Dan Carpenter authored
We pad the start of this buffer with 256 bytes of padding. It's not clear to me exactly what's going on or how it's used but let's zero it out. Signed-off-by:
-
Dan Carpenter authored
We had an underflow bug here and I think I fixed it but we may as well be proactive and make "len" unsigned to be double sure. Signed-off-by:
-
Dan Carpenter authored
The value of "group" comes from "idx" in __gdm_wimax_event_send(): if (sscanf(e->dev->name, "wm%d", &idx) == 1) Smatch marks sscanf values as user controlled. It's supposed to be a number in 0-30 range. We cap the upper bound but allow negatives. Fix this by making it type u16 instead. Signed-off-by:
-
Dan Carpenter authored
If nlh->nlmsg_len is less than ND_IFINDEX_LEN we end up trying to memcpy a negative size. I also re-ordered slighty the condition to make it more uniform. Signed-off-by:
-
Tapan Prakash T authored
drivers: staging: rtl8712: rtl871x_xmit.c: Fix Comparisons should place the constant on the right side of the test warning Fixed checkpatch.pl warning 'Comparisons should place the constant on the right side of the test' Signed-off-by:
Tapan Prakash T <tapanprakasht@gmail.com> Signed-off-by:
-
Alan authored
If 32 bytes of non zero are passed in pdata->pointer then the mac_pton function will run off the end of the buffer. Make sure we always have a terminated string kernel side. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove unnecessary test on synth->alive since it has already been tested previously. This fixes the following smatch warning: drivers/staging/speakup/synth.c:182 spk_synth_is_alive_restart() warn: we tested 'synth->alive' before and it was 'false' Signed-off-by:
-
Alison Schofield authored
Remove multiple assignments by factorizing. Coccinelle semantic patch used: @@ identifier x,y; constant z; @@ - x=y=z; + x=z; + y=z; Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Dilek Uzulmez authored
Add space around operator '|'. Problem found using checkpatch.pl CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by:
Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by:
-
James Simmons authored
Originally the function cfs_str2num_check used simple_strtoul but has been updated to kstrtoul. The string passed into cfs_str2num_check can be a very complex, for example we could have 10.37.202.[59-61]. When simple_strtoul was used the first number until we hit a non-digit character could be extracted but testing showed that kstrtoul will not return any value if it detects any non-digit character. Because of this change in behavior a different approach is needed to handle these types of complex strings. The use of sscanf was investigated to see if it could be used to extract numbers from the passed in string but unlike its glibc counterpart the kernel version also just reported a error with no results if a non-digit value in the string was encountered. Another possible approach would be to use __parse_int directly but that class of functions is not exported by the kernel. So the approach in this patch is to scan the string passed in for the first non-digit character and replace that character with a '\0' so kstrtoul can be used. Once completed the original character is restored. We also restore a original behavior that was removed to return 0 when we encounter any non digit character before the nob count. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
- 04 Mar, 2016 12 commits
-
-
Chaehyun Lim authored
It is more readable than multiple if-else statement. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch removes unnecessary comments because enum cfg_cmd_type shows each command type without it. Signed-off-by:
-
Chaehyun Lim authored
This patch adds a new enum cfg_type_cmd to change hard-coded command type. Signed-off-by:
-
Chaehyun Lim authored
This patch renames hardwareProductVersion to hw_product_version to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch removes commented codes in struct wilc_cfg_str. Signed-off-by:
-
Chaehyun Lim authored
TAG_PARAM_OFFSET is defined at top of this file so that it is used to simplify codes. Signed-off-by:
-
Anchal Jain authored
Remove a whitespace before parenthesis "(" Signed-off-by:Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch removes typedef from enum tenuConnectSts and renames it to connect_status to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch removes INFINITE_SLEEP_TIME that is not used in the driver, so just remove it. Signed-off-by:
-
Chaehyun Lim authored
This patch removes typedef from struct sdio_cmd53_t and renames it to sdio_cmd53. Signed-off-by:
-
Chaehyun Lim authored
This patch removes unnecessary comment code in struct sdio_cmd53_t. Signed-off-by:
-
Chaehyun Lim authored
This patch removes typedef from struct sdio_cmd52_t and renames it to sdio_cmd52. Signed-off-by:
-
- 03 Mar, 2016 5 commits
-
-
Liang Zhen authored
ko2iblnd may retry too frequent for growing pools, all schedulers are spinning if another thread is in progress of allocating a new pool and can't finish right away because of high system load. Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7054 Reviewed-on: http://review.whamcloud.com/16470Reviewed-by:
Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by:
James Simmons <uja.ornl@yahoo.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Liang Zhen authored
When there is a connection race between two nodes and one side of the connection is rejected by the other side. o2iblnd will reconnect immediately, this is going to generate a lot of trashes if: - race winner is slow and can't send out connecting request in short time. - remote side leaves a cmid in TIMEWAIT state, which will reject future connection requests To resolve this problem, this patch changed the reconnection behave: reconnection is submitted by connd only if a zombie connection is being destroyed and there is a pending reconnection request for the corresponding peer. Also, after a few rejections, reconnection will have a time interval between each attempt. Signed-off-by:
-
Liang Zhen authored
If ib_poll_cq returned +ve without initialising ib_wc::wr_id (bug in driver), then o2iblnd will run into unpredictable situation because ib_wc::wr_id may refer to stale tx/rx pointer in stack. It indicates bug in HCA driver if this happened, ko2iblnd should output console error then close current connection. This patch could also be helpful for LU-5271 Signed-off-by:
Isaac Huang <he.huang@intel.com> Reviewed-by:
-
Doug Oucharek authored
A race condition has been found where connd is cleaning up failed connections, the peer ref counter goes to zero, but we stil have a connecting counter > 0. One possible race is when we are retrying a connection by calling kiblnd_connect_peer() which itself fails and decrements the peer ref counter and gets swapped out before it can decrement the connecting counter. connd swaps in and cleans up the connection where it sees a peer ref counter of 1 and a connecting counter of 1. This will trigger the assert seen in LU-7210 when it decrements the peer counter. The solution: be sure to decrement the connecting counter before decrementing the peer counter in the peer connect failure path. Signed-off-by:
Amir Shehata <amir.shehata@intel.com> Reviewed-by:
-
Liang Zhen authored
refcount taken by cmid is not reliable after kiblnd_connreq_done released the glock because this connection is visible to other threads, another thread can find and close this connection right after kiblnd_connreq_done released the glock, if kiblnd_cm_callback for RDMA_CM_EVENT_DISCONNECTED is called, it can release the connection refcount taken by cmid. It means the connection could be destroyed before kiblnd_connreq_done() finish operations on it. Signed-off-by:
-
