Skip to content

L
linux
Switch branch/tag
  1. 14 Jul, 2011 1 commit
    • Steven Whitehouse's avatar
      GFS2: Resolve inode eviction and ail list interaction bug · 380f7c65
      Steven Whitehouse authored 
      This patch contains a few misc fixes which resolve a recently
reported issue. This patch has been a real team effort and has
received a lot of testing.

The first issue is that the ail lock needs to be held over a few
more operations. The lock thats added into gfs2_releasepage() may
possibly be a candidate for replacing with RCU at some future
point, but at this stage we've gone for the obvious fix.

The second issue is that gfs2_write_inode() can end up calling
a glock recursively when called from gfs2_evict_inode() via the
syncing code, so it needs a guard added.

The third issue is that we either need to not truncate the metadata
pages of inodes which have zero link count, but which we cannot
deallocate due to them still being in use by other nodes, or we need
to ensure that those pages have all made it through the journal and
ail lists first. This patch takes the former approach, but the
latter has also been tested and there is nothing to choose between
them performance-wise. So again, we could revise that decision
in the future.

Also, the inode eviction process is now better documented.
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
Tested-by: default avatarBob Peterson <rpeterso@redhat.com>
Tested-by: default avatarAbhijith Das <adas@redhat.com>
Reported-by: default avatarBarry J. Marson <bmarson@redhat.com>
Reported-by: default avatarDavid Teigland <teigland@redhat.com>
      380f7c65
  3. 12 Jul, 2011 2 commits
    • Steven Whitehouse's avatar
      GFS2: Fix race during filesystem mount · 3942ae53
      Steven Whitehouse authored 
      There is a potential race during filesystem mounting which has recently
been reported. It occurs when the userland gfs_controld is able to
process requests fast enough that it tries to use the sysfs interface
before the lock module is properly initialised. This is a pretty
unusual case as normally the lock module initialisation is very quick
compared with gfs_controld.

This patch adds an interruptible completion which is used to ensure that
userland will wait for the initialisation of the lock module to
complete.

There are other potential solutions to this problem, but this is the
quickest at this stage and has been tested both with and without
mount.gfs2 present in the system.
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
Reported-by: default avatarDavid Booher <dbooher@adams.net>
      3942ae53
    • Benjamin Marzinski's avatar
      GFS2: force a log flush when invalidating the rindex glock · 1ce53368
      Benjamin Marzinski authored 
      Right now, there is nothing that forces the log to get flushed when a node
drops its rindex glock so that another node can grow the filesystem. If the
log doesn't get flushed, GFS2 can corrupt the sd_log_le_rg list in the
following way.

A node puts an rgd on the list in rg_lo_add(), and then the rindex glock is
dropped so the other node can grow the filesystem. When the node reacquires the
rindex glock, that rgd gets deleted in clear_rgrpdi() before ever being
removed from the list by gfs2_log_flush().

This code simply forces a log flush when the rindex glock is invalidated,
solving the problem.
Signed-off-by: default avatarBenjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      1ce53368
  5. 11 Jul, 2011 15 commits
  7. 10 Jul, 2011 9 commits
  9. 09 Jul, 2011 13 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7