o Fix a few twin channel target id calculation bugs
   in the domain validation code.  These would only
   effect the 2742T.

 o Remove errno and unistd.h usage
 o Remove splitting of S/G elements that cross
   a 4GB boundary.  Code above the driver already
   guatantees that this cannot happen.
 o Simplify irqreturn_t compatibility glue.
 o Fix GCC 3.3 warnings.

C preprocessor expressions work, guys!)

aic7xxx/79xx wants a variant of scsi_report_bus_reset that operates
only on a single device.  Implement it to get rid of shost->my_devices
traversals in drivers.  (and move both to scsi_error.c)

 o Misc compiler error and code cleanups.

> On Thu, May 01, 2003 at 04:28:12PM -0600, Justin T. Gibbs wrote:
>> Folks,
>>
>> I've just uploaded version 1.3.8 of the aic79xx driver and version
>> 6.2.33 of the aic7xxx driver.  Both are available for 2.4.X and
>> 2.5.X kernels in either bk send format or as a tarball from here:
>>
>> http://people.FreeBSD.org/~gibbs/linux/SRC/
>
> Hi Justin,
>
> I've just tested it and I still have the deadlock on SMP. I also tried with
> noapic, but it didn't change. I have reduced the TCQ from 253 to 32, and I
> had the impression that it was more difficult to trigger, although I cannot
> be certain. With 32, I could boot and go to about half the 'make -j 8 dep',
> while it hanged during init script with 253. I may retest by the week-end, but
> now I'm going to sleep. Now I'm back to 6.2.28 and everything's OK.

Can you try with this patch?  It seems I forgot to pull part of a change
from the aic79xx driver into the aic7xxx driver.  This could easily cause
a lock order reversal. <sigh>

 o Correct MODULE_INFO string.
 o Bump version number.

 o Adapt to new IRQ handler declaration/behavior for 2.5.X

  Remove pre-2.2.X kernel support. 

 o Correct type safty of option parsing logic
 o Make option toggling work correctly
 o Add "probe_eisa_vlb" as an alias for the "no_probe" option so
   that there is a clearly defined name associated with the command
   line feature that allows eisa_vlb probes to be enabled/disabled
   in the aic7xxx driver.
 o PCI parity error checking defaults to being enabled.

 o Fix style nits.

 o Remove extra complexity and code duplication in processing
   the completeq now that the completeq can be run while holding
   both the ah?_lock and the done_lock.

 o Work around peculiarities in the scan_scsis routines
   that could, due to having duplicate devices on our
   host's device list, cause tagged queing to be disabled
   for devices added via /proc.

o Avoid pre-2.5.X mid-layer deadlock due to SCSI malloc fragmentation

For pre-2.5.X kernels, attempt to calculate a safe value
for our S/G list length.  In these kernels, the midlayer
allocates an S/G array dynamically when a command is issued
using SCSI malloc.  This list, which is in an OS dependent
format that must later be copied to our private S/G list, is
sized to house just the number of segments needed for the
current transfer.  Since the code that sizes the SCSI malloc
pool does not take into consideration fragmentation of the
pool, executing transactions numbering just a fraction of our
concurrent transaction limit with list lengths aproaching
AH?_NSEG in length will quickly depleat the SCSI malloc pool
of usable space.

Unfortunately, the mid-layer does not properly handle this
scsi malloc failure.  In kernels prior to 2.4.20, should
the device that experienced the malloc failure be idle and
never have any new I/O initiated (block queue is not "kicked"),
the process will hang indefinitely.  In 2.4.20 and beyond,
the disk experiencing the failure is marked as a "starved
device", but this only helps if I/O is initiated to or completes
on that HBA.  If the failure was induced by another HBA, and
no other I/O is pending on the HBA and no new transactions are
queued, we are still succeptible to the hang.  (Also note that
many 2.4.X kernels do not properly lock the "some_device_starved"
and "device_starved" fields calling into question their overall
effectiveness).

By sizing our S/G list to avoid SCSI malloc pool fragmentation,
we will hopefully avoid this deadlock at least for configurations
where our own HBAs are the only ones using the SCSI subsystem.

was for them or not, so that the irq subsystem can properly
handle screaming shared interrupts.

So change the irq handlers to return a "irqretval_t", which
is either IRQ_HANDLED or IRQ_NONE.

 o Perform an audit on use of del_timer() and switch to del_timer_sync()
   where appropriate.
 o Remove the reboot notifier hook which is unused in 2.5.X.
 o Correct some driver unload bugs.

From: Zwane Mwaikambo <zwane@linuxpower.ca>

ahc_linux_free_device() needs to use del_timer_sync().  slab corruption has
been observed due to the timer handler running after the containing object
was freed.

 o Clean up driver locking by making the locking semantics between
   2.4.X and 2.5.X almost identical.  Take advantage of SCSI_HAS_HOST_LOCK
   in certain RedHat kernels.
 o Clean up command line parsing.
 o Fix module unload/reload issues stemming from DV thread teardown
   and a missing deregistration of our reboot notifier (lost during
   PCI hot plug integration).

 o Fix initial DV scan to scan more than just the first target.
 o Fix compilation on SuSE 2.4.16 kernels.

I remember having this submitted a while ago, but here's the code
again, this time with the untested aic79xx bits.

    accomodate -> accommodate
    accomodated -> accommodated
    accomodates -> accommodates

 o Fix async negotiation bug when the initial bus reset is
   disabled if the target device rejects our WDTR of 0.
 o Fix typos.
 o Fix printf formats to work in both C99 and C89 environments.

 o Add bus attachment specific hooks for chip-init, suspend and
   resume.  This is a precursor to better suspend and resume support.
 o Fix a bug that could cause unnecessary renegotiations after selection
   timeouts.
 o Fix a hang that occurred if the mid-layer attempted to probe devices
   at the controller's own ID.
 o Add some delays to the termination detection logic for 785X chips.
   This might resolve some termination problems on very early controllers.

This provides the following spelling fix.

 accessable -> accessible

.. and update all callers to use the generic scsi_set_device.

Add a name argument to daemonize() (va_arg) to avoid all the
kernel threads having to duplicate the name setting over and
over again.

Make daemonize() disable all signals by default, and add a
"allow_signal()" function to let daemons say they explicitly
want to support a signal.

Make flush_signal() take the signal lock, so that callers do
not need to.

CONFIG_MODVERSIONING was a temporary name introduced to distinguish
between the old and new module version implementation. Since the
traces of the old implementation are now gone from the build system,
we rename the config option back in order to not confuse users more
than necessary in 2.6.
 
Also, remove some historic modversions cruft throughout the tree.

this patch implements the new command allocation scheme for SCSI
Core, using the slab cache and a free_list for each host for a
backup store of one command (or many).

 o The three (3) subversion means that it has been updated to use
   ISA DMA and PCI DMA memory for scsi command allocation,
   i.e. there's two scsi command caches now.

 o The interface is, of course, unchanged; and this is the whole
   point of making this allocation scheme -- i.e. the allocator
   is abstracted.

	o Add some more DV diagnostic code
	o Fix bug that cause sequencer debug code to be
	  downloaded always.

Aic79xx Driver Update 1.3.0.RC2
	o Correct a bug that effectively limited DV to just ID 0.
	o Add some more DV diagnostic code
	o Misc code cleanups.

  o Determine more conclusively that a BIOS has initialized the
    adapter before using "left over BIOS settings".
  o Adapt to upcoming removal of cmd->target/channel/lun/host in 2.5.X
  o Fix a memory leak on driver unload.
  o Enable the pci_parity command line option and default to pci parity
    error detection *disabled*.  There are just too many broken VIA
    chipsets out there.
  o Move more functionality into aiclib to share with the aic79xx driver.
  o Correct a few negotiation regressions.
  o Don't bother doing full DV on devices that only support async transfers.
    This should fix a few more of the reported problems with DV.

Aic79xx Driver Update
  o Add abort and bus device reset handlers.
  o Fix a memory leak on driver unload.
  o Adapt to upcoming removal of cmd->target/channel/lun/host in 2.5.X.
  o Correct a few negotiation regressions.

	Don't bother with DV if the device can only do async

	o Correct memory mapped I/O test for legacy controllers
	  that do not have the "auto-access-pause" feature.
	o Prevent NMIs from triggering should the MMAP I/O test fail.
	o Fix aic7770 (EISA/VLB) controller regression.
	o Kill a few compiler warnings.

 o Do not fallback to a wide speed if the device does not support
   wide transfers.

 o Don't bother allocating target instances for wide IDs on narrow
   controllers.

 o Add a few additional diagnostics to aid in tracking down DV bugs.

but somehow are not handled by the DV state machine.  This ensures that
the behavior seen before DV is restored in the event of a DV state machine
failure.

counted toward the load average. 

Daemonize the kernel threads used for domain validation.